From a02d76845f266ec692af0854aca433e8246d7715 Mon Sep 17 00:00:00 2001 From: "kjellander@webrtc.org" Date: Fri, 23 Jan 2015 14:34:52 +0000 Subject: [PATCH] Disable DtmfSenderTest.InsertDtmfWithCommaAsDelay due to flakiness Disabling the test on all platforms since it's likely it can happen on any platform, even if it's only been observed on Win x64 Release. Running tests in parallel is a huge performance benefit to the team, since it approximately reduces build cycle with 60-75%. BUG=4219 TBR=pthatcher@webrtc.org Review URL: https://webrtc-codereview.appspot.com/34019004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@8138 4adac7df-926f-26a2-2b94-8c16560cd09d --- talk/app/webrtc/dtmfsender_unittest.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/talk/app/webrtc/dtmfsender_unittest.cc b/talk/app/webrtc/dtmfsender_unittest.cc index 2a9d642b8..861a69574 100644 --- a/talk/app/webrtc/dtmfsender_unittest.cc +++ b/talk/app/webrtc/dtmfsender_unittest.cc @@ -324,7 +324,9 @@ TEST_F(DtmfSenderTest, InsertEmptyTonesToCancelPreviousTask) { VerifyOnObserver("1"); } -TEST_F(DtmfSenderTest, InsertDtmfWithCommaAsDelay) { +// Flaky when run in parallel. +// See https://code.google.com/p/webrtc/issues/detail?id=4219. +TEST_F(DtmfSenderTest, DISABLED_InsertDtmfWithCommaAsDelay) { std::string tones = "3,4"; int duration = 100; int inter_tone_gap = 50;