generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Reenable dlclose() for InternalUnloadDll on TSan.

Browse Source 
Upstream TSan bug has been fixed and dlclose() no longer needs to be
excluded.

R=henrika@webrtc.org
BUG=3895

Review URL: https://webrtc-codereview.appspot.com/30099004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8016 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
pbos@webrtc.org 2015-01-07 18:02:39 +00:00
parent bab79951ca
commit 3663fb08ff
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
webrtc/modules/audio_device/linux/latebindingsymboltable_linux.cc
View File

@ -54,15 +54,12 @@ void InternalUnloadDll(DllHandle handle) {
// stack trace gets displayed as <unknown module> instead of the actual library
// -> it can not be suppressed.
// https://code.google.com/p/address-sanitizer/issues/detail?id=89
//
// Skip dlclose() on ThreadSanitizer since it's hitting an assert.
// https://code.google.com/p/webrtc/issues/detail?id=3895
#if !defined(ADDRESS_SANITIZER) && !defined(THREAD_SANITIZER)
#if !defined(ADDRESS_SANITIZER)
if (dlclose(handle) != 0) {
WEBRTC_TRACE(kTraceError, kTraceAudioDevice, -1,
"%s", GetDllError());
}
#endif // !defined(ADDRESS_SANITIZER) && !defined(THREAD_SANITIZER)
#endif // !defined(ADDRESS_SANITIZER)
#else
#error Not implemented
#endif