generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Changing the default VP8 packetization mode setting to kAggregate and balanced, from the previous settig of kStrict and balanced.

Browse Source 
The previous kStrict mode could generate very small packets when the encoded frame is smaller than MTU size. kAggregate will instead encapsulate whole frame into one packet if frame size is below MTU (and so will not generate too small packets), and otherwise it will separate out the first partition as in kStrict mode.

The balanced setting for kAggregate (from default of un-balanced) is also desirable, as equal size packets (for the first and remaining partition) should generally be more favorable for FEC.
Review URL: http://webrtc-codereview.appspot.com/89002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@239 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
marpan@google.com 2011-07-21 16:49:54 +00:00
parent 022716b3af
commit 1b43b6d416
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/modules/rtp_rtcp/source/rtp_format_vp8.cc
View File

@ -20,7 +20,7 @@ namespace webrtc {
const RtpFormatVp8::AggregationMode RtpFormatVp8::aggr_modes_[kNumModes] =
{ kAggrNone, kAggrPartitions, kAggrFragments };
const bool RtpFormatVp8::balance_modes_[kNumModes] =
{ true, false, false };
{ true, true, false };
const bool RtpFormatVp8::separate_first_modes_[kNumModes] =
{ true, false, false };

2
src/modules/rtp_rtcp/source/rtp_sender_video.cc
View File

@ -1235,7 +1235,7 @@ RTPSenderVideo::SendVP8(const FrameType frameType,
assert(rtpTypeHdr);
RtpFormatVp8 packetizer(data, payloadBytesToSend, rtpTypeHdr->VP8,
*fragmentation, kStrict);
*fragmentation, kAggregate);
bool last = false;
_numberFirstPartition = 0;