From 1b43b6d4160ddcd17a6bee2a423cd6c8bd786aeb Mon Sep 17 00:00:00 2001 From: "marpan@google.com" Date: Thu, 21 Jul 2011 16:49:54 +0000 Subject: [PATCH] Changing the default VP8 packetization mode setting to kAggregate and balanced, from the previous settig of kStrict and balanced. The previous kStrict mode could generate very small packets when the encoded frame is smaller than MTU size. kAggregate will instead encapsulate whole frame into one packet if frame size is below MTU (and so will not generate too small packets), and otherwise it will separate out the first partition as in kStrict mode. The balanced setting for kAggregate (from default of un-balanced) is also desirable, as equal size packets (for the first and remaining partition) should generally be more favorable for FEC. Review URL: http://webrtc-codereview.appspot.com/89002 git-svn-id: http://webrtc.googlecode.com/svn/trunk@239 4adac7df-926f-26a2-2b94-8c16560cd09d --- src/modules/rtp_rtcp/source/rtp_format_vp8.cc | 2 +- src/modules/rtp_rtcp/source/rtp_sender_video.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/rtp_rtcp/source/rtp_format_vp8.cc b/src/modules/rtp_rtcp/source/rtp_format_vp8.cc index 1b9ea8d60..358dd8f59 100644 --- a/src/modules/rtp_rtcp/source/rtp_format_vp8.cc +++ b/src/modules/rtp_rtcp/source/rtp_format_vp8.cc @@ -20,7 +20,7 @@ namespace webrtc { const RtpFormatVp8::AggregationMode RtpFormatVp8::aggr_modes_[kNumModes] = { kAggrNone, kAggrPartitions, kAggrFragments }; const bool RtpFormatVp8::balance_modes_[kNumModes] = - { true, false, false }; + { true, true, false }; const bool RtpFormatVp8::separate_first_modes_[kNumModes] = { true, false, false }; diff --git a/src/modules/rtp_rtcp/source/rtp_sender_video.cc b/src/modules/rtp_rtcp/source/rtp_sender_video.cc index 6994cb582..701aaabad 100644 --- a/src/modules/rtp_rtcp/source/rtp_sender_video.cc +++ b/src/modules/rtp_rtcp/source/rtp_sender_video.cc @@ -1235,7 +1235,7 @@ RTPSenderVideo::SendVP8(const FrameType frameType, assert(rtpTypeHdr); RtpFormatVp8 packetizer(data, payloadBytesToSend, rtpTypeHdr->VP8, - *fragmentation, kStrict); + *fragmentation, kAggregate); bool last = false; _numberFirstPartition = 0;