generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Suppress races in event tracing code.

Browse Source 
Due to lack of atomics our tracing code is broken and triggering real
errors in ThreadSanitizer.

R=kjellander@webrtc.org
BUG=2497
TEST=out-tsan/out/Debug/libjingle_media_unittest --gtest_filter=WebRtcVideoMediaChannelTest.GetStatsMultipleRecvStreams + verifying that "race:*trace_event_unique_catstatic*" exists in the list of matched suppressions.

Review URL: https://webrtc-codereview.appspot.com/35719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8022 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
pbos@webrtc.org 2015-01-08 12:38:42 +00:00
parent 5f09564354
commit 124b9c70f9
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/build/tsan_suppressions_webrtc.cc
View File

@ -77,6 +77,10 @@ char kTSanDefaultSuppressions[] =
"deadlock:webrtc::ViEEncoder::OnLocalSsrcChanged\n"
"deadlock:webrtc::ViESender::RegisterSendTransport\n"
// TODO(pbos): Trace events are racy due to lack of proper POD atomics.
// https://code.google.com/p/webrtc/issues/detail?id=2497
"race:*trace_event_unique_catstatic*\n"
// End of suppressions.
; // Please keep this semicolon.