From 124b9c70f9986fd06ac2f1c4b2dfc7d4345b9fcc Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Thu, 8 Jan 2015 12:38:42 +0000 Subject: [PATCH] Suppress races in event tracing code. Due to lack of atomics our tracing code is broken and triggering real errors in ThreadSanitizer. R=kjellander@webrtc.org BUG=2497 TEST=out-tsan/out/Debug/libjingle_media_unittest --gtest_filter=WebRtcVideoMediaChannelTest.GetStatsMultipleRecvStreams + verifying that "race:*trace_event_unique_catstatic*" exists in the list of matched suppressions. Review URL: https://webrtc-codereview.appspot.com/35719004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@8022 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/build/tsan_suppressions_webrtc.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/webrtc/build/tsan_suppressions_webrtc.cc b/webrtc/build/tsan_suppressions_webrtc.cc index 01658ed24..e678067ff 100644 --- a/webrtc/build/tsan_suppressions_webrtc.cc +++ b/webrtc/build/tsan_suppressions_webrtc.cc @@ -77,6 +77,10 @@ char kTSanDefaultSuppressions[] = "deadlock:webrtc::ViEEncoder::OnLocalSsrcChanged\n" "deadlock:webrtc::ViESender::RegisterSendTransport\n" +// TODO(pbos): Trace events are racy due to lack of proper POD atomics. +// https://code.google.com/p/webrtc/issues/detail?id=2497 +"race:*trace_event_unique_catstatic*\n" + // End of suppressions. ; // Please keep this semicolon.