Mass warning clean up. Mainly:
- Explicit casts of numeric literals to avoid signed/unsigned compare
warnings.
- Commenting out of unused function arg names.
Change-Id: I0e70393a5743ae984035d43712c724d4ccd12f9d
libwebm_util:
- Add 90khz -> nanosecond conversion.
vpxpes_parser:
- Get rid of VpxPesParser::VpxFrame and use VideoFrame.
- Store/Accumulate (when neccessary) PES payloads in
VideoFrames.
- Change type of size constants from int to size_t.
- Return offset accounting for origin from FindStartCode().
- Check all PTS marker bits (instead of checking the second
marker twice).
video_frame:
- Add nanosecond_pts mutator.
webm2pes:
- Write DTS/PTS presence flag correctly when PTS is not
present.
Change-Id: I10f16cd03bb3a51205a25331527ddceb3769ba03
VideoFrame was created in order to get rid of the two
slightly different VpxFrame implementations. This patch
gets rid of Webm2Pes's version.
Change-Id: I5af29d5ca717121ee7ab30f28e42d2a43ea5abb0
WritePesPacket() now takes a VpxFrame as input and a
PacketDataBuffer* as an output parameter, and avoids
using members entirely. This facilitates deeper testing
of Webm2Pes without requiring friendship with test
classes and methods.
Change-Id: I076db8900cc1a5c864b54f5fe3403fb05b4bd835
Makes writing tests easier by allowing caller to pass data
for packetizing directly into the method.
Change-Id: I553fa8c1636041c4a5ff043862918a5cdc9163ba
- Make start codes reliable for VPx in PES.
- Stop setting the PES size field and stop splitting packets when
larger than UINT16_MAX (always set 0; rely on start codes to find
packet boundaries).
Change-Id: I402e91c26562e930f61543ca59223b83cc92be29
There's a leak in the following scenario:
* AccurateClusterDuration is set to true.
* Add a few frames.
* An error is encountered while adding a frame and the
application bails without calling Cluster::Finalize
* All the frames we queues in QueueOrWriteFrames now leak.
This patch fixes this scenario by delete'ing any left over frames
in the Cluster's destructor.
Change-Id: I104f6814db18a86fae9877decfe6cc75b8937fcb
Also, add some constants for WebVTT codec ID strings so they
won't cause doctype to incorrectly change to matroska.
Change-Id: I4740a3e45b28a22e462601b9ce051aa01817dace
Output the flag being checked before checking the flag to make it easier
to determine exactly which check failed.
Change-Id: I692f5287f985acb4a3061dd54f7c5a8729def83b
Some downstream code using the EBML element size requires that
EbmlElementSize and EbmlMasterElementSize are accessible in the global
namespace.
Change-Id: I9d110b683e434c90f96ae7b35b35e79eb6a2335f
- The direct change to stdint.h types causes too much downstream
churn. Need an intermediate step or a wrapper because quite a
bit of user code explicitly casts args passed to mkvmuxerutil
functions to types defined in mkvmuxertypes.
- Update call sites in mkvmuxer to avoid ambiguity errors.
Change-Id: I018445b3d8ab1da776ecdb19a290ac00af63c2cf
