replace assert with a check of the pointer, this is a public function so
should be tolerant of invalid parameters
BUG=webm:1415
Change-Id: I28a3a2ef905d62f11928dbbe54c119411d2b1f74
use GetTrackByIndex() rather than GetTrackByNumber(). the former is
0-based the latter is by track id, this loop iterates through all tracks
based on the track count.
fixes a segfault with tracks non-starting at 1 / increasing by 1.
BUG=webm:1415
Change-Id: I916328575d0871cf4090b1d123644d6f01e6ffb1
this path has been error checked since:
986b64b mkvparser: Add error checking in Block::Parse.
BUG=webm:1405
Change-Id: I1c17c05076455f25ab888555d71d7b27c032e9dd
FLT_MIN is the smallest finite value (numeric_limits::min()) -FLT_MAX is
the correct for the most negative (numeric_limits::lowest())
http://en.cppreference.com/w/cpp/types/numeric_limits
BUG=b/36255773
BUG=webm:1381
Change-Id: Iaaff611acffc3df28fef12af81ac5299791f0148
Users who want this feature can explicitly turn it on. Since it
involves estimating, it should be off by default.
Change-Id: I3e934169d19b68a276c21d694179350c5b315a5a
PrimaryChromaticity::Parse never owns the PrimaryChromaticity
it allocates-- avoid freeing it because doing so results in a
double free when the MasteringMetadata dtor runs.
BUG=webm:1381
Change-Id: Ief0159f6ab667234e3fdc51c65f23ef5efb32a71
EbmlElementSize for char* assumes that the varint encoding of
payload size is always 1-byte. Fix that by using the correct
number of bytes.
mkvinfo of the new gold file: http://pastebin.com/ncR7DqEf
Change-Id: I2d10708de77b2b8089900a8719ee3797dfb6994c
A target must exist before its properties can be set. Defer
libwebm target rename on windows until after creation of the
webm library target.
Change-Id: I29c5e90f1f653a00ff156316c03b0ffd78e9a998
It always passed after first test due to lack of CACHE in unset()
call. Also:
- Fix flag name in error message.
- Use actual flag instead of hard coded -std=c++11
Change-Id: I29c0dc4fd0f5ce97f658919a5739e15831a00281
- Split sources from targets. Source files are stored in list variables,
and targets now use the list vars.
- Surface all build settings control in CMakeLists.txt.
- Remove individual C++11 tests in favor of requiring support
for --std=c++11.
- Improve organization; stop reopening the same if's.
Change-Id: I1989803fdfd9c032f417a5fc12985671455148bd
Force creation of a new Cluster when writing queued audio would
cause an error due to violating maximum block duration.
BUG=675521
Change-Id: I6ad09c2a2f71d95bb04eed5ead04dc8072aaa59d
Some run times return NULL pointers when creating 0 length
arrays. Avoid the inconsistency by skipping allocation when
the length of the SeekHead entry or void element array
is 0.
BUG=webm:1313
Change-Id: I28b4eac1d3e0ba968147637883f6e37c089e8573
The code will estimate the file duration if the last block duration is
0. This is not totally correct, but better then what we currently have.
BUG=https://bugs.chromium.org/p/webm/issues/detail?id=1100
Change-Id: I8f81df0bd592e6f7b1925fa2637a2e09cf182742
Using a webm/ prefix requires clients to add the webm_parser/include
path to their header search paths. This is inconvenient and an
unnecessary restriction.
Change-Id: If73a4433ad42f326a544766beca5f05710f52243
Ignore Colour::kValueNotPresent and allow writing of partial
Colour elements, and add a test confirming this works.
Change-Id: I77e6bd0d92cadc46142af92de2f9f474006dceb7
Instead of blindly doing a file compare and hoping that we're not
in a garbage in garbage out situation.
Change-Id: Ie2f278e09ad67b3e8f40e602fcdd5c9ffb5e1b7d
- Store actual element ID in SeekHead::Entry id field (instead
of a decoded EBML int, which is completely _wrong_).
- Add a SeekHead::Entry constructor so we get initialized values
in SeekHead::Entry's when parsing an Entry fails.
Change-Id: I152fae54628cb84918917139dba0cd0b42a44a57
