generic-library/vpx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
549 Commits 55 Branches 16 Tags 63 MiB
C 80%
C++ 9%
Assembly 6.7%
Makefile 1.5%
Shell 1.3%
Other 1.5%
1942eeb886
Go to file
John Koleszar 1942eeb886 fix last frame buffer copy logic regression 
Commit 0ce3901 introduced a change in the frame buffer copy logic where
the NEW frame could be copied to the ARF or GF buffer through the
copy_buffer_to_{arf,gf}==1 flags, if the LAST frame was not being
refreshed. This is not correct. The intent of the
copy_buffer_to_{arf,gf}==1 flag is to copy the LAST buffer. To copy the
NEW buffer, the refresh_{alt_ref,golden}_frame flag should be used.

The original buffer copy logic is fairly convoluted. For example:

    if (cm->refresh_last_frame)
    {
        vp8_swap_yv12_buffer(&cm->last_frame, &cm->new_frame);

        cm->frame_to_show = &cm->last_frame;
    }
    else
    {
        cm->frame_to_show = &cm->new_frame;
    }
    ...
    if (cm->copy_buffer_to_arf)
    {
        if (cm->copy_buffer_to_arf == 1)
        {
            if (cm->refresh_last_frame)
                vp8_yv12_copy_frame_ptr(&cm->new_frame, &cm->alt_ref_frame);
            else
                vp8_yv12_copy_frame_ptr(&cm->last_frame, &cm->alt_ref_frame);
        }
        else if (cm->copy_buffer_to_arf == 2)
            vp8_yv12_copy_frame_ptr(&cm->golden_frame, &cm->alt_ref_frame);
    }

Effectively, if refresh_last_frame, then new and last are swapped, so
when "new" is copied to ARF, it's equivalent to copying LAST to ARF. If
not refresh_last_frame, then LAST is copied to ARF. So LAST is copied to
ARF in both cases.

Commit 0ce3901 removed the first buffer swap but kept the
refresh_last_frame?new:last behavior, changing the sense since the first
swap wasn't done to the more readable refresh_last_frame?last:new, but
this logic is not correct when !refresh_last_frame.

This commit restores the correct behavior from v0.9.1 and prior. This
case is missing from the test vector set.

Change-Id: I8369fc13a37ae882e31a8a104da808a08bc8428f
2011-01-06 13:07:42 -05:00
build make yasm generate cv8 debug data on win32 2010-12-22 12:53:45 -05:00
examples vp8_set_maps: remove hard-coded width/height 2010-11-17 09:24:05 -05:00
libmkv Eliminate more warnings. 2010-10-28 08:26:03 -04:00
nestegg ivfdec: webm reader support 2010-10-25 22:01:40 -04:00
tools Generate AUTHORS file with a script 2010-06-16 15:43:09 -04:00
vp8 fix last frame buffer copy logic regression 2011-01-06 13:07:42 -05:00
vpx Merge "Add psnr/ssim tuning option" 2010-12-20 09:32:13 -08:00
vpx_mem Eliminate more warnings. 2010-10-28 08:26:03 -04:00
vpx_ports Full search SAD function optimization in SSE4.1 2010-10-27 13:36:31 -04:00
vpx_scale Eliminate more warnings. 2010-10-28 08:26:03 -04:00
.gitattributes Initial WebM release 2010-05-18 11:58:33 -04:00
.gitignore update gitignore 2010-09-28 10:09:01 -04:00
.mailmap Update AUTHORS 2010-09-02 13:41:03 -04:00
args.c Add psnr/ssim tuning option 2010-12-17 10:01:05 -05:00
args.h Add psnr/ssim tuning option 2010-12-17 10:01:05 -05:00
AUTHORS Update AUTHORS 2010-10-26 16:10:22 -04:00
CHANGELOG CHANGELOG: correct date 2010-10-28 09:14:14 -04:00
configure Add x86_64-darwin10-gcc target. 2010-11-16 14:52:05 -05:00
docs.mk Use WebM in copyright notice for consistency 2010-09-09 10:01:21 -04:00
example_xma.c Use WebM in copyright notice for consistency 2010-09-09 10:01:21 -04:00
examples.mk fix pipe support on windows 2010-11-02 09:14:24 -04:00
keywords.dox Initial WebM release 2010-05-18 11:58:33 -04:00
libs.doxy_template Use WebM in copyright notice for consistency 2010-09-09 10:01:21 -04:00
libs.mk Add runtime CPU detection support for ARM. 2010-10-25 09:23:29 -04:00
LICENSE LICENSE: update with latest text 2010-06-04 16:19:40 -04:00
mainpage.dox cosmetics: trim trailing whitespace 2010-06-18 13:06:11 -04:00
md5_utils.c Use public domain implementation for MD5 algorithm 2010-06-14 08:48:22 -04:00
md5_utils.h Use public domain implementation for MD5 algorithm 2010-06-14 08:48:22 -04:00
PATENTS LICENSE: update with latest text 2010-06-04 16:19:40 -04:00
README configure is not in src 2010-10-07 14:13:36 -04:00
solution.mk rename ivf{enc,dec} to vpx{enc,dec} 2010-10-25 22:12:44 -04:00
tools_common.c fix pipe support on windows 2010-11-02 09:14:24 -04:00
tools_common.h fix pipe support on windows 2010-11-02 09:14:24 -04:00
usage_cx.dox Initial WebM release 2010-05-18 11:58:33 -04:00
usage_dx.dox Initial WebM release 2010-05-18 11:58:33 -04:00
usage.dox Initial WebM release 2010-05-18 11:58:33 -04:00
vp8_api1_migration.txt Initial WebM release 2010-05-18 11:58:33 -04:00
vpxdec.c vpxdec: fix use of uninitialized memory for raw files 2010-11-23 13:49:40 -05:00
vpxenc.c vpxenc stats_close() memleak fix 2010-12-23 14:47:56 -05:00
wince_wmain_adapter.cpp Use WebM in copyright notice for consistency 2010-09-09 10:01:21 -04:00
y4minput.c Eliminate more warnings. 2010-10-28 08:26:03 -04:00
y4minput.h Use WebM in copyright notice for consistency 2010-09-09 10:01:21 -04:00

README 

vpx Multi-Format Codec SDK
README - 19 May 2010

Welcome to the WebM VP8 Codec SDK!

COMPILING THE APPLICATIONS/LIBRARIES:
  The build system used is similar to autotools. Building generally consists of
  "configuring" with your desired build options, then using GNU make to build
  the application.

  1. Prerequisites

    * All x86 targets require the Yasm[1] assembler be installed.
    * All Windows builds require that Cygwin[2] be installed.
    * Building the documentation requires PHP[3] and Doxygen[4]. If you do not
      have these packages, you must pass --disable-install-docs to the
      configure script.

    [1]: http://www.tortall.net/projects/yasm
    [2]: http://www.cygwin.com
    [3]: http://php.net
    [4]: http://www.doxygen.org

  2. Out-of-tree builds
  Out of tree builds are a supported method of building the application. For
  an out of tree build, the source tree is kept separate from the object
  files produced during compilation. For instance:

    $ mkdir build
    $ cd build
    $ ../libvpx/configure <options>
    $ make

  3. Configuration options
  The 'configure' script supports a number of options. The --help option can be
  used to get a list of supported options:
    $ ../libvpx/configure --help

  4. Cross development
  For cross development, the most notable option is the --target option. The
  most up-to-date list of supported targets can be found at the bottom of the
  --help output of the configure script. As of this writing, the list of
  available targets is:

    armv5te-linux-rvct
    armv5te-linux-gcc
    armv5te-symbian-gcc
    armv5te-wince-vs8
    armv6-darwin-gcc
    armv6-linux-rvct
    armv6-linux-gcc
    armv6-symbian-gcc
    armv6-wince-vs8
    iwmmxt-linux-rvct
    iwmmxt-linux-gcc
    iwmmxt-wince-vs8
    iwmmxt2-linux-rvct
    iwmmxt2-linux-gcc
    iwmmxt2-wince-vs8
    armv7-linux-rvct
    armv7-linux-gcc
    mips32-linux-gcc
    ppc32-darwin8-gcc
    ppc32-darwin9-gcc
    ppc64-darwin8-gcc
    ppc64-darwin9-gcc
    ppc64-linux-gcc
    x86-darwin8-gcc
    x86-darwin8-icc
    x86-darwin9-gcc
    x86-darwin9-icc
    x86-linux-gcc
    x86-linux-icc
    x86-solaris-gcc
    x86-win32-vs7
    x86-win32-vs8
    x86_64-darwin9-gcc
    x86_64-linux-gcc
    x86_64-solaris-gcc
    x86_64-win64-vs8
    universal-darwin8-gcc
    universal-darwin9-gcc
    generic-gnu

  The generic-gnu target, in conjunction with the CROSS environment variable,
  can be used to cross compile architectures that aren't explicitly listed, if
  the toolchain is a cross GNU (gcc/binutils) toolchain. Other POSIX toolchains
  will likely work as well. For instance, to build using the mipsel-linux-uclibc
  toolchain, the following command could be used (note, POSIX SH syntax, adapt
  to your shell as necessary):

    $ CROSS=mipsel-linux-uclibc- ../libvpx/configure

  In addition, the executables to be invoked can be overridden by specifying the
  environment variables: CC, AR, LD, AS, STRIP, NM. Additional flags can be
  passed to these executables with CFLAGS, LDFLAGS, and ASFLAGS.

  5. Configuration errors
  If the configuration step fails, the first step is to look in the error log.
  This defaults to config.err. This should give a good indication of what went
  wrong. If not, contact us for support.

SUPPORT
  This library is an open source project supported by its community. Please
  please email webm-users@webmproject.org for help.