2010-05-18 17:58:33 +02:00
|
|
|
/*
|
2010-09-09 14:16:39 +02:00
|
|
|
* Copyright (c) 2010 The WebM project authors. All Rights Reserved.
|
2010-05-18 17:58:33 +02:00
|
|
|
*
|
2010-06-18 18:39:21 +02:00
|
|
|
* Use of this source code is governed by a BSD-style license
|
2010-06-04 22:19:40 +02:00
|
|
|
* that can be found in the LICENSE file in the root of the source
|
|
|
|
* tree. An additional intellectual property rights grant can be found
|
2010-06-18 18:39:21 +02:00
|
|
|
* in the file PATENTS. All contributing project authors may
|
2010-06-04 22:19:40 +02:00
|
|
|
* be found in the AUTHORS file in the root of the source tree.
|
2010-05-18 17:58:33 +02:00
|
|
|
*/
|
|
|
|
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
#include <assert.h>
|
2010-05-18 17:58:33 +02:00
|
|
|
|
2012-12-23 16:20:10 +01:00
|
|
|
#include "./vpx_config.h"
|
2011-07-25 16:11:24 +02:00
|
|
|
#include "vpx/vpx_integer.h"
|
2012-11-28 19:41:40 +01:00
|
|
|
#include "vp9/common/vp9_blockd.h"
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
#include "vp9/common/vp9_filter.h"
|
2012-11-28 19:41:40 +01:00
|
|
|
#include "vp9/common/vp9_reconinter.h"
|
2012-11-27 22:59:17 +01:00
|
|
|
#include "vp9/common/vp9_reconintra.h"
|
2010-05-18 17:58:33 +02:00
|
|
|
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
void vp9_setup_scale_factors_for_frame(struct scale_factors *scale,
|
|
|
|
YV12_BUFFER_CONFIG *other,
|
|
|
|
int this_w, int this_h) {
|
2013-03-14 01:09:05 +01:00
|
|
|
int other_h = other->y_crop_height;
|
|
|
|
int other_w = other->y_crop_width;
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
|
|
|
|
scale->x_num = other_w;
|
|
|
|
scale->x_den = this_w;
|
|
|
|
scale->x_offset_q4 = 0; // calculated per-mb
|
|
|
|
scale->x_step_q4 = 16 * other_w / this_w;
|
2013-03-02 02:50:55 +01:00
|
|
|
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
scale->y_num = other_h;
|
|
|
|
scale->y_den = this_h;
|
|
|
|
scale->y_offset_q4 = 0; // calculated per-mb
|
|
|
|
scale->y_step_q4 = 16 * other_h / this_h;
|
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
if (scale->x_num == scale->x_den && scale->y_num == scale->y_den) {
|
|
|
|
scale->scale_value_x = unscaled_value;
|
|
|
|
scale->scale_value_y = unscaled_value;
|
|
|
|
scale->set_scaled_offsets = set_offsets_without_scaling;
|
|
|
|
scale->scale_motion_vector_q3_to_q4 =
|
|
|
|
motion_vector_q3_to_q4_without_scaling;
|
|
|
|
scale->scale_motion_vector_component_q4 =
|
|
|
|
motion_vector_component_q4_without_scaling;
|
|
|
|
} else {
|
|
|
|
scale->scale_value_x = scale_value_x_with_scaling;
|
|
|
|
scale->scale_value_y = scale_value_y_with_scaling;
|
|
|
|
scale->set_scaled_offsets = set_offsets_with_scaling;
|
|
|
|
scale->scale_motion_vector_q3_to_q4 =
|
|
|
|
motion_vector_q3_to_q4_with_scaling;
|
|
|
|
scale->scale_motion_vector_component_q4 =
|
|
|
|
motion_vector_component_q4_with_scaling;
|
|
|
|
}
|
|
|
|
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
// TODO(agrange): Investigate the best choice of functions to use here
|
|
|
|
// for EIGHTTAP_SMOOTH. Since it is not interpolating, need to choose what
|
|
|
|
// to do at full-pel offsets. The current selection, where the filter is
|
|
|
|
// applied in one direction only, and not at all for 0,0, seems to give the
|
|
|
|
// best quality, but it may be worth trying an additional mode that does
|
|
|
|
// do the filtering on full-pel.
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
#if CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT
|
|
|
|
if (scale->x_step_q4 == 16) {
|
|
|
|
if (scale->y_step_q4 == 16) {
|
|
|
|
// No scaling in either direction.
|
|
|
|
scale->predict[0][0][0] = vp9_convolve_copy;
|
|
|
|
scale->predict[0][0][1] = vp9_convolve_1by8;
|
|
|
|
scale->predict[0][0][2] = vp9_convolve_qtr;
|
|
|
|
scale->predict[0][0][3] = vp9_convolve_3by8;
|
|
|
|
scale->predict[0][0][4] = vp9_convolve_avg;
|
|
|
|
scale->predict[0][0][5] = vp9_convolve_5by8;
|
|
|
|
scale->predict[0][0][6] = vp9_convolve_3qtr;
|
|
|
|
scale->predict[0][0][7] = vp9_convolve_7by8;
|
|
|
|
scale->predict[0][1][0] = vp9_convolve8_vert;
|
|
|
|
scale->predict[0][1][1] = vp9_convolve8_1by8_vert;
|
|
|
|
scale->predict[0][1][2] = vp9_convolve8_qtr_vert;
|
|
|
|
scale->predict[0][1][3] = vp9_convolve8_3by8_vert;
|
|
|
|
scale->predict[0][1][4] = vp9_convolve8_avg_vert;
|
|
|
|
scale->predict[0][1][5] = vp9_convolve8_5by8_vert;
|
|
|
|
scale->predict[0][1][6] = vp9_convolve8_3qtr_vert;
|
|
|
|
scale->predict[0][1][7] = vp9_convolve8_7by8_vert;
|
|
|
|
scale->predict[1][0][0] = vp9_convolve8_horiz;
|
|
|
|
scale->predict[1][0][1] = vp9_convolve8_1by8_horiz;
|
|
|
|
scale->predict[1][0][2] = vp9_convolve8_qtr_horiz;
|
|
|
|
scale->predict[1][0][3] = vp9_convolve8_3by8_horiz;
|
|
|
|
scale->predict[1][0][4] = vp9_convolve8_avg_horiz;
|
|
|
|
scale->predict[1][0][5] = vp9_convolve8_5by8_horiz;
|
|
|
|
scale->predict[1][0][6] = vp9_convolve8_3qtr_horiz;
|
|
|
|
scale->predict[1][0][7] = vp9_convolve8_7by8_horiz;
|
|
|
|
} else {
|
|
|
|
// No scaling in x direction. Must always scale in the y direction.
|
|
|
|
scale->predict[0][0][0] = vp9_convolve8_vert;
|
|
|
|
scale->predict[0][0][1] = vp9_convolve8_1by8_vert;
|
|
|
|
scale->predict[0][0][2] = vp9_convolve8_qtr_vert;
|
|
|
|
scale->predict[0][0][3] = vp9_convolve8_3by8_vert;
|
|
|
|
scale->predict[0][0][4] = vp9_convolve8_avg_vert;
|
|
|
|
scale->predict[0][0][5] = vp9_convolve8_5by8_vert;
|
|
|
|
scale->predict[0][0][6] = vp9_convolve8_3qtr_vert;
|
|
|
|
scale->predict[0][0][7] = vp9_convolve8_7by8_vert;
|
|
|
|
scale->predict[0][1][0] = vp9_convolve8_vert;
|
|
|
|
scale->predict[0][1][1] = vp9_convolve8_1by8_vert;
|
|
|
|
scale->predict[0][1][2] = vp9_convolve8_qtr_vert;
|
|
|
|
scale->predict[0][1][3] = vp9_convolve8_3by8_vert;
|
|
|
|
scale->predict[0][1][4] = vp9_convolve8_avg_vert;
|
|
|
|
scale->predict[0][1][5] = vp9_convolve8_5by8_vert;
|
|
|
|
scale->predict[0][1][6] = vp9_convolve8_3qtr_vert;
|
|
|
|
scale->predict[0][1][7] = vp9_convolve8_7by8_vert;
|
|
|
|
scale->predict[1][0][0] = vp9_convolve8;
|
|
|
|
scale->predict[1][0][1] = vp9_convolve8_1by8;
|
|
|
|
scale->predict[1][0][2] = vp9_convolve8_qtr;
|
|
|
|
scale->predict[1][0][3] = vp9_convolve8_3by8;
|
|
|
|
scale->predict[1][0][4] = vp9_convolve8_avg;
|
|
|
|
scale->predict[1][0][5] = vp9_convolve8_5by8;
|
|
|
|
scale->predict[1][0][6] = vp9_convolve8_3qtr;
|
|
|
|
scale->predict[1][0][7] = vp9_convolve8_7by8;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if (scale->y_step_q4 == 16) {
|
|
|
|
// No scaling in the y direction. Must always scale in the x direction.
|
|
|
|
scale->predict[0][0][0] = vp9_convolve8_horiz;
|
|
|
|
scale->predict[0][0][1] = vp9_convolve8_1by8_horiz;
|
|
|
|
scale->predict[0][0][2] = vp9_convolve8_qtr_horiz;
|
|
|
|
scale->predict[0][0][3] = vp9_convolve8_3by8_horiz;
|
|
|
|
scale->predict[0][0][4] = vp9_convolve8_avg_horiz;
|
|
|
|
scale->predict[0][0][5] = vp9_convolve8_5by8_horiz;
|
|
|
|
scale->predict[0][0][6] = vp9_convolve8_3qtr_horiz;
|
|
|
|
scale->predict[0][0][7] = vp9_convolve8_7by8_horiz;
|
|
|
|
scale->predict[0][1][0] = vp9_convolve8;
|
|
|
|
scale->predict[0][1][1] = vp9_convolve8_1by8;
|
|
|
|
scale->predict[0][1][2] = vp9_convolve8_qtr;
|
|
|
|
scale->predict[0][1][3] = vp9_convolve8_3by8;
|
|
|
|
scale->predict[0][1][4] = vp9_convolve8_avg;
|
|
|
|
scale->predict[0][1][5] = vp9_convolve8_5by8;
|
|
|
|
scale->predict[0][1][6] = vp9_convolve8_3qtr;
|
|
|
|
scale->predict[0][1][7] = vp9_convolve8_7by8;
|
|
|
|
scale->predict[1][0][0] = vp9_convolve8_horiz;
|
|
|
|
scale->predict[1][0][1] = vp9_convolve8_1by8_horiz;
|
|
|
|
scale->predict[1][0][2] = vp9_convolve8_qtr_horiz;
|
|
|
|
scale->predict[1][0][3] = vp9_convolve8_3by8_horiz;
|
|
|
|
scale->predict[1][0][4] = vp9_convolve8_avg_horiz;
|
|
|
|
scale->predict[1][0][5] = vp9_convolve8_5by8_horiz;
|
|
|
|
scale->predict[1][0][6] = vp9_convolve8_3qtr_horiz;
|
|
|
|
scale->predict[1][0][7] = vp9_convolve8_7by8_horiz;
|
|
|
|
} else {
|
|
|
|
// Must always scale in both directions.
|
|
|
|
scale->predict[0][0][0] = vp9_convolve8;
|
|
|
|
scale->predict[0][0][1] = vp9_convolve8_1by8;
|
|
|
|
scale->predict[0][0][2] = vp9_convolve8_qtr;
|
|
|
|
scale->predict[0][0][3] = vp9_convolve8_3by8;
|
|
|
|
scale->predict[0][0][4] = vp9_convolve8_avg;
|
|
|
|
scale->predict[0][0][5] = vp9_convolve8_5by8;
|
|
|
|
scale->predict[0][0][6] = vp9_convolve8_3qtr;
|
|
|
|
scale->predict[0][0][7] = vp9_convolve8_7by8;
|
|
|
|
scale->predict[0][1][0] = vp9_convolve8;
|
|
|
|
scale->predict[0][1][1] = vp9_convolve8_1by8;
|
|
|
|
scale->predict[0][1][2] = vp9_convolve8_qtr;
|
|
|
|
scale->predict[0][1][3] = vp9_convolve8_3by8;
|
|
|
|
scale->predict[0][1][4] = vp9_convolve8_avg;
|
|
|
|
scale->predict[0][1][5] = vp9_convolve8_5by8;
|
|
|
|
scale->predict[0][1][6] = vp9_convolve8_3qtr;
|
|
|
|
scale->predict[0][1][7] = vp9_convolve8_7by8;
|
|
|
|
scale->predict[1][0][0] = vp9_convolve8;
|
|
|
|
scale->predict[1][0][1] = vp9_convolve8_1by8;
|
|
|
|
scale->predict[1][0][2] = vp9_convolve8_qtr;
|
|
|
|
scale->predict[1][0][3] = vp9_convolve8_3by8;
|
|
|
|
scale->predict[1][0][4] = vp9_convolve8_avg;
|
|
|
|
scale->predict[1][0][5] = vp9_convolve8_5by8;
|
|
|
|
scale->predict[1][0][6] = vp9_convolve8_3qtr;
|
|
|
|
scale->predict[1][0][7] = vp9_convolve8_7by8;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// 2D subpel motion always gets filtered in both directions
|
|
|
|
scale->predict[1][1][0] = vp9_convolve8;
|
|
|
|
scale->predict[1][1][1] = vp9_convolve8_1by8;
|
|
|
|
scale->predict[1][1][2] = vp9_convolve8_qtr;
|
|
|
|
scale->predict[1][1][3] = vp9_convolve8_3by8;
|
|
|
|
scale->predict[1][1][4] = vp9_convolve8_avg;
|
|
|
|
scale->predict[1][1][5] = vp9_convolve8_5by8;
|
|
|
|
scale->predict[1][1][6] = vp9_convolve8_3qtr;
|
|
|
|
scale->predict[1][1][7] = vp9_convolve8_7by8;
|
|
|
|
}
|
|
|
|
#else
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
if (scale->x_step_q4 == 16) {
|
|
|
|
if (scale->y_step_q4 == 16) {
|
|
|
|
// No scaling in either direction.
|
|
|
|
scale->predict[0][0][0] = vp9_convolve_copy;
|
|
|
|
scale->predict[0][0][1] = vp9_convolve_avg;
|
|
|
|
scale->predict[0][1][0] = vp9_convolve8_vert;
|
|
|
|
scale->predict[0][1][1] = vp9_convolve8_avg_vert;
|
|
|
|
scale->predict[1][0][0] = vp9_convolve8_horiz;
|
|
|
|
scale->predict[1][0][1] = vp9_convolve8_avg_horiz;
|
|
|
|
} else {
|
|
|
|
// No scaling in x direction. Must always scale in the y direction.
|
|
|
|
scale->predict[0][0][0] = vp9_convolve8_vert;
|
|
|
|
scale->predict[0][0][1] = vp9_convolve8_avg_vert;
|
|
|
|
scale->predict[0][1][0] = vp9_convolve8_vert;
|
|
|
|
scale->predict[0][1][1] = vp9_convolve8_avg_vert;
|
|
|
|
scale->predict[1][0][0] = vp9_convolve8;
|
|
|
|
scale->predict[1][0][1] = vp9_convolve8_avg;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if (scale->y_step_q4 == 16) {
|
|
|
|
// No scaling in the y direction. Must always scale in the x direction.
|
|
|
|
scale->predict[0][0][0] = vp9_convolve8_horiz;
|
|
|
|
scale->predict[0][0][1] = vp9_convolve8_avg_horiz;
|
|
|
|
scale->predict[0][1][0] = vp9_convolve8;
|
|
|
|
scale->predict[0][1][1] = vp9_convolve8_avg;
|
|
|
|
scale->predict[1][0][0] = vp9_convolve8_horiz;
|
|
|
|
scale->predict[1][0][1] = vp9_convolve8_avg_horiz;
|
|
|
|
} else {
|
|
|
|
// Must always scale in both directions.
|
|
|
|
scale->predict[0][0][0] = vp9_convolve8;
|
|
|
|
scale->predict[0][0][1] = vp9_convolve8_avg;
|
|
|
|
scale->predict[0][1][0] = vp9_convolve8;
|
|
|
|
scale->predict[0][1][1] = vp9_convolve8_avg;
|
|
|
|
scale->predict[1][0][0] = vp9_convolve8;
|
|
|
|
scale->predict[1][0][1] = vp9_convolve8_avg;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// 2D subpel motion always gets filtered in both directions
|
|
|
|
scale->predict[1][1][0] = vp9_convolve8;
|
|
|
|
scale->predict[1][1][1] = vp9_convolve8_avg;
|
|
|
|
}
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
#endif
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
|
|
|
|
void vp9_setup_interp_filters(MACROBLOCKD *xd,
|
|
|
|
INTERPOLATIONFILTERTYPE mcomp_filter_type,
|
|
|
|
VP9_COMMON *cm) {
|
|
|
|
if (xd->mode_info_context) {
|
|
|
|
MB_MODE_INFO *mbmi = &xd->mode_info_context->mbmi;
|
|
|
|
|
|
|
|
set_scale_factors(xd,
|
|
|
|
mbmi->ref_frame - 1,
|
|
|
|
mbmi->second_ref_frame - 1,
|
|
|
|
cm->active_ref_scale);
|
|
|
|
}
|
|
|
|
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
switch (mcomp_filter_type) {
|
|
|
|
case EIGHTTAP:
|
|
|
|
case SWITCHABLE:
|
|
|
|
xd->subpix.filter_x = xd->subpix.filter_y = vp9_sub_pel_filters_8;
|
|
|
|
break;
|
|
|
|
case EIGHTTAP_SMOOTH:
|
|
|
|
xd->subpix.filter_x = xd->subpix.filter_y = vp9_sub_pel_filters_8lp;
|
|
|
|
break;
|
|
|
|
case EIGHTTAP_SHARP:
|
|
|
|
xd->subpix.filter_x = xd->subpix.filter_y = vp9_sub_pel_filters_8s;
|
|
|
|
break;
|
|
|
|
case BILINEAR:
|
|
|
|
xd->subpix.filter_x = xd->subpix.filter_y = vp9_bilinear_filters;
|
|
|
|
break;
|
2013-01-08 23:14:01 +01:00
|
|
|
#if CONFIG_ENABLE_6TAP
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
case SIXTAP:
|
|
|
|
xd->subpix.filter_x = xd->subpix.filter_y = vp9_sub_pel_filters_6;
|
|
|
|
break;
|
2013-01-08 23:14:01 +01:00
|
|
|
#endif
|
|
|
|
}
|
2013-02-21 00:59:20 +01:00
|
|
|
assert(((intptr_t)xd->subpix.filter_x & 0xff) == 0);
|
2012-07-18 22:43:01 +02:00
|
|
|
}
|
|
|
|
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
void vp9_copy_mem16x16_c(const uint8_t *src,
|
2012-11-01 00:09:17 +01:00
|
|
|
int src_stride,
|
2012-12-19 00:31:19 +01:00
|
|
|
uint8_t *dst,
|
2012-11-01 00:09:17 +01:00
|
|
|
int dst_stride) {
|
2012-07-14 00:21:29 +02:00
|
|
|
int r;
|
2010-05-18 17:58:33 +02:00
|
|
|
|
2012-07-14 00:21:29 +02:00
|
|
|
for (r = 0; r < 16; r++) {
|
2011-07-25 16:11:24 +02:00
|
|
|
#if !(CONFIG_FAST_UNALIGNED)
|
2012-07-14 00:21:29 +02:00
|
|
|
dst[0] = src[0];
|
|
|
|
dst[1] = src[1];
|
|
|
|
dst[2] = src[2];
|
|
|
|
dst[3] = src[3];
|
|
|
|
dst[4] = src[4];
|
|
|
|
dst[5] = src[5];
|
|
|
|
dst[6] = src[6];
|
|
|
|
dst[7] = src[7];
|
|
|
|
dst[8] = src[8];
|
|
|
|
dst[9] = src[9];
|
|
|
|
dst[10] = src[10];
|
|
|
|
dst[11] = src[11];
|
|
|
|
dst[12] = src[12];
|
|
|
|
dst[13] = src[13];
|
|
|
|
dst[14] = src[14];
|
|
|
|
dst[15] = src[15];
|
2010-05-18 17:58:33 +02:00
|
|
|
|
|
|
|
#else
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
((uint32_t *)dst)[0] = ((const uint32_t *)src)[0];
|
|
|
|
((uint32_t *)dst)[1] = ((const uint32_t *)src)[1];
|
|
|
|
((uint32_t *)dst)[2] = ((const uint32_t *)src)[2];
|
|
|
|
((uint32_t *)dst)[3] = ((const uint32_t *)src)[3];
|
2010-05-18 17:58:33 +02:00
|
|
|
|
|
|
|
#endif
|
2012-07-14 00:21:29 +02:00
|
|
|
src += src_stride;
|
|
|
|
dst += dst_stride;
|
|
|
|
}
|
2010-05-18 17:58:33 +02:00
|
|
|
}
|
|
|
|
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
void vp9_copy_mem8x8_c(const uint8_t *src,
|
2012-11-01 00:09:17 +01:00
|
|
|
int src_stride,
|
2012-12-19 00:31:19 +01:00
|
|
|
uint8_t *dst,
|
2012-11-01 00:09:17 +01:00
|
|
|
int dst_stride) {
|
2012-07-14 00:21:29 +02:00
|
|
|
int r;
|
|
|
|
|
|
|
|
for (r = 0; r < 8; r++) {
|
2011-07-25 16:11:24 +02:00
|
|
|
#if !(CONFIG_FAST_UNALIGNED)
|
2012-07-14 00:21:29 +02:00
|
|
|
dst[0] = src[0];
|
|
|
|
dst[1] = src[1];
|
|
|
|
dst[2] = src[2];
|
|
|
|
dst[3] = src[3];
|
|
|
|
dst[4] = src[4];
|
|
|
|
dst[5] = src[5];
|
|
|
|
dst[6] = src[6];
|
|
|
|
dst[7] = src[7];
|
2010-05-18 17:58:33 +02:00
|
|
|
#else
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
((uint32_t *)dst)[0] = ((const uint32_t *)src)[0];
|
|
|
|
((uint32_t *)dst)[1] = ((const uint32_t *)src)[1];
|
2010-05-18 17:58:33 +02:00
|
|
|
#endif
|
2012-07-14 00:21:29 +02:00
|
|
|
src += src_stride;
|
|
|
|
dst += dst_stride;
|
|
|
|
}
|
2010-05-18 17:58:33 +02:00
|
|
|
}
|
|
|
|
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
void vp9_copy_mem8x4_c(const uint8_t *src,
|
2012-11-01 00:09:17 +01:00
|
|
|
int src_stride,
|
2012-12-19 00:31:19 +01:00
|
|
|
uint8_t *dst,
|
2012-11-01 00:09:17 +01:00
|
|
|
int dst_stride) {
|
2012-07-14 00:21:29 +02:00
|
|
|
int r;
|
|
|
|
|
|
|
|
for (r = 0; r < 4; r++) {
|
2011-07-25 16:11:24 +02:00
|
|
|
#if !(CONFIG_FAST_UNALIGNED)
|
2012-07-14 00:21:29 +02:00
|
|
|
dst[0] = src[0];
|
|
|
|
dst[1] = src[1];
|
|
|
|
dst[2] = src[2];
|
|
|
|
dst[3] = src[3];
|
|
|
|
dst[4] = src[4];
|
|
|
|
dst[5] = src[5];
|
|
|
|
dst[6] = src[6];
|
|
|
|
dst[7] = src[7];
|
2010-05-18 17:58:33 +02:00
|
|
|
#else
|
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
2013-01-29 01:59:03 +01:00
|
|
|
((uint32_t *)dst)[0] = ((const uint32_t *)src)[0];
|
|
|
|
((uint32_t *)dst)[1] = ((const uint32_t *)src)[1];
|
2010-05-18 17:58:33 +02:00
|
|
|
#endif
|
2012-07-14 00:21:29 +02:00
|
|
|
src += src_stride;
|
|
|
|
dst += dst_stride;
|
|
|
|
}
|
2010-05-18 17:58:33 +02:00
|
|
|
}
|
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
void vp9_build_inter_predictor(const uint8_t *src, int src_stride,
|
|
|
|
uint8_t *dst, int dst_stride,
|
|
|
|
const int_mv *mv_q3,
|
|
|
|
const struct scale_factors *scale,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
int w, int h, int weight,
|
2013-02-09 02:49:44 +01:00
|
|
|
const struct subpix_fn_table *subpix) {
|
2013-04-04 18:56:02 +02:00
|
|
|
int_mv32 mv = scale->scale_motion_vector_q3_to_q4(mv_q3, scale);
|
2013-03-02 02:50:55 +01:00
|
|
|
src += (mv.as_mv.row >> 4) * src_stride + (mv.as_mv.col >> 4);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
scale->predict[!!(mv.as_mv.col & 15)][!!(mv.as_mv.row & 15)][weight](
|
2013-02-09 02:49:44 +01:00
|
|
|
src, src_stride, dst, dst_stride,
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
subpix->filter_x[mv.as_mv.col & 15], scale->x_step_q4,
|
|
|
|
subpix->filter_y[mv.as_mv.row & 15], scale->y_step_q4,
|
2013-02-09 02:49:44 +01:00
|
|
|
w, h);
|
2010-05-18 17:58:33 +02:00
|
|
|
}
|
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
/* Like vp9_build_inter_predictor, but takes the full-pel part of the
|
|
|
|
* mv separately, and the fractional part as a q4.
|
2012-04-18 22:51:58 +02:00
|
|
|
*/
|
2013-02-09 02:49:44 +01:00
|
|
|
void vp9_build_inter_predictor_q4(const uint8_t *src, int src_stride,
|
|
|
|
uint8_t *dst, int dst_stride,
|
|
|
|
const int_mv *fullpel_mv_q3,
|
|
|
|
const int_mv *frac_mv_q4,
|
|
|
|
const struct scale_factors *scale,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
int w, int h, int weight,
|
2013-02-09 02:49:44 +01:00
|
|
|
const struct subpix_fn_table *subpix) {
|
|
|
|
const int mv_row_q4 = ((fullpel_mv_q3->as_mv.row >> 3) << 4)
|
|
|
|
+ (frac_mv_q4->as_mv.row & 0xf);
|
|
|
|
const int mv_col_q4 = ((fullpel_mv_q3->as_mv.col >> 3) << 4)
|
|
|
|
+ (frac_mv_q4->as_mv.col & 0xf);
|
|
|
|
const int scaled_mv_row_q4 =
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->scale_motion_vector_component_q4(mv_row_q4, scale->y_num,
|
|
|
|
scale->y_den, scale->y_offset_q4);
|
2013-02-09 02:49:44 +01:00
|
|
|
const int scaled_mv_col_q4 =
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->scale_motion_vector_component_q4(mv_col_q4, scale->x_num,
|
|
|
|
scale->x_den, scale->x_offset_q4);
|
2013-02-09 02:49:44 +01:00
|
|
|
const int subpel_x = scaled_mv_col_q4 & 15;
|
|
|
|
const int subpel_y = scaled_mv_row_q4 & 15;
|
|
|
|
|
2013-03-02 02:50:55 +01:00
|
|
|
src += (scaled_mv_row_q4 >> 4) * src_stride + (scaled_mv_col_q4 >> 4);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
scale->predict[!!subpel_x][!!subpel_y][weight](
|
2013-02-09 02:49:44 +01:00
|
|
|
src, src_stride, dst, dst_stride,
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
subpix->filter_x[subpel_x], scale->x_step_q4,
|
|
|
|
subpix->filter_y[subpel_y], scale->y_step_q4,
|
2013-02-09 02:49:44 +01:00
|
|
|
w, h);
|
2012-04-18 22:51:58 +02:00
|
|
|
}
|
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
static void build_2x1_inter_predictor_wh(const BLOCKD *d0, const BLOCKD *d1,
|
2013-04-04 18:56:02 +02:00
|
|
|
struct scale_factors *s,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
uint8_t *predictor,
|
|
|
|
int block_size, int stride,
|
|
|
|
int which_mv, int weight,
|
|
|
|
int width, int height,
|
|
|
|
const struct subpix_fn_table *subpix,
|
|
|
|
int row, int col) {
|
2013-04-04 18:56:02 +02:00
|
|
|
struct scale_factors * scale = &s[which_mv];
|
|
|
|
|
2013-04-15 18:31:27 +02:00
|
|
|
assert(d1->dst - d0->dst == block_size);
|
2013-02-09 02:49:44 +01:00
|
|
|
assert(d1->pre == d0->pre + block_size);
|
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, row, col);
|
2013-02-20 22:46:55 +01:00
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
if (d0->bmi.as_mv[which_mv].as_int == d1->bmi.as_mv[which_mv].as_int) {
|
|
|
|
uint8_t **base_pre = which_mv ? d0->base_second_pre : d0->base_pre;
|
|
|
|
|
|
|
|
vp9_build_inter_predictor(*base_pre + d0->pre,
|
|
|
|
d0->pre_stride,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
predictor, stride,
|
2013-02-09 02:49:44 +01:00
|
|
|
&d0->bmi.as_mv[which_mv],
|
2013-04-04 18:56:02 +02:00
|
|
|
scale,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
width, height,
|
|
|
|
weight, subpix);
|
2013-02-09 02:49:44 +01:00
|
|
|
|
|
|
|
} else {
|
|
|
|
uint8_t **base_pre0 = which_mv ? d0->base_second_pre : d0->base_pre;
|
|
|
|
uint8_t **base_pre1 = which_mv ? d1->base_second_pre : d1->base_pre;
|
|
|
|
|
|
|
|
vp9_build_inter_predictor(*base_pre0 + d0->pre,
|
|
|
|
d0->pre_stride,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
predictor, stride,
|
2013-02-09 02:49:44 +01:00
|
|
|
&d0->bmi.as_mv[which_mv],
|
2013-04-04 18:56:02 +02:00
|
|
|
scale,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
width > block_size ? block_size : width, height,
|
|
|
|
weight, subpix);
|
|
|
|
|
|
|
|
if (width <= block_size) return;
|
2013-02-20 22:46:55 +01:00
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, row, col + block_size);
|
2013-02-20 22:46:55 +01:00
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
vp9_build_inter_predictor(*base_pre1 + d1->pre,
|
|
|
|
d1->pre_stride,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
predictor + block_size, stride,
|
2013-02-09 02:49:44 +01:00
|
|
|
&d1->bmi.as_mv[which_mv],
|
2013-04-04 18:56:02 +02:00
|
|
|
scale,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
width - block_size, height,
|
|
|
|
weight, subpix);
|
2013-02-09 02:49:44 +01:00
|
|
|
}
|
2010-05-18 17:58:33 +02:00
|
|
|
}
|
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
static void build_2x1_inter_predictor(const BLOCKD *d0, const BLOCKD *d1,
|
2013-04-04 18:56:02 +02:00
|
|
|
struct scale_factors *s,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
int block_size, int stride,
|
|
|
|
int which_mv, int weight,
|
|
|
|
const struct subpix_fn_table *subpix,
|
2013-04-15 18:31:27 +02:00
|
|
|
int row, int col) {
|
|
|
|
uint8_t *d0_predictor = *(d0->base_dst) + d0->dst;
|
|
|
|
uint8_t *d1_predictor = *(d1->base_dst) + d1->dst;
|
2013-04-04 18:56:02 +02:00
|
|
|
struct scale_factors * scale = &s[which_mv];
|
2013-04-15 18:31:27 +02:00
|
|
|
stride = d0->dst_stride;
|
2013-04-04 18:56:02 +02:00
|
|
|
|
2013-04-11 01:46:52 +02:00
|
|
|
assert(d1_predictor - d0_predictor == block_size);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
assert(d1->pre == d0->pre + block_size);
|
2012-04-18 22:51:58 +02:00
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, row, col);
|
2012-07-14 00:21:29 +02:00
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
if (d0->bmi.as_mv[which_mv].as_int == d1->bmi.as_mv[which_mv].as_int) {
|
|
|
|
uint8_t **base_pre = which_mv ? d0->base_second_pre : d0->base_pre;
|
2012-07-14 00:21:29 +02:00
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
vp9_build_inter_predictor(*base_pre + d0->pre,
|
|
|
|
d0->pre_stride,
|
2013-04-11 01:46:52 +02:00
|
|
|
d0_predictor, stride,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
&d0->bmi.as_mv[which_mv],
|
2013-04-04 18:56:02 +02:00
|
|
|
scale,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
2 * block_size, block_size,
|
|
|
|
weight, subpix);
|
|
|
|
} else {
|
|
|
|
uint8_t **base_pre0 = which_mv ? d0->base_second_pre : d0->base_pre;
|
|
|
|
uint8_t **base_pre1 = which_mv ? d1->base_second_pre : d1->base_pre;
|
2012-07-14 00:21:29 +02:00
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
vp9_build_inter_predictor(*base_pre0 + d0->pre,
|
|
|
|
d0->pre_stride,
|
2013-04-11 01:46:52 +02:00
|
|
|
d0_predictor, stride,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
&d0->bmi.as_mv[which_mv],
|
2013-04-04 18:56:02 +02:00
|
|
|
scale,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
block_size, block_size,
|
|
|
|
weight, subpix);
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, row, col + block_size);
|
2012-07-14 00:21:29 +02:00
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
vp9_build_inter_predictor(*base_pre1 + d1->pre,
|
|
|
|
d1->pre_stride,
|
2013-04-11 01:46:52 +02:00
|
|
|
d1_predictor, stride,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
&d1->bmi.as_mv[which_mv],
|
2013-04-04 18:56:02 +02:00
|
|
|
scale,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
block_size, block_size,
|
|
|
|
weight, subpix);
|
2012-07-14 00:21:29 +02:00
|
|
|
}
|
2010-05-18 17:58:33 +02:00
|
|
|
}
|
|
|
|
|
2012-07-14 00:21:29 +02:00
|
|
|
static void clamp_mv_to_umv_border(MV *mv, const MACROBLOCKD *xd) {
|
|
|
|
/* If the MV points so far into the UMV border that no visible pixels
|
|
|
|
* are used for reconstruction, the subpel part of the MV can be
|
|
|
|
* discarded and the MV limited to 16 pixels with equivalent results.
|
|
|
|
*
|
|
|
|
* This limit kicks in at 19 pixels for the top and left edges, for
|
|
|
|
* the 16 pixels plus 3 taps right of the central pixel when subpel
|
|
|
|
* filtering. The bottom and right edges use 16 pixels plus 2 pixels
|
|
|
|
* left of the central pixel when filtering.
|
|
|
|
*/
|
2012-11-02 01:53:44 +01:00
|
|
|
if (mv->col < (xd->mb_to_left_edge - ((16 + VP9_INTERP_EXTEND) << 3)))
|
2012-07-14 00:21:29 +02:00
|
|
|
mv->col = xd->mb_to_left_edge - (16 << 3);
|
2012-11-02 01:53:44 +01:00
|
|
|
else if (mv->col > xd->mb_to_right_edge + ((15 + VP9_INTERP_EXTEND) << 3))
|
2012-07-14 00:21:29 +02:00
|
|
|
mv->col = xd->mb_to_right_edge + (16 << 3);
|
|
|
|
|
2012-11-02 01:53:44 +01:00
|
|
|
if (mv->row < (xd->mb_to_top_edge - ((16 + VP9_INTERP_EXTEND) << 3)))
|
2012-07-14 00:21:29 +02:00
|
|
|
mv->row = xd->mb_to_top_edge - (16 << 3);
|
2012-11-02 01:53:44 +01:00
|
|
|
else if (mv->row > xd->mb_to_bottom_edge + ((15 + VP9_INTERP_EXTEND) << 3))
|
2012-07-14 00:21:29 +02:00
|
|
|
mv->row = xd->mb_to_bottom_edge + (16 << 3);
|
2012-02-01 23:27:50 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/* A version of the above function for chroma block MVs.*/
|
2012-07-14 00:21:29 +02:00
|
|
|
static void clamp_uvmv_to_umv_border(MV *mv, const MACROBLOCKD *xd) {
|
2012-11-02 01:53:44 +01:00
|
|
|
const int extend = VP9_INTERP_EXTEND;
|
|
|
|
|
|
|
|
mv->col = (2 * mv->col < (xd->mb_to_left_edge - ((16 + extend) << 3))) ?
|
2012-07-14 00:21:29 +02:00
|
|
|
(xd->mb_to_left_edge - (16 << 3)) >> 1 : mv->col;
|
2012-11-02 01:53:44 +01:00
|
|
|
mv->col = (2 * mv->col > xd->mb_to_right_edge + ((15 + extend) << 3)) ?
|
2012-07-14 00:21:29 +02:00
|
|
|
(xd->mb_to_right_edge + (16 << 3)) >> 1 : mv->col;
|
|
|
|
|
2012-11-02 01:53:44 +01:00
|
|
|
mv->row = (2 * mv->row < (xd->mb_to_top_edge - ((16 + extend) << 3))) ?
|
2012-07-14 00:21:29 +02:00
|
|
|
(xd->mb_to_top_edge - (16 << 3)) >> 1 : mv->row;
|
2012-11-02 01:53:44 +01:00
|
|
|
mv->row = (2 * mv->row > xd->mb_to_bottom_edge + ((15 + extend) << 3)) ?
|
2012-07-14 00:21:29 +02:00
|
|
|
(xd->mb_to_bottom_edge + (16 << 3)) >> 1 : mv->row;
|
2012-02-01 23:27:50 +01:00
|
|
|
}
|
|
|
|
|
make buid_inter_predictors block size agnostic (luma)
This commit converts the luma versions of vp9_build_inter_predictors_sb
to use a common function. Update the convolution functions to support
block sizes larger than 16x16, and add a foreach_predicted_block walker.
Next step will be to calculate the UV motion vector and implement SBUV,
then fold in vp9_build_inter16x16_predictors_mb and SPLITMV.
At the 16x16, 32x32, and 64x64 levels implemented in this commit, each
plane is predicted with only a single call to vp9_build_inter_predictor.
This is not yet called for SPLITMV. If the notion of SPLITMV/I8X8/I4X4
goes away, then the prediction block walker can go away, since we'll
always predict the whole bsize in a single step. Implemented using a
block walker at this stage for SPLITMV, as a 4x4 "prediction block size"
within the BLOCK_SIZE_MB16X16 macroblock. It would also support other
rectangular sizes too, if the blocks smaller than 16x16 remain
implemented as a SPLITMV-like thing. Just using 4x4 for now.
There's also a potential to combine with the foreach_transformed_block
walker if the logic for calculating the size of the subsampled
transform is made more straightforward, perhaps as a consequence of
supporing smaller macroblocks than 16x16. Will watch what happens there.
Change-Id: Iddd9973398542216601b630c628b9b7fdee33fe2
2013-04-13 02:19:57 +02:00
|
|
|
#if !CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT
|
|
|
|
// TODO(jkoleszar): yet another mv clamping function :-(
|
|
|
|
MV clamp_mv_to_umv_border_sb(const MV *src_mv,
|
|
|
|
int bwl, int bhl,
|
|
|
|
int mb_to_left_edge, int mb_to_top_edge,
|
|
|
|
int mb_to_right_edge, int mb_to_bottom_edge) {
|
|
|
|
/* If the MV points so far into the UMV border that no visible pixels
|
|
|
|
* are used for reconstruction, the subpel part of the MV can be
|
|
|
|
* discarded and the MV limited to 16 pixels with equivalent results.
|
|
|
|
*/
|
|
|
|
const int epel_left = (VP9_INTERP_EXTEND + (4 << bwl)) << 3;
|
|
|
|
const int epel_right = epel_left - (1 << 3);
|
|
|
|
const int epel_top = (VP9_INTERP_EXTEND + (4 << bhl)) << 3;
|
|
|
|
const int epel_bottom = epel_top - (1 << 3);
|
|
|
|
MV clamped_mv;
|
|
|
|
clamped_mv.col = clamp(src_mv->col,
|
|
|
|
mb_to_left_edge - epel_left,
|
|
|
|
mb_to_right_edge + epel_right);
|
|
|
|
clamped_mv.row = clamp(src_mv->row,
|
|
|
|
mb_to_top_edge - epel_top,
|
|
|
|
mb_to_bottom_edge + epel_bottom);
|
|
|
|
return clamped_mv;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct build_inter_predictors_args {
|
|
|
|
MACROBLOCKD *xd;
|
|
|
|
uint8_t* dst[MAX_MB_PLANE];
|
|
|
|
int dst_stride[MAX_MB_PLANE];
|
|
|
|
int x;
|
|
|
|
int y;
|
|
|
|
};
|
|
|
|
static void build_inter_predictors(int plane, int block,
|
|
|
|
BLOCK_SIZE_TYPE bsize,
|
|
|
|
int pred_w, int pred_h,
|
|
|
|
void *argv) {
|
|
|
|
const struct build_inter_predictors_args* const arg = argv;
|
|
|
|
const int bwl = pred_w, bw = 4 << bwl;
|
|
|
|
const int bhl = pred_h, bh = 4 << bhl;
|
|
|
|
const int x_idx = block & ((1 << bwl) - 1), y_idx = block >> bwl;
|
|
|
|
const int x = x_idx * 4, y = y_idx * 4;
|
|
|
|
MACROBLOCKD * const xd = arg->xd;
|
|
|
|
const int use_second_ref = xd->mode_info_context->mbmi.second_ref_frame > 0;
|
|
|
|
int which_mv;
|
|
|
|
|
|
|
|
for (which_mv = 0; which_mv < 1 + use_second_ref; ++which_mv) {
|
|
|
|
const MV* const mv = (xd->mode_info_context->mbmi.mode == SPLITMV)
|
|
|
|
? &xd->block[block].bmi.as_mv[which_mv].as_mv
|
|
|
|
: &xd->mode_info_context->mbmi.mv[which_mv].as_mv;
|
|
|
|
|
|
|
|
const uint8_t * const base_pre = which_mv ? xd->second_pre.y_buffer
|
|
|
|
: xd->pre.y_buffer;
|
|
|
|
const int pre_stride = which_mv ? xd->second_pre.y_stride
|
|
|
|
: xd->pre.y_stride;
|
|
|
|
const uint8_t *const pre = base_pre +
|
|
|
|
scaled_buffer_offset(x, y, pre_stride, &xd->scale_factor[which_mv]);
|
|
|
|
struct scale_factors * const scale =
|
|
|
|
plane == 0 ? &xd->scale_factor[which_mv] : &xd->scale_factor_uv[which_mv];
|
|
|
|
|
|
|
|
int_mv clamped_mv;
|
|
|
|
clamped_mv.as_mv = clamp_mv_to_umv_border_sb(mv, bwl, bhl,
|
|
|
|
xd->mb_to_left_edge,
|
|
|
|
xd->mb_to_top_edge,
|
|
|
|
xd->mb_to_right_edge,
|
|
|
|
xd->mb_to_bottom_edge);
|
|
|
|
|
|
|
|
scale->set_scaled_offsets(scale, arg->y + y, arg->x + x);
|
|
|
|
|
|
|
|
vp9_build_inter_predictor(pre, pre_stride,
|
|
|
|
arg->dst[plane], arg->dst_stride[plane],
|
|
|
|
&clamped_mv, &xd->scale_factor[which_mv],
|
|
|
|
bw, bh, which_mv, &xd->subpix);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
void vp9_build_inter_predictors_sby(MACROBLOCKD *xd,
|
|
|
|
uint8_t *dst_y,
|
|
|
|
int dst_ystride,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col,
|
|
|
|
BLOCK_SIZE_TYPE bsize) {
|
|
|
|
struct build_inter_predictors_args args = {
|
|
|
|
xd, {dst_y, NULL, NULL}, {dst_ystride, 0, 0}, mb_col * 16, mb_row * 16
|
|
|
|
};
|
|
|
|
foreach_predicted_block_in_plane(xd, bsize, 0, build_inter_predictors, &args);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
#define AVERAGE_WEIGHT (1 << (2 * CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT))
|
|
|
|
|
|
|
|
#if CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT
|
|
|
|
|
|
|
|
// Whether to use implicit weighting for UV
|
|
|
|
#define USE_IMPLICIT_WEIGHT_UV
|
|
|
|
|
|
|
|
// Whether to use implicit weighting for SplitMV
|
|
|
|
// #define USE_IMPLICIT_WEIGHT_SPLITMV
|
|
|
|
|
|
|
|
// #define SEARCH_MIN3
|
|
|
|
static int64_t get_consistency_metric(MACROBLOCKD *xd,
|
|
|
|
uint8_t *tmp_y, int tmp_ystride) {
|
|
|
|
int block_size = 16 << xd->mode_info_context->mbmi.sb_type;
|
|
|
|
uint8_t *rec_y = xd->dst.y_buffer;
|
|
|
|
int rec_ystride = xd->dst.y_stride;
|
|
|
|
int64_t metric = 0;
|
|
|
|
int i;
|
|
|
|
if (xd->up_available) {
|
|
|
|
for (i = 0; i < block_size; ++i) {
|
|
|
|
int diff = abs(*(rec_y - rec_ystride + i) -
|
|
|
|
*(tmp_y + i));
|
|
|
|
#ifdef SEARCH_MIN3
|
|
|
|
// Searches for the min abs diff among 3 pixel neighbors in the border
|
|
|
|
int diff1 = xd->left_available ?
|
|
|
|
abs(*(rec_y - rec_ystride + i - 1) - *(tmp_y + i)) : diff;
|
|
|
|
int diff2 = i < block_size - 1 ?
|
|
|
|
abs(*(rec_y - rec_ystride + i + 1) - *(tmp_y + i)) : diff;
|
|
|
|
diff = diff <= diff1 ? diff : diff1;
|
|
|
|
diff = diff <= diff2 ? diff : diff2;
|
|
|
|
#endif
|
|
|
|
metric += diff;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (xd->left_available) {
|
|
|
|
for (i = 0; i < block_size; ++i) {
|
|
|
|
int diff = abs(*(rec_y - 1 + i * rec_ystride) -
|
|
|
|
*(tmp_y + i * tmp_ystride));
|
|
|
|
#ifdef SEARCH_MIN3
|
|
|
|
// Searches for the min abs diff among 3 pixel neighbors in the border
|
|
|
|
int diff1 = xd->up_available ?
|
|
|
|
abs(*(rec_y - 1 + (i - 1) * rec_ystride) -
|
|
|
|
*(tmp_y + i * tmp_ystride)) : diff;
|
|
|
|
int diff2 = i < block_size - 1 ?
|
|
|
|
abs(*(rec_y - 1 + (i + 1) * rec_ystride) -
|
|
|
|
*(tmp_y + i * tmp_ystride)) : diff;
|
|
|
|
diff = diff <= diff1 ? diff : diff1;
|
|
|
|
diff = diff <= diff2 ? diff : diff2;
|
|
|
|
#endif
|
|
|
|
metric += diff;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return metric;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int get_weight(MACROBLOCKD *xd, int64_t metric_1, int64_t metric_2) {
|
|
|
|
int weight = AVERAGE_WEIGHT;
|
|
|
|
if (2 * metric_1 < metric_2)
|
|
|
|
weight = 6;
|
|
|
|
else if (4 * metric_1 < 3 * metric_2)
|
|
|
|
weight = 5;
|
|
|
|
else if (2 * metric_2 < metric_1)
|
|
|
|
weight = 2;
|
|
|
|
else if (4 * metric_2 < 3 * metric_1)
|
|
|
|
weight = 3;
|
|
|
|
return weight;
|
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef USE_IMPLICIT_WEIGHT_SPLITMV
|
|
|
|
static int get_implicit_compoundinter_weight_splitmv(
|
|
|
|
MACROBLOCKD *xd, int mb_row, int mb_col) {
|
|
|
|
MB_MODE_INFO *mbmi = &xd->mode_info_context->mbmi;
|
|
|
|
BLOCKD *blockd = xd->block;
|
|
|
|
const int use_second_ref = mbmi->second_ref_frame > 0;
|
|
|
|
int64_t metric_2 = 0, metric_1 = 0;
|
|
|
|
int i, which_mv, weight;
|
|
|
|
uint8_t tmp_y[256];
|
|
|
|
const int tmp_ystride = 16;
|
|
|
|
|
|
|
|
if (!use_second_ref) return 0;
|
|
|
|
if (!(xd->up_available || xd->left_available))
|
|
|
|
return AVERAGE_WEIGHT;
|
|
|
|
|
|
|
|
assert(xd->mode_info_context->mbmi.mode == SPLITMV);
|
|
|
|
|
|
|
|
which_mv = 1; // second predictor
|
|
|
|
if (xd->mode_info_context->mbmi.partitioning != PARTITIONING_4X4) {
|
|
|
|
for (i = 0; i < 16; i += 8) {
|
|
|
|
BLOCKD *d0 = &blockd[i];
|
|
|
|
BLOCKD *d1 = &blockd[i + 2];
|
|
|
|
const int y = i & 8;
|
|
|
|
|
|
|
|
blockd[i + 0].bmi = xd->mode_info_context->bmi[i + 0];
|
|
|
|
blockd[i + 2].bmi = xd->mode_info_context->bmi[i + 2];
|
|
|
|
|
|
|
|
if (mbmi->need_to_clamp_mvs) {
|
|
|
|
clamp_mv_to_umv_border(&blockd[i + 0].bmi.as_mv[which_mv].as_mv, xd);
|
|
|
|
clamp_mv_to_umv_border(&blockd[i + 2].bmi.as_mv[which_mv].as_mv, xd);
|
|
|
|
}
|
|
|
|
if (i == 0) {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y, 8, 16,
|
|
|
|
which_mv, 0, 16, 1,
|
|
|
|
&xd->subpix, mb_row * 16 + y, mb_col * 16);
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y, 8, 16,
|
|
|
|
which_mv, 0, 1, 8,
|
|
|
|
&xd->subpix, mb_row * 16 + y, mb_col * 16);
|
|
|
|
} else {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y + 8 * 16,
|
|
|
|
8, 16, which_mv, 0, 1, 8,
|
|
|
|
&xd->subpix, mb_row * 16 + y, mb_col * 16);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
for (i = 0; i < 16; i += 2) {
|
|
|
|
BLOCKD *d0 = &blockd[i];
|
|
|
|
BLOCKD *d1 = &blockd[i + 1];
|
|
|
|
const int x = (i & 3) * 4;
|
|
|
|
const int y = (i >> 2) * 4;
|
|
|
|
|
|
|
|
blockd[i + 0].bmi = xd->mode_info_context->bmi[i + 0];
|
|
|
|
blockd[i + 1].bmi = xd->mode_info_context->bmi[i + 1];
|
|
|
|
|
|
|
|
if (i >= 4 && (i & 3) != 0) continue;
|
|
|
|
|
|
|
|
if (i == 0) {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y, 4, 16,
|
|
|
|
which_mv, 0, 8, 1, &xd->subpix,
|
|
|
|
mb_row * 16 + y, mb_col * 16 + x);
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y, 4, 16,
|
|
|
|
which_mv, 0, 1, 4, &xd->subpix,
|
|
|
|
mb_row * 16 + y, mb_col * 16 + x);
|
|
|
|
} else if (i < 4) {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y + x, 4, 16,
|
|
|
|
which_mv, 0, 8, 1, &xd->subpix,
|
|
|
|
mb_row * 16 + y, mb_col * 16 + x);
|
|
|
|
} else {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y + y * 16,
|
|
|
|
4, 16, which_mv, 0, 1, 4, &xd->subpix,
|
|
|
|
mb_row * 16 + y, mb_col * 16 + x);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
metric_2 = get_consistency_metric(xd, tmp_y, tmp_ystride);
|
|
|
|
|
|
|
|
which_mv = 0; // first predictor
|
|
|
|
if (xd->mode_info_context->mbmi.partitioning != PARTITIONING_4X4) {
|
|
|
|
for (i = 0; i < 16; i += 8) {
|
|
|
|
BLOCKD *d0 = &blockd[i];
|
|
|
|
BLOCKD *d1 = &blockd[i + 2];
|
|
|
|
const int y = i & 8;
|
|
|
|
|
|
|
|
blockd[i + 0].bmi = xd->mode_info_context->bmi[i + 0];
|
|
|
|
blockd[i + 2].bmi = xd->mode_info_context->bmi[i + 2];
|
|
|
|
|
|
|
|
if (mbmi->need_to_clamp_mvs) {
|
|
|
|
clamp_mv_to_umv_border(&blockd[i + 0].bmi.as_mv[which_mv].as_mv, xd);
|
|
|
|
clamp_mv_to_umv_border(&blockd[i + 2].bmi.as_mv[which_mv].as_mv, xd);
|
|
|
|
}
|
|
|
|
if (i == 0) {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y, 8, 16,
|
|
|
|
which_mv, 0, 16, 1,
|
|
|
|
&xd->subpix, mb_row * 16 + y, mb_col * 16);
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y, 8, 16,
|
|
|
|
which_mv, 0, 1, 8,
|
|
|
|
&xd->subpix, mb_row * 16 + y, mb_col * 16);
|
|
|
|
} else {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y + 8 * 16,
|
|
|
|
8, 16, which_mv, 0, 1, 8,
|
|
|
|
&xd->subpix, mb_row * 16 + y, mb_col * 16);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
for (i = 0; i < 16; i += 2) {
|
|
|
|
BLOCKD *d0 = &blockd[i];
|
|
|
|
BLOCKD *d1 = &blockd[i + 1];
|
|
|
|
const int x = (i & 3) * 4;
|
|
|
|
const int y = (i >> 2) * 4;
|
|
|
|
|
|
|
|
blockd[i + 0].bmi = xd->mode_info_context->bmi[i + 0];
|
|
|
|
blockd[i + 1].bmi = xd->mode_info_context->bmi[i + 1];
|
|
|
|
|
|
|
|
if (i >= 4 && (i & 3) != 0) continue;
|
|
|
|
|
|
|
|
if (i == 0) {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y, 4, 16,
|
|
|
|
which_mv, 0, 8, 1, &xd->subpix,
|
|
|
|
mb_row * 16 + y, mb_col * 16 + x);
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y, 4, 16,
|
|
|
|
which_mv, 0, 1, 4, &xd->subpix,
|
|
|
|
mb_row * 16 + y, mb_col * 16 + x);
|
|
|
|
} else if (i < 4) {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y + x, 4, 16,
|
|
|
|
which_mv, 0, 8, 1, &xd->subpix,
|
|
|
|
mb_row * 16 + y, mb_col * 16 + x);
|
|
|
|
} else {
|
|
|
|
build_2x1_inter_predictor_wh(d0, d1, xd->scale_factor, tmp_y + y * 16,
|
|
|
|
4, 16, which_mv, 0, 1, 4, &xd->subpix,
|
|
|
|
mb_row * 16 + y, mb_col * 16 + x);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
metric_1 = get_consistency_metric(xd, tmp_y, tmp_ystride);
|
|
|
|
|
|
|
|
// Choose final weight for averaging
|
|
|
|
weight = get_weight(xd, metric_1, metric_2);
|
|
|
|
return weight;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static int get_implicit_compoundinter_weight(MACROBLOCKD *xd,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col) {
|
|
|
|
const int use_second_ref = xd->mode_info_context->mbmi.second_ref_frame > 0;
|
|
|
|
int64_t metric_2 = 0, metric_1 = 0;
|
|
|
|
int n, clamp_mvs, pre_stride;
|
|
|
|
uint8_t *base_pre;
|
|
|
|
int_mv ymv;
|
|
|
|
uint8_t tmp_y[4096];
|
|
|
|
const int tmp_ystride = 64;
|
|
|
|
int weight;
|
|
|
|
int edge[4];
|
|
|
|
int block_size = 16 << xd->mode_info_context->mbmi.sb_type;
|
2013-04-04 18:56:02 +02:00
|
|
|
struct scale_factors *scale;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
|
|
|
if (!use_second_ref) return 0;
|
|
|
|
if (!(xd->up_available || xd->left_available))
|
|
|
|
return AVERAGE_WEIGHT;
|
|
|
|
|
|
|
|
edge[0] = xd->mb_to_top_edge;
|
|
|
|
edge[1] = xd->mb_to_bottom_edge;
|
|
|
|
edge[2] = xd->mb_to_left_edge;
|
|
|
|
edge[3] = xd->mb_to_right_edge;
|
|
|
|
|
|
|
|
clamp_mvs = xd->mode_info_context->mbmi.need_to_clamp_secondmv;
|
|
|
|
base_pre = xd->second_pre.y_buffer;
|
|
|
|
pre_stride = xd->second_pre.y_stride;
|
|
|
|
ymv.as_int = xd->mode_info_context->mbmi.mv[1].as_int;
|
|
|
|
// First generate the second predictor
|
2013-04-04 18:56:02 +02:00
|
|
|
scale = &xd->scale_factor[1];
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
for (n = 0; n < block_size; n += 16) {
|
|
|
|
xd->mb_to_left_edge = edge[2] - (n << 3);
|
|
|
|
xd->mb_to_right_edge = edge[3] + ((16 - n) << 3);
|
|
|
|
if (clamp_mvs)
|
|
|
|
clamp_mv_to_umv_border(&ymv.as_mv, xd);
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, mb_row * 16, mb_col * 16 + n);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
// predict a single row of pixels
|
2013-04-04 18:56:02 +02:00
|
|
|
vp9_build_inter_predictor(base_pre +
|
|
|
|
scaled_buffer_offset(n, 0, pre_stride, scale),
|
|
|
|
pre_stride, tmp_y + n, tmp_ystride, &ymv, scale, 16, 1, 0, &xd->subpix);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
}
|
|
|
|
xd->mb_to_left_edge = edge[2];
|
|
|
|
xd->mb_to_right_edge = edge[3];
|
|
|
|
for (n = 0; n < block_size; n += 16) {
|
|
|
|
xd->mb_to_top_edge = edge[0] - (n << 3);
|
|
|
|
xd->mb_to_bottom_edge = edge[1] + ((16 - n) << 3);
|
|
|
|
if (clamp_mvs)
|
|
|
|
clamp_mv_to_umv_border(&ymv.as_mv, xd);
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, mb_row * 16 + n, mb_col * 16);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
// predict a single col of pixels
|
2013-04-04 18:56:02 +02:00
|
|
|
vp9_build_inter_predictor(base_pre +
|
|
|
|
scaled_buffer_offset(0, n, pre_stride, scale),
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
pre_stride, tmp_y + n * tmp_ystride, tmp_ystride, &ymv,
|
2013-04-04 18:56:02 +02:00
|
|
|
scale, 1, 16, 0, &xd->subpix);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
}
|
|
|
|
xd->mb_to_top_edge = edge[0];
|
|
|
|
xd->mb_to_bottom_edge = edge[1];
|
|
|
|
// Compute consistency metric
|
|
|
|
metric_2 = get_consistency_metric(xd, tmp_y, tmp_ystride);
|
|
|
|
|
|
|
|
clamp_mvs = xd->mode_info_context->mbmi.need_to_clamp_mvs;
|
|
|
|
base_pre = xd->pre.y_buffer;
|
|
|
|
pre_stride = xd->pre.y_stride;
|
|
|
|
ymv.as_int = xd->mode_info_context->mbmi.mv[0].as_int;
|
|
|
|
// Now generate the first predictor
|
2013-04-04 18:56:02 +02:00
|
|
|
scale = &xd->scale_factor[0];
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
for (n = 0; n < block_size; n += 16) {
|
|
|
|
xd->mb_to_left_edge = edge[2] - (n << 3);
|
|
|
|
xd->mb_to_right_edge = edge[3] + ((16 - n) << 3);
|
|
|
|
if (clamp_mvs)
|
|
|
|
clamp_mv_to_umv_border(&ymv.as_mv, xd);
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, mb_row * 16, mb_col * 16 + n);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
// predict a single row of pixels
|
2013-04-04 18:56:02 +02:00
|
|
|
vp9_build_inter_predictor(base_pre +
|
|
|
|
scaled_buffer_offset(n, 0, pre_stride, scale),
|
|
|
|
pre_stride, tmp_y + n, tmp_ystride, &ymv, scale, 16, 1, 0, &xd->subpix);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
}
|
|
|
|
xd->mb_to_left_edge = edge[2];
|
|
|
|
xd->mb_to_right_edge = edge[3];
|
|
|
|
for (n = 0; n < block_size; n += 16) {
|
|
|
|
xd->mb_to_top_edge = edge[0] - (n << 3);
|
|
|
|
xd->mb_to_bottom_edge = edge[1] + ((16 - n) << 3);
|
|
|
|
if (clamp_mvs)
|
|
|
|
clamp_mv_to_umv_border(&ymv.as_mv, xd);
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, mb_row * 16 + n, mb_col * 16);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
// predict a single col of pixels
|
2013-04-04 18:56:02 +02:00
|
|
|
vp9_build_inter_predictor(base_pre +
|
|
|
|
scaled_buffer_offset(0, n, pre_stride, scale),
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
pre_stride, tmp_y + n * tmp_ystride, tmp_ystride, &ymv,
|
2013-04-04 18:56:02 +02:00
|
|
|
scale, 1, 16, 0, &xd->subpix);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
}
|
|
|
|
xd->mb_to_top_edge = edge[0];
|
|
|
|
xd->mb_to_bottom_edge = edge[1];
|
|
|
|
metric_1 = get_consistency_metric(xd, tmp_y, tmp_ystride);
|
|
|
|
|
|
|
|
// Choose final weight for averaging
|
|
|
|
weight = get_weight(xd, metric_1, metric_2);
|
|
|
|
return weight;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void build_inter16x16_predictors_mby_w(MACROBLOCKD *xd,
|
|
|
|
uint8_t *dst_y,
|
|
|
|
int dst_ystride,
|
|
|
|
int weight,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col) {
|
2013-02-09 02:49:44 +01:00
|
|
|
const int use_second_ref = xd->mode_info_context->mbmi.second_ref_frame > 0;
|
|
|
|
int which_mv;
|
|
|
|
|
|
|
|
for (which_mv = 0; which_mv < 1 + use_second_ref; ++which_mv) {
|
2013-03-02 02:50:55 +01:00
|
|
|
const int clamp_mvs = which_mv ?
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
xd->mode_info_context->mbmi.need_to_clamp_secondmv :
|
2013-03-02 02:50:55 +01:00
|
|
|
xd->mode_info_context->mbmi.need_to_clamp_mvs;
|
2013-02-09 02:49:44 +01:00
|
|
|
|
2013-03-02 02:50:55 +01:00
|
|
|
uint8_t *base_pre = which_mv ? xd->second_pre.y_buffer : xd->pre.y_buffer;
|
|
|
|
int pre_stride = which_mv ? xd->second_pre.y_stride : xd->pre.y_stride;
|
|
|
|
int_mv ymv;
|
2013-04-04 18:56:02 +02:00
|
|
|
struct scale_factors *scale = &xd->scale_factor[which_mv];
|
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
ymv.as_int = xd->mode_info_context->mbmi.mv[which_mv].as_int;
|
2013-03-02 02:50:55 +01:00
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
if (clamp_mvs)
|
|
|
|
clamp_mv_to_umv_border(&ymv.as_mv, xd);
|
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, mb_row * 16, mb_col * 16);
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
vp9_build_inter_predictor(base_pre, pre_stride, dst_y, dst_ystride,
|
|
|
|
&ymv, scale, 16, 16,
|
|
|
|
which_mv ? weight : 0, &xd->subpix);
|
2013-02-09 02:49:44 +01:00
|
|
|
}
|
2012-08-09 02:12:12 +02:00
|
|
|
}
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
#endif
|
|
|
|
|
|
|
|
#if CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT
|
|
|
|
static void build_inter16x16_predictors_mbuv_w(MACROBLOCKD *xd,
|
|
|
|
uint8_t *dst_u,
|
|
|
|
uint8_t *dst_v,
|
|
|
|
int dst_uvstride,
|
|
|
|
int weight,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col) {
|
|
|
|
const int use_second_ref = xd->mode_info_context->mbmi.second_ref_frame > 0;
|
|
|
|
int which_mv;
|
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
for (which_mv = 0; which_mv < 1 + use_second_ref; ++which_mv) {
|
|
|
|
const int clamp_mvs =
|
|
|
|
which_mv ? xd->mode_info_context->mbmi.need_to_clamp_secondmv
|
|
|
|
: xd->mode_info_context->mbmi.need_to_clamp_mvs;
|
|
|
|
uint8_t *uptr, *vptr;
|
2013-03-12 16:44:53 +01:00
|
|
|
int pre_stride = which_mv ? xd->second_pre.uv_stride
|
|
|
|
: xd->pre.uv_stride;
|
2013-02-09 02:49:44 +01:00
|
|
|
int_mv _o16x16mv;
|
|
|
|
int_mv _16x16mv;
|
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
struct scale_factors *scale = &xd->scale_factor_uv[which_mv];
|
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
_16x16mv.as_int = xd->mode_info_context->mbmi.mv[which_mv].as_int;
|
|
|
|
|
|
|
|
if (clamp_mvs)
|
|
|
|
clamp_mv_to_umv_border(&_16x16mv.as_mv, xd);
|
|
|
|
|
|
|
|
_o16x16mv = _16x16mv;
|
|
|
|
/* calc uv motion vectors */
|
|
|
|
if (_16x16mv.as_mv.row < 0)
|
|
|
|
_16x16mv.as_mv.row -= 1;
|
|
|
|
else
|
|
|
|
_16x16mv.as_mv.row += 1;
|
|
|
|
|
|
|
|
if (_16x16mv.as_mv.col < 0)
|
|
|
|
_16x16mv.as_mv.col -= 1;
|
|
|
|
else
|
|
|
|
_16x16mv.as_mv.col += 1;
|
|
|
|
|
|
|
|
_16x16mv.as_mv.row /= 2;
|
|
|
|
_16x16mv.as_mv.col /= 2;
|
|
|
|
|
|
|
|
uptr = (which_mv ? xd->second_pre.u_buffer : xd->pre.u_buffer);
|
|
|
|
vptr = (which_mv ? xd->second_pre.v_buffer : xd->pre.v_buffer);
|
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, mb_row * 16, mb_col * 16);
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
vp9_build_inter_predictor_q4(
|
|
|
|
uptr, pre_stride, dst_u, dst_uvstride, &_16x16mv, &_o16x16mv,
|
2013-04-04 18:56:02 +02:00
|
|
|
scale, 8, 8, which_mv ? weight : 0, &xd->subpix);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
|
|
|
vp9_build_inter_predictor_q4(
|
|
|
|
vptr, pre_stride, dst_v, dst_uvstride, &_16x16mv, &_o16x16mv,
|
2013-04-04 18:56:02 +02:00
|
|
|
scale, 8, 8, which_mv ? weight : 0, &xd->subpix);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void vp9_build_inter16x16_predictors_mbuv(MACROBLOCKD *xd,
|
|
|
|
uint8_t *dst_u,
|
|
|
|
uint8_t *dst_v,
|
|
|
|
int dst_uvstride,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col) {
|
|
|
|
#ifdef USE_IMPLICIT_WEIGHT_UV
|
|
|
|
int weight = get_implicit_compoundinter_weight(xd, mb_row, mb_col);
|
|
|
|
#else
|
|
|
|
int weight = AVERAGE_WEIGHT;
|
|
|
|
#endif
|
|
|
|
build_inter16x16_predictors_mbuv_w(xd, dst_u, dst_v, dst_uvstride,
|
|
|
|
weight, mb_row, mb_col);
|
|
|
|
}
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
|
|
|
void vp9_build_inter16x16_predictors_mbuv(MACROBLOCKD *xd,
|
|
|
|
uint8_t *dst_u,
|
|
|
|
uint8_t *dst_v,
|
|
|
|
int dst_uvstride,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col) {
|
|
|
|
const int use_second_ref = xd->mode_info_context->mbmi.second_ref_frame > 0;
|
|
|
|
int which_mv;
|
|
|
|
|
|
|
|
for (which_mv = 0; which_mv < 1 + use_second_ref; ++which_mv) {
|
|
|
|
const int clamp_mvs =
|
|
|
|
which_mv ? xd->mode_info_context->mbmi.need_to_clamp_secondmv
|
|
|
|
: xd->mode_info_context->mbmi.need_to_clamp_mvs;
|
|
|
|
uint8_t *uptr, *vptr;
|
|
|
|
int pre_stride = which_mv ? xd->second_pre.uv_stride
|
|
|
|
: xd->pre.uv_stride;
|
|
|
|
int_mv _o16x16mv;
|
|
|
|
int_mv _16x16mv;
|
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
struct scale_factors *scale = &xd->scale_factor_uv[which_mv];
|
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
_16x16mv.as_int = xd->mode_info_context->mbmi.mv[which_mv].as_int;
|
|
|
|
|
|
|
|
if (clamp_mvs)
|
|
|
|
clamp_mv_to_umv_border(&_16x16mv.as_mv, xd);
|
|
|
|
|
|
|
|
_o16x16mv = _16x16mv;
|
|
|
|
/* calc uv motion vectors */
|
|
|
|
if (_16x16mv.as_mv.row < 0)
|
|
|
|
_16x16mv.as_mv.row -= 1;
|
|
|
|
else
|
|
|
|
_16x16mv.as_mv.row += 1;
|
|
|
|
|
|
|
|
if (_16x16mv.as_mv.col < 0)
|
|
|
|
_16x16mv.as_mv.col -= 1;
|
|
|
|
else
|
|
|
|
_16x16mv.as_mv.col += 1;
|
|
|
|
|
|
|
|
_16x16mv.as_mv.row /= 2;
|
|
|
|
_16x16mv.as_mv.col /= 2;
|
|
|
|
|
|
|
|
uptr = (which_mv ? xd->second_pre.u_buffer : xd->pre.u_buffer);
|
|
|
|
vptr = (which_mv ? xd->second_pre.v_buffer : xd->pre.v_buffer);
|
|
|
|
|
2013-04-04 18:56:02 +02:00
|
|
|
scale->set_scaled_offsets(scale, mb_row * 16, mb_col * 16);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
|
|
|
vp9_build_inter_predictor_q4(
|
|
|
|
uptr, pre_stride, dst_u, dst_uvstride, &_16x16mv, &_o16x16mv,
|
2013-04-04 18:56:02 +02:00
|
|
|
scale, 8, 8,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
which_mv << (2 * CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT), &xd->subpix);
|
|
|
|
|
|
|
|
vp9_build_inter_predictor_q4(
|
|
|
|
vptr, pre_stride, dst_v, dst_uvstride, &_16x16mv, &_o16x16mv,
|
2013-04-04 18:56:02 +02:00
|
|
|
scale, 8, 8,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
which_mv << (2 * CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT), &xd->subpix);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#if CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT
|
2013-04-12 20:25:53 +02:00
|
|
|
static void build_inter_predictors_sby_w(MACROBLOCKD *x,
|
|
|
|
uint8_t *dst_y,
|
|
|
|
int dst_ystride,
|
|
|
|
int weight,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col,
|
|
|
|
BLOCK_SIZE_TYPE bsize) {
|
|
|
|
const int bwl = mb_width_log2(bsize), bw = 1 << bwl;
|
|
|
|
const int bhl = mb_height_log2(bsize), bh = 1 << bhl;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
uint8_t *y1 = x->pre.y_buffer;
|
|
|
|
uint8_t *y2 = x->second_pre.y_buffer;
|
|
|
|
int edge[4], n;
|
|
|
|
|
|
|
|
edge[0] = x->mb_to_top_edge;
|
|
|
|
edge[1] = x->mb_to_bottom_edge;
|
|
|
|
edge[2] = x->mb_to_left_edge;
|
|
|
|
edge[3] = x->mb_to_right_edge;
|
|
|
|
|
2013-04-12 20:25:53 +02:00
|
|
|
for (n = 0; n < bw * bh; n++) {
|
|
|
|
const int x_idx = n & (bw - 1), y_idx = n >> bwl;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
2013-04-18 01:12:02 +02:00
|
|
|
x->mb_to_top_edge = edge[0] - ((y_idx * 16) << 3);
|
|
|
|
x->mb_to_bottom_edge = edge[1] + (((bh - 1 - y_idx) * 16) << 3);
|
|
|
|
x->mb_to_left_edge = edge[2] - ((x_idx * 16) << 3);
|
|
|
|
x->mb_to_right_edge = edge[3] + (((bw - 1 - x_idx) * 16) << 3);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
|
|
|
x->pre.y_buffer = y1 + scaled_buffer_offset(x_idx * 16,
|
|
|
|
y_idx * 16,
|
|
|
|
x->pre.y_stride,
|
|
|
|
&x->scale_factor[0]);
|
|
|
|
if (x->mode_info_context->mbmi.second_ref_frame > 0) {
|
|
|
|
x->second_pre.y_buffer = y2 +
|
|
|
|
scaled_buffer_offset(x_idx * 16,
|
|
|
|
y_idx * 16,
|
|
|
|
x->second_pre.y_stride,
|
|
|
|
&x->scale_factor[1]);
|
|
|
|
}
|
|
|
|
build_inter16x16_predictors_mby_w(x,
|
|
|
|
dst_y + y_idx * 16 * dst_ystride + x_idx * 16,
|
|
|
|
dst_ystride, weight, mb_row + y_idx, mb_col + x_idx);
|
|
|
|
}
|
|
|
|
x->mb_to_top_edge = edge[0];
|
|
|
|
x->mb_to_bottom_edge = edge[1];
|
|
|
|
x->mb_to_left_edge = edge[2];
|
|
|
|
x->mb_to_right_edge = edge[3];
|
|
|
|
|
|
|
|
x->pre.y_buffer = y1;
|
|
|
|
if (x->mode_info_context->mbmi.second_ref_frame > 0) {
|
|
|
|
x->second_pre.y_buffer = y2;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-04-12 20:25:53 +02:00
|
|
|
void vp9_build_inter_predictors_sby(MACROBLOCKD *x,
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
uint8_t *dst_y,
|
|
|
|
int dst_ystride,
|
|
|
|
int mb_row,
|
2013-04-12 20:25:53 +02:00
|
|
|
int mb_col,
|
|
|
|
BLOCK_SIZE_TYPE bsize) {
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
int weight = get_implicit_compoundinter_weight(x, mb_row, mb_col);
|
2013-04-12 20:25:53 +02:00
|
|
|
build_inter_predictors_sby_w(x, dst_y, dst_ystride, weight,
|
|
|
|
mb_row, mb_col, bsize);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#if CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT
|
2013-04-12 20:25:53 +02:00
|
|
|
static void build_inter_predictors_sbuv_w(MACROBLOCKD *x,
|
|
|
|
uint8_t *dst_u,
|
|
|
|
uint8_t *dst_v,
|
|
|
|
int dst_uvstride,
|
|
|
|
int weight,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col,
|
|
|
|
BLOCK_SIZE_TYPE bsize) {
|
|
|
|
const int bwl = mb_width_log2(bsize), bw = 1 << bwl;
|
|
|
|
const int bhl = mb_height_log2(bsize), bh = 1 << bhl;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
uint8_t *u1 = x->pre.u_buffer, *v1 = x->pre.v_buffer;
|
|
|
|
uint8_t *u2 = x->second_pre.u_buffer, *v2 = x->second_pre.v_buffer;
|
|
|
|
int edge[4], n;
|
|
|
|
|
|
|
|
edge[0] = x->mb_to_top_edge;
|
|
|
|
edge[1] = x->mb_to_bottom_edge;
|
|
|
|
edge[2] = x->mb_to_left_edge;
|
|
|
|
edge[3] = x->mb_to_right_edge;
|
|
|
|
|
2013-04-12 20:25:53 +02:00
|
|
|
for (n = 0; n < bw * bh; n++) {
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
int scaled_uv_offset;
|
2013-04-12 20:25:53 +02:00
|
|
|
const int x_idx = n & (bw - 1), y_idx = n >> bwl;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
2013-04-18 01:12:02 +02:00
|
|
|
x->mb_to_top_edge = edge[0] - ((y_idx * 16) << 3);
|
|
|
|
x->mb_to_bottom_edge = edge[1] + (((bh - 1 - y_idx) * 16) << 3);
|
|
|
|
x->mb_to_left_edge = edge[2] - ((x_idx * 16) << 3);
|
|
|
|
x->mb_to_right_edge = edge[3] + (((bw - 1 - x_idx) * 16) << 3);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
|
|
|
scaled_uv_offset = scaled_buffer_offset(x_idx * 8,
|
|
|
|
y_idx * 8,
|
|
|
|
x->pre.uv_stride,
|
|
|
|
&x->scale_factor_uv[0]);
|
|
|
|
x->pre.u_buffer = u1 + scaled_uv_offset;
|
|
|
|
x->pre.v_buffer = v1 + scaled_uv_offset;
|
|
|
|
|
|
|
|
if (x->mode_info_context->mbmi.second_ref_frame > 0) {
|
|
|
|
scaled_uv_offset = scaled_buffer_offset(x_idx * 8,
|
|
|
|
y_idx * 8,
|
|
|
|
x->second_pre.uv_stride,
|
|
|
|
&x->scale_factor_uv[1]);
|
|
|
|
x->second_pre.u_buffer = u2 + scaled_uv_offset;
|
|
|
|
x->second_pre.v_buffer = v2 + scaled_uv_offset;
|
|
|
|
}
|
|
|
|
|
|
|
|
build_inter16x16_predictors_mbuv_w(x,
|
|
|
|
dst_u + y_idx * 8 * dst_uvstride + x_idx * 8,
|
|
|
|
dst_v + y_idx * 8 * dst_uvstride + x_idx * 8,
|
|
|
|
dst_uvstride, weight, mb_row + y_idx, mb_col + x_idx);
|
|
|
|
}
|
|
|
|
x->mb_to_top_edge = edge[0];
|
|
|
|
x->mb_to_bottom_edge = edge[1];
|
|
|
|
x->mb_to_left_edge = edge[2];
|
|
|
|
x->mb_to_right_edge = edge[3];
|
|
|
|
|
|
|
|
x->pre.u_buffer = u1;
|
|
|
|
x->pre.v_buffer = v1;
|
|
|
|
|
|
|
|
if (x->mode_info_context->mbmi.second_ref_frame > 0) {
|
|
|
|
x->second_pre.u_buffer = u2;
|
|
|
|
x->second_pre.v_buffer = v2;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-04-12 20:25:53 +02:00
|
|
|
void vp9_build_inter_predictors_sbuv(MACROBLOCKD *xd,
|
|
|
|
uint8_t *dst_u,
|
|
|
|
uint8_t *dst_v,
|
|
|
|
int dst_uvstride,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col,
|
|
|
|
BLOCK_SIZE_TYPE bsize) {
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
#ifdef USE_IMPLICIT_WEIGHT_UV
|
|
|
|
int weight = get_implicit_compoundinter_weight(xd, mb_row, mb_col);
|
|
|
|
#else
|
|
|
|
int weight = AVERAGE_WEIGHT;
|
|
|
|
#endif
|
2013-04-12 20:25:53 +02:00
|
|
|
build_inter_predictors_sbuv_w(xd, dst_u, dst_v, dst_uvstride,
|
|
|
|
weight, mb_row, mb_col, bsize);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
2013-04-12 20:25:53 +02:00
|
|
|
void vp9_build_inter_predictors_sbuv(MACROBLOCKD *x,
|
|
|
|
uint8_t *dst_u,
|
|
|
|
uint8_t *dst_v,
|
|
|
|
int dst_uvstride,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col,
|
|
|
|
BLOCK_SIZE_TYPE bsize) {
|
|
|
|
const int bwl = mb_width_log2(bsize), bw = 1 << bwl;
|
|
|
|
const int bhl = mb_height_log2(bsize), bh = 1 << bhl;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
uint8_t *u1 = x->pre.u_buffer, *v1 = x->pre.v_buffer;
|
|
|
|
uint8_t *u2 = x->second_pre.u_buffer, *v2 = x->second_pre.v_buffer;
|
|
|
|
int edge[4], n;
|
|
|
|
|
|
|
|
edge[0] = x->mb_to_top_edge;
|
|
|
|
edge[1] = x->mb_to_bottom_edge;
|
|
|
|
edge[2] = x->mb_to_left_edge;
|
|
|
|
edge[3] = x->mb_to_right_edge;
|
|
|
|
|
2013-04-12 20:25:53 +02:00
|
|
|
for (n = 0; n < bw * bh; n++) {
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
int scaled_uv_offset;
|
2013-04-12 20:25:53 +02:00
|
|
|
const int x_idx = n & (bw - 1), y_idx = n >> bwl;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
2013-04-18 01:12:02 +02:00
|
|
|
x->mb_to_top_edge = edge[0] - ((y_idx * 16) << 3);
|
|
|
|
x->mb_to_bottom_edge = edge[1] + (((bh - 1 - y_idx) * 16) << 3);
|
|
|
|
x->mb_to_left_edge = edge[2] - ((x_idx * 16) << 3);
|
|
|
|
x->mb_to_right_edge = edge[3] + (((bw - 1 - x_idx) * 16) << 3);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
|
|
|
scaled_uv_offset = scaled_buffer_offset(x_idx * 8,
|
|
|
|
y_idx * 8,
|
|
|
|
x->pre.uv_stride,
|
|
|
|
&x->scale_factor_uv[0]);
|
|
|
|
x->pre.u_buffer = u1 + scaled_uv_offset;
|
|
|
|
x->pre.v_buffer = v1 + scaled_uv_offset;
|
|
|
|
|
|
|
|
if (x->mode_info_context->mbmi.second_ref_frame > 0) {
|
|
|
|
scaled_uv_offset = scaled_buffer_offset(x_idx * 8,
|
|
|
|
y_idx * 8,
|
|
|
|
x->second_pre.uv_stride,
|
|
|
|
&x->scale_factor_uv[1]);
|
|
|
|
x->second_pre.u_buffer = u2 + scaled_uv_offset;
|
|
|
|
x->second_pre.v_buffer = v2 + scaled_uv_offset;
|
|
|
|
}
|
|
|
|
|
|
|
|
vp9_build_inter16x16_predictors_mbuv(x,
|
|
|
|
dst_u + y_idx * 8 * dst_uvstride + x_idx * 8,
|
|
|
|
dst_v + y_idx * 8 * dst_uvstride + x_idx * 8,
|
|
|
|
dst_uvstride, mb_row + y_idx, mb_col + x_idx);
|
|
|
|
}
|
|
|
|
x->mb_to_top_edge = edge[0];
|
|
|
|
x->mb_to_bottom_edge = edge[1];
|
|
|
|
x->mb_to_left_edge = edge[2];
|
|
|
|
x->mb_to_right_edge = edge[3];
|
|
|
|
|
|
|
|
x->pre.u_buffer = u1;
|
|
|
|
x->pre.v_buffer = v1;
|
2013-02-09 02:49:44 +01:00
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
if (x->mode_info_context->mbmi.second_ref_frame > 0) {
|
|
|
|
x->second_pre.u_buffer = u2;
|
|
|
|
x->second_pre.v_buffer = v2;
|
2013-02-09 02:49:44 +01:00
|
|
|
}
|
2011-04-28 16:53:59 +02:00
|
|
|
}
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
#endif
|
2010-05-18 17:58:33 +02:00
|
|
|
|
2013-04-12 20:25:53 +02:00
|
|
|
void vp9_build_inter_predictors_sb(MACROBLOCKD *mb,
|
|
|
|
int mb_row, int mb_col,
|
|
|
|
BLOCK_SIZE_TYPE bsize) {
|
2013-03-28 00:19:27 +01:00
|
|
|
uint8_t *const y = mb->dst.y_buffer;
|
|
|
|
uint8_t *const u = mb->dst.u_buffer;
|
|
|
|
uint8_t *const v = mb->dst.v_buffer;
|
|
|
|
const int y_stride = mb->dst.y_stride;
|
|
|
|
const int uv_stride = mb->dst.uv_stride;
|
|
|
|
|
2013-04-12 20:25:53 +02:00
|
|
|
vp9_build_inter_predictors_sby(mb, y, y_stride, mb_row, mb_col, bsize);
|
|
|
|
vp9_build_inter_predictors_sbuv(mb, u, v, uv_stride, mb_row, mb_col, bsize);
|
2013-01-06 03:20:25 +01:00
|
|
|
#if CONFIG_COMP_INTERINTRA_PRED
|
2013-03-28 00:19:27 +01:00
|
|
|
if (mb->mode_info_context->mbmi.second_ref_frame == INTRA_FRAME) {
|
2013-04-12 20:25:53 +02:00
|
|
|
if (bsize == BLOCK_SIZE_SB32X32)
|
|
|
|
vp9_build_interintra_32x32_predictors_sb(mb, y, u, v,
|
|
|
|
y_stride, uv_stride);
|
|
|
|
else
|
|
|
|
vp9_build_interintra_64x64_predictors_sb(mb, y, u, v,
|
|
|
|
y_stride, uv_stride);
|
2012-11-30 20:46:20 +01:00
|
|
|
}
|
|
|
|
#endif
|
2012-08-20 23:43:34 +02:00
|
|
|
}
|
|
|
|
|
2013-02-20 22:46:55 +01:00
|
|
|
static void build_inter4x4_predictors_mb(MACROBLOCKD *xd,
|
2013-04-15 18:31:27 +02:00
|
|
|
int mb_row, int mb_col) {
|
2012-07-14 00:21:29 +02:00
|
|
|
int i;
|
2012-08-14 12:32:29 +02:00
|
|
|
MB_MODE_INFO * mbmi = &xd->mode_info_context->mbmi;
|
|
|
|
BLOCKD *blockd = xd->block;
|
2013-02-09 02:49:44 +01:00
|
|
|
int which_mv = 0;
|
|
|
|
const int use_second_ref = mbmi->second_ref_frame > 0;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
#if CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT && defined(USE_IMPLICIT_WEIGHT_SPLITMV)
|
|
|
|
int weight = get_implicit_compoundinter_weight_splitmv(xd, mb_row, mb_col);
|
|
|
|
#else
|
|
|
|
int weight = AVERAGE_WEIGHT;
|
|
|
|
#endif
|
2012-08-14 12:32:29 +02:00
|
|
|
|
2012-10-22 20:25:48 +02:00
|
|
|
if (xd->mode_info_context->mbmi.partitioning != PARTITIONING_4X4) {
|
2013-02-09 02:49:44 +01:00
|
|
|
for (i = 0; i < 16; i += 8) {
|
|
|
|
BLOCKD *d0 = &blockd[i];
|
|
|
|
BLOCKD *d1 = &blockd[i + 2];
|
2013-02-20 22:46:55 +01:00
|
|
|
const int y = i & 8;
|
2012-02-01 23:27:50 +01:00
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
blockd[i + 0].bmi = xd->mode_info_context->bmi[i + 0];
|
|
|
|
blockd[i + 2].bmi = xd->mode_info_context->bmi[i + 2];
|
Improved coding using 8x8 transform
In summary, this commit encompasses a series of changes in attempt to
improve the 8x8 transform based coding to help overall compression
quality, please refer to the detailed commit history below for what
are the rationale underly the series of changes:
a. A frame level flag to indicate if 8x8 transform is used at all.
b. 8x8 transform is not used for key frames and small image size.
c. On inter coded frame, macroblocks using modes B_PRED, SPLIT_MV
and I8X8_PRED are forced to using 4x4 transform based coding, the
rest uses 8x8 transform based coding.
d. Encoder and decoder has the same assumption on the relationship
between prediction modes and transform size, therefore no signaling
is encoded in bitstream.
e. Mode decision process now calculate the rate and distortion scores
using their respective transforms.
Overall test results:
1. HD set
http://www.corp.google.com/~yaowu/no_crawl/t8x8/HD_t8x8_20120206.html
(avg psnr: 3.09% glb psnr: 3.22%, ssim: 3.90%)
2. Cif set:
http://www.corp.google.com/~yaowu/no_crawl/t8x8/cif_t8x8_20120206.html
(avg psnr: -0.03%, glb psnr: -0.02%, ssim: -0.04%)
It should be noted here, as 8x8 transform coding itself is disabled
for cif size clips, the 0.03% loss is purely from the 1 bit/frame
flag overhead on if 8x8 transform is used or not for the frame.
---patch history for future reference---
Patch 1:
this commit tries to select transform size based on macroblock
prediction mode. If the size of a prediction mode is 16x16, then
the macroblock is forced to use 8x8 transform. If the prediction
mode is B_PRED, SPLITMV or I8X8_PRED, then the macroblock is forced
to use 4x4 transform. Tests on the following HD clips showed mixed
results: (all hd clips only used first 100 frames in the test)
http://www.corp.google.com/~yaowu/no_crawl/t8x8/hdmodebased8x8.html
http://www.corp.google.com/~yaowu/no_crawl/t8x8/hdmodebased8x8_log.html
while the results are mixed and overall negative, it is interesting to
see 8x8 helped a few of the clips.
Patch 2:
this patch tries to hard-wire selection of transform size based on
prediction modes without using segmentation to signal the transform size.
encoder and decoder both takes the same assumption that all macroblocks
use 8x8 transform except when prediciton mode is B_PRED, I8X8_PRED or
SPLITMV. Test results are as follows:
http://www.corp.google.com/~yaowu/no_crawl/t8x8/cifmodebase8x8_0125.html
http://www.corp.google.com/~yaowu/no_crawl/t8x8/hdmodebased8x8_0125log.html
Interestingly, by removing the overhead or coding the segmentation, the
results on this limited HD set have turn positive on average.
Patch 3:
this patch disabled the usage of 8x8 transform on key frames, and kept the
logic from patch 2 for inter frames only. test results on HD set turned
decidedly positive with 8x8 transform enabled on inter frame with 16x16
prediction modes: (avg psnr: .81% glb psnr: .82 ssim: .55%)
http://www.corp.google.com/~yaowu/no_crawl/t8x8/hdintermode8x8_0125.html
results on cif set still negative overall
Patch 4:
continued from last patch, but now in mode decision process, the rate and
distortion estimates are computed based on 8x8 transform results for MBs
with modes associated with 8x8 transform. This patch also fixed a problem
related to segment based eob coding when 8x8 transform is used. The patch
significantly improved the results on HD clips:
http://www.corp.google.com/~yaowu/no_crawl/t8x8/hd8x8RDintermode.html
(avg psnr: 2.70% glb psnr: 2.76% ssim: 3.34%)
results on cif also improved, though they are still negative compared to
baseline that uses 4x4 transform only:
http://www.corp.google.com/~yaowu/no_crawl/t8x8/cif8x8RDintermode.html
(avg psnr: -.78% glb psnr: -.86% ssim: -.19%)
Patch 5:
This patch does 3 things:
a. a bunch of decoder bug fixes, encodings and decodings were verified
to have matched recon buffer on a number of encodes on cif size mobile and
hd version of _pedestrian.
b. the patch further improved the rate distortion calculation of MBS that
use 8x8 transform. This provided some further gain on compression.
c. the patch also got the experimental work SEG_LVL_EOB to work with 8x8
transformed macroblock, test results indicates it improves the cif set
but hurt the HD set slightly.
Tests results on HD clips:
http://www.corp.google.com/~yaowu/no_crawl/t8x8/HD_t8x8_20120201.html
(avg psnr: 3.19% glb psnr: 3.30% ssim: 3.93%)
Test results on cif clips:
http://www.corp.google.com/~yaowu/no_crawl/t8x8/cif_t8x8_20120201.html
(avg psnr: -.47% glb psnr: -.51% ssim: +.28%)
Patch 6:
Added a frame level flag to indicate if 8x8 transform is allowed at all.
temporarily the decision is based on frame size, can be optimized later
one. This get the cif results to basically unchanged, with one bit per
frame overhead on both cif and hd clips.
Patch 8:
Rebase and Merge to head by PGW.
Fixed some suspect 4s that look like hey should be 64s in regard
to segmented EOB. Perhaps #defines would be bette.
Bulit and tested without T8x8 enabled and produces unchanged
output.
Patch 9:
Corrected misalligned code/decode of "txfm_mode" bit.
Limited testing for correct encode and decode with
T8x8 configured on derf clips.
Change-Id: I156e1405d25f81579d579dff8ab9af53944ec49c
2012-02-10 01:12:23 +01:00
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
for (which_mv = 0; which_mv < 1 + use_second_ref; ++which_mv) {
|
|
|
|
if (mbmi->need_to_clamp_mvs) {
|
|
|
|
clamp_mv_to_umv_border(&blockd[i + 0].bmi.as_mv[which_mv].as_mv, xd);
|
|
|
|
clamp_mv_to_umv_border(&blockd[i + 2].bmi.as_mv[which_mv].as_mv, xd);
|
|
|
|
}
|
2012-04-18 22:51:58 +02:00
|
|
|
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
build_2x1_inter_predictor(d0, d1, xd->scale_factor, 8, 16, which_mv,
|
|
|
|
which_mv ? weight : 0,
|
2013-04-15 18:31:27 +02:00
|
|
|
&xd->subpix, mb_row * 16 + y, mb_col * 16);
|
2013-02-09 02:49:44 +01:00
|
|
|
}
|
2011-04-28 16:53:59 +02:00
|
|
|
}
|
2012-07-14 00:21:29 +02:00
|
|
|
} else {
|
|
|
|
for (i = 0; i < 16; i += 2) {
|
2012-08-14 12:32:29 +02:00
|
|
|
BLOCKD *d0 = &blockd[i];
|
|
|
|
BLOCKD *d1 = &blockd[i + 1];
|
2013-02-20 22:46:55 +01:00
|
|
|
const int x = (i & 3) * 4;
|
|
|
|
const int y = (i >> 2) * 4;
|
2012-08-14 12:32:29 +02:00
|
|
|
|
|
|
|
blockd[i + 0].bmi = xd->mode_info_context->bmi[i + 0];
|
|
|
|
blockd[i + 1].bmi = xd->mode_info_context->bmi[i + 1];
|
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
for (which_mv = 0; which_mv < 1 + use_second_ref; ++which_mv) {
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
build_2x1_inter_predictor(d0, d1, xd->scale_factor, 4, 16, which_mv,
|
|
|
|
which_mv ? weight : 0,
|
|
|
|
&xd->subpix,
|
2013-04-15 18:31:27 +02:00
|
|
|
mb_row * 16 + y, mb_col * 16 + x);
|
2012-07-14 00:21:29 +02:00
|
|
|
}
|
2010-05-18 17:58:33 +02:00
|
|
|
}
|
2012-07-14 00:21:29 +02:00
|
|
|
}
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
#if CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT
|
|
|
|
#if !defined(USE_IMPLICIT_WEIGHT_UV)
|
|
|
|
weight = AVERAGE_WEIGHT;
|
|
|
|
#endif
|
|
|
|
#endif
|
2012-07-14 00:21:29 +02:00
|
|
|
for (i = 16; i < 24; i += 2) {
|
2012-08-14 12:32:29 +02:00
|
|
|
BLOCKD *d0 = &blockd[i];
|
|
|
|
BLOCKD *d1 = &blockd[i + 1];
|
2013-02-20 22:46:55 +01:00
|
|
|
const int x = 4 * (i & 1);
|
|
|
|
const int y = ((i - 16) >> 1) * 4;
|
2012-04-18 22:51:58 +02:00
|
|
|
|
2013-02-09 02:49:44 +01:00
|
|
|
for (which_mv = 0; which_mv < 1 + use_second_ref; ++which_mv) {
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
build_2x1_inter_predictor(d0, d1, xd->scale_factor_uv, 4, 8, which_mv,
|
|
|
|
which_mv ? weight : 0, &xd->subpix,
|
2013-04-15 18:31:27 +02:00
|
|
|
mb_row * 8 + y, mb_col * 8 + x);
|
2012-07-14 00:21:29 +02:00
|
|
|
}
|
|
|
|
}
|
2011-04-28 16:53:59 +02:00
|
|
|
}
|
|
|
|
|
2013-03-27 22:35:36 +01:00
|
|
|
static INLINE int round_mv_comp(int value) {
|
|
|
|
return (value < 0 ? value - 4 : value + 4) / 8;
|
2013-03-02 02:50:55 +01:00
|
|
|
}
|
|
|
|
|
2013-03-27 22:35:36 +01:00
|
|
|
static int mi_mv_pred_row(MACROBLOCKD *mb, int off, int idx) {
|
|
|
|
const int temp = mb->mode_info_context->bmi[off + 0].as_mv[idx].as_mv.row +
|
|
|
|
mb->mode_info_context->bmi[off + 1].as_mv[idx].as_mv.row +
|
|
|
|
mb->mode_info_context->bmi[off + 4].as_mv[idx].as_mv.row +
|
|
|
|
mb->mode_info_context->bmi[off + 5].as_mv[idx].as_mv.row;
|
2013-04-05 21:50:19 +02:00
|
|
|
return round_mv_comp(temp);
|
2013-03-02 02:50:55 +01:00
|
|
|
}
|
|
|
|
|
2013-03-27 22:35:36 +01:00
|
|
|
static int mi_mv_pred_col(MACROBLOCKD *mb, int off, int idx) {
|
|
|
|
const int temp = mb->mode_info_context->bmi[off + 0].as_mv[idx].as_mv.col +
|
|
|
|
mb->mode_info_context->bmi[off + 1].as_mv[idx].as_mv.col +
|
|
|
|
mb->mode_info_context->bmi[off + 4].as_mv[idx].as_mv.col +
|
|
|
|
mb->mode_info_context->bmi[off + 5].as_mv[idx].as_mv.col;
|
2013-04-05 21:50:19 +02:00
|
|
|
return round_mv_comp(temp);
|
2013-03-27 22:35:36 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static int b_mv_pred_row(MACROBLOCKD *mb, int off, int idx) {
|
|
|
|
BLOCKD *const blockd = mb->block;
|
|
|
|
const int temp = blockd[off + 0].bmi.as_mv[idx].as_mv.row +
|
|
|
|
blockd[off + 1].bmi.as_mv[idx].as_mv.row +
|
|
|
|
blockd[off + 4].bmi.as_mv[idx].as_mv.row +
|
|
|
|
blockd[off + 5].bmi.as_mv[idx].as_mv.row;
|
2013-04-05 21:50:19 +02:00
|
|
|
return round_mv_comp(temp);
|
2013-03-27 22:35:36 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static int b_mv_pred_col(MACROBLOCKD *mb, int off, int idx) {
|
|
|
|
BLOCKD *const blockd = mb->block;
|
|
|
|
const int temp = blockd[off + 0].bmi.as_mv[idx].as_mv.col +
|
|
|
|
blockd[off + 1].bmi.as_mv[idx].as_mv.col +
|
|
|
|
blockd[off + 4].bmi.as_mv[idx].as_mv.col +
|
|
|
|
blockd[off + 5].bmi.as_mv[idx].as_mv.col;
|
2013-04-05 21:50:19 +02:00
|
|
|
return round_mv_comp(temp);
|
2013-03-27 22:35:36 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2013-03-02 02:50:55 +01:00
|
|
|
static void build_4x4uvmvs(MACROBLOCKD *xd) {
|
2012-07-14 00:21:29 +02:00
|
|
|
int i, j;
|
2012-08-14 12:32:29 +02:00
|
|
|
BLOCKD *blockd = xd->block;
|
2012-07-14 00:21:29 +02:00
|
|
|
|
|
|
|
for (i = 0; i < 2; i++) {
|
|
|
|
for (j = 0; j < 2; j++) {
|
2013-03-02 02:50:55 +01:00
|
|
|
const int yoffset = i * 8 + j * 2;
|
|
|
|
const int uoffset = 16 + i * 2 + j;
|
|
|
|
const int voffset = 20 + i * 2 + j;
|
2012-07-14 00:21:29 +02:00
|
|
|
|
2013-03-02 02:50:55 +01:00
|
|
|
MV *u = &blockd[uoffset].bmi.as_mv[0].as_mv;
|
|
|
|
MV *v = &blockd[voffset].bmi.as_mv[0].as_mv;
|
2013-03-27 22:35:36 +01:00
|
|
|
u->row = mi_mv_pred_row(xd, yoffset, 0);
|
|
|
|
u->col = mi_mv_pred_col(xd, yoffset, 0);
|
2012-07-14 00:21:29 +02:00
|
|
|
|
|
|
|
// if (x->mode_info_context->mbmi.need_to_clamp_mvs)
|
2013-03-02 02:50:55 +01:00
|
|
|
clamp_uvmv_to_umv_border(u, xd);
|
2012-07-14 00:21:29 +02:00
|
|
|
|
|
|
|
// if (x->mode_info_context->mbmi.need_to_clamp_mvs)
|
2013-03-02 02:50:55 +01:00
|
|
|
clamp_uvmv_to_umv_border(u, xd);
|
2012-07-14 00:21:29 +02:00
|
|
|
|
2013-03-02 02:50:55 +01:00
|
|
|
v->row = u->row;
|
|
|
|
v->col = u->col;
|
2012-07-14 00:21:29 +02:00
|
|
|
|
2012-11-07 15:50:25 +01:00
|
|
|
if (xd->mode_info_context->mbmi.second_ref_frame > 0) {
|
2013-03-02 02:50:55 +01:00
|
|
|
u = &blockd[uoffset].bmi.as_mv[1].as_mv;
|
|
|
|
v = &blockd[voffset].bmi.as_mv[1].as_mv;
|
2013-03-27 22:35:36 +01:00
|
|
|
u->row = mi_mv_pred_row(xd, yoffset, 1);
|
|
|
|
u->col = mi_mv_pred_col(xd, yoffset, 1);
|
2012-07-14 00:21:29 +02:00
|
|
|
|
2012-08-14 12:32:29 +02:00
|
|
|
// if (mbmi->need_to_clamp_mvs)
|
2013-03-02 02:50:55 +01:00
|
|
|
clamp_uvmv_to_umv_border(u, xd);
|
2012-07-14 00:21:29 +02:00
|
|
|
|
2012-08-14 12:32:29 +02:00
|
|
|
// if (mbmi->need_to_clamp_mvs)
|
2013-03-02 02:50:55 +01:00
|
|
|
clamp_uvmv_to_umv_border(u, xd);
|
2012-07-14 00:21:29 +02:00
|
|
|
|
2013-03-02 02:50:55 +01:00
|
|
|
v->row = u->row;
|
|
|
|
v->col = u->col;
|
2012-07-14 00:21:29 +02:00
|
|
|
}
|
2011-08-24 20:42:26 +02:00
|
|
|
}
|
2012-07-14 00:21:29 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Spatial resamping of ZEROMV predictors
This patch allows coding frames using references of different
resolution, in ZEROMV mode. For compound prediction, either
reference may be scaled.
To test, I use the resize_test and enable WRITE_RECON_BUFFER
in vp9_onyxd_if.c. It's also useful to apply this patch to
test/i420_video_source.h:
--- a/test/i420_video_source.h
+++ b/test/i420_video_source.h
@@ -93,6 +93,7 @@ class I420VideoSource : public VideoSource {
virtual void FillFrame() {
// Read a frame from input_file.
+ if (frame_ != 3)
if (fread(img_->img_data, raw_sz_, 1, input_file_) == 0) {
limit_ = frame_;
}
This forces the frame that the resolution changes on to be coded
with no motion, only scaling, and improves the quality of the
result.
Change-Id: I1ee75d19a437ff801192f767fd02a36bcbd1d496
2013-02-25 05:55:14 +01:00
|
|
|
void vp9_build_inter_predictors_mb(MACROBLOCKD *xd,
|
|
|
|
int mb_row,
|
|
|
|
int mb_col) {
|
2012-08-14 12:32:29 +02:00
|
|
|
if (xd->mode_info_context->mbmi.mode != SPLITMV) {
|
2013-04-15 18:31:27 +02:00
|
|
|
vp9_build_inter_predictors_sb(xd, mb_row, mb_col, BLOCK_SIZE_MB16X16);
|
2012-07-14 00:21:29 +02:00
|
|
|
} else {
|
2012-08-14 12:32:29 +02:00
|
|
|
build_4x4uvmvs(xd);
|
2013-04-15 18:31:27 +02:00
|
|
|
build_inter4x4_predictors_mb(xd, mb_row, mb_col);
|
2012-07-14 00:21:29 +02:00
|
|
|
}
|
2010-05-18 17:58:33 +02:00
|
|
|
}
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
|
|
|
/*encoder only*/
|
|
|
|
void vp9_build_inter4x4_predictors_mbuv(MACROBLOCKD *xd,
|
2013-03-27 22:35:36 +01:00
|
|
|
int mb_row, int mb_col) {
|
|
|
|
int i, j, weight;
|
|
|
|
BLOCKD *const blockd = xd->block;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
|
|
|
/* build uv mvs */
|
|
|
|
for (i = 0; i < 2; i++) {
|
|
|
|
for (j = 0; j < 2; j++) {
|
2013-03-27 22:35:36 +01:00
|
|
|
const int yoffset = i * 8 + j * 2;
|
|
|
|
const int uoffset = 16 + i * 2 + j;
|
|
|
|
const int voffset = 20 + i * 2 + j;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
2013-03-27 22:35:36 +01:00
|
|
|
MV *u = &blockd[uoffset].bmi.as_mv[0].as_mv;
|
|
|
|
MV *v = &blockd[voffset].bmi.as_mv[0].as_mv;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
2013-03-27 22:35:36 +01:00
|
|
|
v->row = u->row = b_mv_pred_row(xd, yoffset, 0);
|
|
|
|
v->col = u->col = b_mv_pred_col(xd, yoffset, 0);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
2013-03-27 22:35:36 +01:00
|
|
|
if (xd->mode_info_context->mbmi.second_ref_frame > 0) {
|
|
|
|
u = &blockd[uoffset].bmi.as_mv[1].as_mv;
|
|
|
|
v = &blockd[voffset].bmi.as_mv[1].as_mv;
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
|
2013-03-27 22:35:36 +01:00
|
|
|
v->row = u->row = b_mv_pred_row(xd, yoffset, 1);
|
2013-04-08 18:16:26 +02:00
|
|
|
v->col = u->col = b_mv_pred_col(xd, yoffset, 1);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#if CONFIG_IMPLICIT_COMPOUNDINTER_WEIGHT && \
|
|
|
|
defined(USE_IMPLICIT_WEIGHT_SPLITMV) && \
|
|
|
|
defined(USE_IMPLICIT_WEIGHT_UV)
|
|
|
|
weight = get_implicit_compoundinter_weight_splitmv(xd, mb_row, mb_col);
|
|
|
|
#else
|
|
|
|
weight = AVERAGE_WEIGHT;
|
|
|
|
#endif
|
|
|
|
for (i = 16; i < 24; i += 2) {
|
|
|
|
const int use_second_ref = xd->mode_info_context->mbmi.second_ref_frame > 0;
|
|
|
|
const int x = 4 * (i & 1);
|
|
|
|
const int y = ((i - 16) >> 1) * 4;
|
|
|
|
|
|
|
|
int which_mv;
|
|
|
|
BLOCKD *d0 = &blockd[i];
|
|
|
|
BLOCKD *d1 = &blockd[i + 1];
|
|
|
|
|
|
|
|
for (which_mv = 0; which_mv < 1 + use_second_ref; ++which_mv) {
|
|
|
|
build_2x1_inter_predictor(d0, d1, xd->scale_factor_uv, 4, 8, which_mv,
|
|
|
|
which_mv ? weight : 0,
|
2013-04-15 18:31:27 +02:00
|
|
|
&xd->subpix, mb_row * 8 + y, mb_col * 8 + x);
|
Implicit weighted prediction experiment
Adds an experiment to use a weighted prediction of two INTER
predictors, where the weight is one of (1/4, 3/4), (3/8, 5/8),
(1/2, 1/2), (5/8, 3/8) or (3/4, 1/4), and is chosen implicitly
based on consistency of the predictors to the already
reconstructed pixels to the top and left of the current macroblock
or superblock.
Currently the weighting is not applied to SPLITMV modes, which
default to the usual (1/2, 1/2) weighting. However the code is in
place controlled by a macro. The same weighting is used for Y and
UV components, where the weight is derived from analyzing the Y
component only.
Results (over compound inter-intra experiment)
derf: +0.18%
yt: +0.34%
hd: +0.49%
stdhd: +0.23%
The experiment suggests bigger benefit for explicitly signaled weights.
Change-Id: I5438539ff4485c5752874cd1eb078ff14bf5235a
2013-03-12 22:21:08 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|