Merge pull request #433 from siemens/numparser

NumberParser::parseUnsigned should not parse negative numbers

Foundation/include/Poco/NumericString.h

@@ -110,6 +110,8 @@ bool strToInt(const char* pStr, I& result, short base, char thSep = ',')
 	char sign = 1;
 	if ((base == 10) && (*pStr == '-'))
 	{
+		// Unsigned types can't be negative so abort parsing
+		if (std::numeric_limits<I>::min() >= 0) return false;
 		sign = -1;
 		++pStr;
 	}

Foundation/testsuite/src/NumberParserTest.cpp

@@ -272,6 +272,12 @@ void NumberParserTest::testParseError()
 		failmsg("must throw SyntaxException");
 	} catch (SyntaxException&) { }
 
+	try
+	{
+		NumberParser::parseUnsigned("-123");
+		failmsg("must throw SyntaxException");
+	} catch (SyntaxException&) { }
+
 	try
 	{
 		NumberParser::parseHex("z23");