generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-10-17 03:03:23 +02:00
Code Issues Projects Releases Wiki Activity

Fixed integer overflow in sessionimpl.cpp (#1803) (#1820)

Browse Source 
* Fix integer overflow in sessionimpl.cpp

* Modify document of setConnectionTimeout

Add discription of exception.
This commit is contained in:
Yasuhiro Horimoto
2017-07-20 22:25:22 +09:00
committed by Aleksandar Fabijanic
parent 40324cdcc0
commit a767d55a81
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Data/SQLite/include/Poco/Data/SQLite/SessionImpl.h
View File

@@ -75,6 +75,7 @@ public:
void setConnectionTimeout(std::size_t timeout);
/// Sets the session connection timeout value.
/// Throws RangeException if the timeout value is overflow.
std::size_t getConnectionTimeout();
/// Returns the session connection timeout value.

16
Data/SQLite/src/SessionImpl.cpp
View File

@@ -223,10 +223,18 @@ bool SessionImpl::isConnected()
void SessionImpl::setConnectionTimeout(std::size_t timeout)
{
int tout = 1000 * timeout;
int rc = sqlite3_busy_timeout(_pDB, tout);
if (rc != 0) Utility::throwException(rc);
_timeout = tout;
if(timeout >= 0 && (timeout <= INT_MAX/1000))
{
int tout = 1000 * timeout;
int rc = sqlite3_busy_timeout(_pDB, tout);
if (rc != 0) Utility::throwException(rc);
_timeout = tout;
}
else
{
throw RangeException
("Occurred integer overflow because of timeout value.");
}
}