generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

DH key generation should not use a do ... while loop,

Browse Source 
or bogus DH parameters can be used for launching DOS attacks
This commit is contained in:
Bodo Möller 2001-07-25 17:48:51 +00:00
parent 6aecef815c
commit e5cb260365
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crypto/dh/dh_key.c
View File

@ -135,13 +135,9 @@ static int generate_key(DH *dh)
l = dh->length ? dh->length : BN_num_bits(dh->p)-1; /* secret exponent length */
do
{
if (!BN_rand(priv_key, l, 0, 0)) goto err;
if (!ENGINE_get_DH(dh->engine)->bn_mod_exp(dh, pub_key, dh->g,
priv_key,dh->p,ctx,mont)) goto err;
}
while (BN_is_one(priv_key));
if (!BN_rand(priv_key, l, 0, 0)) goto err;
if (!ENGINE_get_DH(dh->engine)->bn_mod_exp(dh, pub_key, dh->g,
priv_key,dh->p,ctx,mont)) goto err;
dh->pub_key=pub_key;
dh->priv_key=priv_key;