generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

In {RSA,DSA,DH}_new_method(x) need to increase the reference

Browse Source 
count of the ENGINE is x is not NULL since it will be freed
in {RSA,DSA,DH}_free().
This commit is contained in:
Dr. Stephen Henson 2001-06-23 23:07:34 +00:00
parent f13def508c
commit 0c9de428ae
3 changed files with 44 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
crypto/dh/dh_lib.c
View File

@ -142,16 +142,21 @@ DH *DH_new_method(ENGINE *engine)
DHerr(DH_F_DH_NEW,ERR_R_MALLOC_FAILURE);
return(NULL);
}
if(engine)
ret->engine = engine;
else
if (engine)
{
if((ret->engine=ENGINE_get_default_DH()) == NULL)
{
DHerr(DH_F_DH_NEW,ERR_LIB_ENGINE);
OPENSSL_free(ret);
return NULL;
}
if(ENGINE_init(engine))
ret->engine = engine;
else
ret->engine = NULL;
}
else
ret->engine=ENGINE_get_default_DH();
if(ret->engine == NULL)
{
DHerr(DH_F_DH_NEW,ERR_LIB_ENGINE);
OPENSSL_free(ret);
return NULL;
}
meth = ENGINE_get_DH(ret->engine);
ret->pad=0;

25
crypto/dsa/dsa_lib.c
View File

@ -146,17 +146,24 @@ DSA *DSA_new_method(ENGINE *engine)
DSAerr(DSA_F_DSA_NEW,ERR_R_MALLOC_FAILURE);
return(NULL);
}
if(engine)
ret->engine = engine;
else
if (engine)
{
if((ret->engine=ENGINE_get_default_DSA()) == NULL)
{
DSAerr(DSA_F_DSA_NEW,ERR_LIB_ENGINE);
OPENSSL_free(ret);
return NULL;
}
if(ENGINE_init(engine))
ret->engine = engine;
else
ret->engine = NULL;
}
else
ret->engine=ENGINE_get_default_DSA();
if(ret->engine == NULL)
{
DSAerr(DSA_F_DSA_NEW,ERR_LIB_ENGINE);
OPENSSL_free(ret);
return NULL;
}
meth = ENGINE_get_DSA(ret->engine);
ret->pad=0;
ret->version=0;

22
crypto/rsa/rsa_lib.c
View File

@ -162,17 +162,23 @@ RSA *RSA_new_method(ENGINE *engine)
return(NULL);
}
if (engine == NULL)
if (engine)
{
if((ret->engine=ENGINE_get_default_RSA()) == NULL)
{
RSAerr(RSA_F_RSA_NEW_METHOD,ERR_LIB_ENGINE);
OPENSSL_free(ret);
return NULL;
}
if(ENGINE_init(engine))
ret->engine = engine;
else
ret->engine = NULL;
}
else
ret->engine=engine;
ret->engine=ENGINE_get_default_RSA();
if(ret->engine == NULL)
{
RSAerr(RSA_F_RSA_NEW_METHOD,ERR_LIB_ENGINE);
OPENSSL_free(ret);
return NULL;
}
meth = ENGINE_get_RSA(ret->engine);
ret->pad=0;