Commit Graph

4853 Commits

Author SHA1 Message Date
Luca Boccassi
f8c93d508f Merge pull request #1983 from hitstergtd/x-unused-thread
Problem: scheduling parameters unused on OSX
2016-05-12 16:53:22 +01:00
hitstergtd
e946b0d1a6 Problem: scheduling parameters unused on OSX
Solution:
Mark them with LIBZMQ_UNUSED macro as per convention; although in future the
appropriate pthread code should be updated to support thread scheduling
priorities (for Mac OS X, et. al.)
2016-05-12 16:36:59 +01:00
Hitster GTD
29c8e30fc0 Merge pull request #1982 from Hugne/bug_1968
tipc: add support for address domain suffix
2016-05-11 21:17:23 +01:00
Erik Hugne
f81ef1bc72 tipc: add support for address domain suffix
The TIPC protocol bindings in ZeroMQ defaults to a lookup domain
of 1.0.0 to prevent 'closest first' search, and instead always
do round robin if several sockets in the network or node have
the same name published. In retrospect, this might have been a
bad idea because it won't work on standalone configurations.
We solve this by allowing an optional domain suffix to be provided
in the address, and 0.0.0 should be used in that case, or if the
TIPC address range in the cluster configuration is defined to some
other value. Domain suffixes are only relevant for connecting
addresses.

Signed-off-by: Erik Hugne <erik.hugne@gmail.com>
2016-05-11 21:54:25 +02:00
Luca Boccassi
4ad68e0dfe Merge pull request #1981 from hitstergtd/x-unused-req
Problem: hint parameter throws unused warning
2016-05-11 15:57:12 +01:00
Luca Boccassi
10a84ac8b1 Merge pull request #1979 from dmillard/patch-1
Fix autotools for static MinGW builds
2016-05-10 22:11:59 +01:00
David Millard
9e6745c12e Fix autotools for static MinGW builds 2016-05-10 13:53:53 -07:00
Luca Boccassi
c7ecbedb0e Merge pull request #1977 from hitstergtd/x-unused-variables
Problem: sockfd_ parameter throws unused warning
2016-05-10 18:43:22 +01:00
hitstergtd
5efa11828c Problem: hint parameter throws unused warning
Solution:
Mark it with LIBZMQ_UNUSED macro as per convention.
2016-05-10 18:22:15 +01:00
hitstergtd
545e8e848e Problem: sockfd_ parameter throws unused warning
Solution:
Mark it with LIBZMQ_UNUSED as per our convention.
2016-05-10 18:12:44 +01:00
Luca Boccassi
dc7296537c Merge pull request #1976 from zeromq/revert-1975-master
Revert "problem:Socket try to access closed mutex"
2016-05-10 14:31:57 +01:00
Doron Somech
c41d514b8b Revert "problem:Socket try to access closed mutex" 2016-05-10 16:23:29 +03:00
Constantin Rack
f6ce1d764c Merge pull request #1975 from somdoron/master 2016-05-10 13:00:31 +02:00
Doron Somech
77d3d7b4dc problem:Socket try to access closed mutex 2016-05-10 13:49:57 +03:00
Luca Boccassi
a6e8d153cb Merge pull request #1974 from hitstergtd/master
Problem: style/typo issue
2016-05-09 14:59:19 +01:00
hitstergtd
8fc985a9b0 Problem: style/typo issue
Solution:
Fix it.
2016-05-09 14:24:12 +01:00
Luca Boccassi
a4a247cf57 Merge pull request #1973 from hitstergtd/x-fix-m4-llvm-gcov-coverage
Problem: Coverage option broken with LLVM GCOV Frontend
2016-05-09 14:10:50 +01:00
Constantin Rack
3eef0a7ba8 Merge pull request #1972 from hitstergtd/x-stylefix-udpengine
Problem: UDP engine code not indented properly [style]
2016-05-09 14:30:31 +02:00
hitstergtd
415af27395 Problem: Coverage option broken with LLVM GCOV
Solution:
This is an issue with the imported Autoconf M4 macro package for standardised
code coverage builds, i.e. using --enable-code-coverage.

The simplest way that I could find is to add a case statement that checks if
the output of running `gcov -version` contains the "LLVM" keyword; if that is
true then do not link with LIBGCOV as its neither required nor supported when
using the GCOV frontend for LLVM; least not on Mac OS X. The case statement
would also be the most portable.

Moreover, using the "-version" argument instead of "-v" seems to be the best
bet as that is supported by the normal GCOV and LLVM GCOV frontend.

Upstream candidate - this solution should be improved by Autoconf M4 macro
overlords and applied to the upstream M4 package; I could not find a suitable
way to detect if LLVM GCOV is being used, except for the solution herein; this
should also work on *BSD too.
2016-05-09 13:27:41 +01:00
Luca Boccassi
1f309d3a3d Merge pull request #1971 from sappo/master
Problem: Deploying release artifacts to github is a manual process
2016-05-09 10:15:13 +01:00
Kevin Sapper
b22558119d Problem: Deploying release artifacts is a manual process
Solution: Use travis to deploy these artifacts automatically.

The deployment is triggered by tagging on the zeromq/libzmq repository.
Of the many builds travis is checking only the default one with
libsodium and drafts disabled is used for deployment.

For now the results of `make distcheck` are deployed as well as their
md5 and sha1 hash sums. Further changes may upload a generated
Changelog as well.
2016-05-09 10:30:13 +02:00
Luca Boccassi
c4ce6d9b1b Merge pull request #1970 from hitstergtd/x-add-ancillary-tests
Problem: Not all ancillary API methods tested
2016-05-08 18:36:03 +01:00
hitstergtd
124ebd2dd6 Problem: UDP engine code not indented properly
Solution:
Indent it.
2016-05-08 18:30:17 +01:00
hitstergtd
206771afd2 Problem: Not all ancillary API methods tested
Solution:
- Add file for testing ancillary API methods and any misc internal machinery
- Add tests for zmq_version(3) and zmq_strerror(3)
- Add test file into gitignore, Autotools and CMake build files
- Increase test coverage

Note:
MSVC solution files have not been updated.
2016-05-08 18:25:03 +01:00
Constantin Rack
d6aa6e71ec Merge pull request #1969 from pijyoi/fix_invalidsocket
problem: sockets are not signed int on Windows
2016-05-08 10:40:14 +02:00
KIU Shueng Chuan
bb4bcf8f45 fix: sockets are not signed int on Windows 2016-05-08 16:29:15 +08:00
Doron Somech
f88d129b50 Merge pull request #1966 from bluca/backtrace_assert
Problem: no backtrace is printed on assert
2016-05-06 23:45:47 +03:00
Luca Boccassi
bb5037e855 Problem: leftover commented out line in configure
Solution: clean up and remove it
2016-05-06 21:34:43 +01:00
Luca Boccassi
8045e9ae24 Problem: no backtrace is printed on assert
Solution: add an optional dependency on libunwind, and if present
use it to print the backtrace when zmq_abort is called.
2016-05-06 21:34:25 +01:00
Luca Boccassi
c1dc9d0244 Merge pull request #1967 from hitstergtd/x-add-militant-option
Problem: No CMake option to set ZMQ_ACT_MILITANT
2016-05-06 21:05:40 +01:00
hitstergtd
6ea9dbc9ce Problem: No CMake option to set ZMQ_ACT_MILITANT
Solution:
Add CMake option called WITH_MILITANT so that it aligns with the Autotools
build infrastructure; enabling this option defines ZMQ_ACT_MILITANT, which
enables assertions should malformed requests make their way into
zmq_setsockopt(3) or zmq_getsockopt(3).
2016-05-06 20:57:54 +01:00
Doron Somech
f98b5bb5cf Merge pull request #1964 from bluca/sock_close_read_after_free
Problem: read-after-free when closing socket
2016-05-05 23:33:04 +03:00
Luca Boccassi
17132f0387 Problem: read-after-free when closing socket
Solution: use socket object's mutex before the send_reap() call that
might deallocate it
2016-05-05 17:47:16 +01:00
Constantin Rack
e9380b5a1a Merge pull request #1962 from somdoron/master
problem: timers test is flapping on windows
2016-05-05 13:47:44 +02:00
Doron Somech
be741f604a problem: timers test is flapping on windows 2016-05-05 14:24:47 +03:00
Constantin Rack
5dadded0a1 Merge pull request #1961 from somdoron/Signaler
problem: closed poller still associated with socket
2016-05-05 12:57:24 +02:00
Doron Somech
a747f72450 problem:closed poller still associated with socket 2016-05-05 13:50:33 +03:00
Luca Boccassi
fb75b201c3 Merge pull request #1960 from hitstergtd/x-sort-AUTHORS
Problem: AUTHORS file is not sorted
2016-05-05 11:02:41 +01:00
Doron Somech
001ddd80cc Merge pull request #1958 from hitstergtd/x-deprecate-zmq-sendrecviov-fix
Problem: zmq_sendiov/zmq_recviov not Deprecated
2016-05-04 19:14:38 +03:00
KAPP Arnaud
a46d7b994f Merge pull request #1959 from hitstergtd/x-zmqpoll-fix
Problem: style issues with comment in zmq_poll
2016-05-04 17:55:55 +02:00
hitstergtd
b3bb0b7f1c Problem: zmq_sendiov/zmq_recviov not Deprecated
Solution:
As preparation for 4.2 release, move the zmq_sendiov and zmq_recviov API
methods under the Deprecated Methods section.

Note: the actual methods have NOT been deprecated yet, functionally speaking
however it is good to let API users know early. Moreover, these methods were
not ever considered stable, at least according to src/zmq.h, and have no
associated man pages.
2016-05-04 16:48:10 +01:00
hitstergtd
109122dd46 Problem: style issues with comment in zmq_poll
Solution:
Wrap and clean it.
2016-05-04 16:24:51 +01:00
Luca Boccassi
c33e96f2d2 Merge pull request #1957 from hitstergtd/x-TIPC-CMake-fix
Problem: ZMQ_HAVE_TIPC option for CMake is broken
2016-05-04 16:18:26 +01:00
hitstergtd
b470ed451f Problem: ZMQ_HAVE_TIPC option for CMake is broken
Solution:
Fix it - there was a typo in the source list variable; it should be
'cpp-sources' and not 'cpp-source'.
2016-05-04 16:15:28 +01:00
Luca Boccassi
00d7ee1646 Merge pull request #1956 from hitstergtd/x-addto-AUTHORS-file
Problem: Not shamelessly plugged into AUTHORS
2016-05-04 16:12:59 +01:00
Luca Boccassi
ad82bd1b1a Merge pull request #1955 from hitstergtd/x-remove-MAINTAINERS-file
Problem: MAINTAINERS file has no purpose anymore
2016-05-04 16:08:13 +01:00
hitstergtd
6ae2ff6446 Problem: MAINTAINERS file has no purpose anymore
Solution:
Remove until such time that a new and appropriate file can replace it should
it be deemed necessary.
2016-05-04 16:06:33 +01:00
Luca Boccassi
745e07d93c Merge pull request #1954 from somdoron/master
problem: compilation error on osx
2016-05-04 14:15:08 +01:00
Doron Somech
e15da4b38c problem: compilation error on osx 2016-05-04 16:09:31 +03:00
Luca Boccassi
feec47604f Merge pull request #1953 from somdoron/master
problem: src is broken and unneeded as we have metadata
2016-05-04 13:35:19 +01:00