generic-library/libzmq
1
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2024-12-13 18:55:10 +01:00
Code Issues Projects Releases Wiki Activity
6,615 Commits 4 Branches 39 Tags 40 MiB
abca9f6bc1
Commit Graph

6615 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Simon Giesecke
abca9f6bc1 Problem: Magic numbers in plain_server.cpp 
Solution: introduced constants
 2018-05-28 17:53:44 +02:00
Simon Giesecke
2da6629e0f Problem: Magic numbers "1" and "100" in signaler.cpp 
Solution: introduced constants, use std::min/std::max instead of control structures
 2018-05-28 17:53:43 +02:00
Simon Giesecke
a6060674b4 Problem: Magic numbers "32" and "128" in tcp_address.cpp 
Solution: introduced constants
 2018-05-28 17:53:43 +02:00
Simon Giesecke
93e75fd695 Problem: Magic numbers "6" and "7" in null_mechanism.cpp 
Solution: introduced constants
 2018-05-28 17:53:42 +02:00
Simon Giesecke
c05db7f025 Problem: Magic numbers "1" and "6" in null_mechanism.cpp 
Solution: introduced constants
 2018-05-28 17:53:42 +02:00
Simon Giesecke
ff27dd01f0 Problem: Magic numbers "1" and "4" in mechanism.cpp 
Solution: introduced constants
 2018-05-28 17:53:42 +02:00
Simon Giesecke
7c9d058cdb Problem: Magic number "2" in ip_resolver.cpp 
Solution: introduced constant
 2018-05-28 17:53:41 +02:00
Simon Giesecke
16bb62e6f7 Problem: ctx_t::_slots is a plain array 
Solution: use a std::vector instead
 2018-05-28 17:53:41 +02:00
Simon Giesecke
a0a60e80ca Problem: Magic number "2" in ctx.cpp 
Solution: introduced constant
 2018-05-28 17:53:40 +02:00
Simon Giesecke
bbc903884f
Merge pull request #3140 from bluca/clang_tautological 
Problem: build broken with clang 6 on Android NDK 17
 2018-05-28 15:30:42 +02:00
Luca Boccassi
58d13395ec Problem: clang 6 warns about comparisons on 64 bit 
Solution: ignore tautological-constant-compare warnings, as they
might be useless on 64 bit but they are not on 32 bit where sizeof
size_t != sizeof uint64_t
 2018-05-28 14:06:41 +01:00
Luca Boccassi
624c142365 Problem: static analysis warning about ifdef typo 
Solution: fix it
 2018-05-28 12:32:23 +01:00
Luca Boccassi
2d1bb07f8d
Merge pull request #3139 from sigiesec/style-improvements 
Code style improvements
 2018-05-27 15:44:27 +01:00
Simon Giesecke
779d120fa3 Problem: tests do not follow naming style 
Solution: apply naming style
 2018-05-27 13:24:08 +02:00
Simon Giesecke
d767909b50 Problem: old C-style casts used 
Solution: replace by static_cast/reinterpret_cast
 2018-05-27 13:24:07 +02:00
Simon Giesecke
e3c73d9881 Problem: inconsistent naming style for private data members, conflicts with naming of local variables and member functions 
Solution: apply and check _lower_case naming style for private data members
 2018-05-27 13:24:07 +02:00
Simon Giesecke
06cfd0d8ad Problem: unclear why QueryPerformanceFrequency is called for every call of QueryPerformanceCounter 
Solution: add a comment
 2018-05-27 13:24:07 +02:00
Simon Giesecke
97ba02bc2f Problem: redundant empty dtor 
Solution: removed
 2018-05-27 13:24:06 +02:00
Simon Giesecke
6ef67f13e3 Problem: use of C-style casts and magic literals 
Solution: replace by static_cast, and introduce appropriate constants
 2018-05-27 13:24:06 +02:00
Luca Boccassi
089746959d
Merge pull request #3137 from sigiesec/disable-parallel-testing 
Problem: VS2008/2010/2017 tests fail if run in parallel
 2018-05-26 19:19:48 +01:00
Simon Giesecke
0c74e8a0ad Problem: cmake install is not tested 
Solution: run cmake --build --target install instead of msbuild to build on appveyor
 2018-05-26 18:56:00 +02:00
Simon Giesecke
a1efc68516 Problem: appveyor CI takes a long time 
Solution: run some builds only on master or *full-ci* branches
 2018-05-26 18:56:00 +02:00
Simon Giesecke
33ba7e14b3 Problem: VS2008/2010/2017 tests fail if run in parallel 
Solution: disabled parallel testing for these VS versions
 2018-05-26 18:56:00 +02:00
Luca Boccassi
fae88633d7
Merge pull request #3138 from sigiesec/fix-various-style-issues 
Fix various code style issues
 2018-05-26 12:08:12 +01:00
Simon Giesecke
37344d0b7c Problem: redundant old-style void argument declarations 
Solution: remove
 2018-05-26 09:34:45 +02:00
Simon Giesecke
12a97bb769 Problem: redundant else after return 
Solution: remove else
 2018-05-26 09:34:45 +02:00
Simon Giesecke
21498700ef Problem: integer literals assigned to bool variables 
Solution: replace by bool literals
 2018-05-26 09:34:45 +02:00
Simon Giesecke
eacc805646 Problem: complex unnecessary ternary expressions 
Solution: simplify to comparison against 0
 2018-05-26 09:34:44 +02:00
Simon Giesecke
1432011277 Problem: inconsistent local variable naming 
Solution: configured clang-tidy check and applied fixes
 2018-05-26 09:34:44 +02:00
Simon Giesecke
c581f43c97 Problem: parameter naming style inconsistent 
Solution: define and apply parameter naming style: lower_case_
 2018-05-26 09:34:44 +02:00
Luca Boccassi
79d5ac3dee
Merge pull request #3135 from sigiesec/fix-heartbeat-ttl-max 
Fix ZMQ_HEARTBEAT_TTL maximum value check
 2018-05-25 15:57:45 +01:00
Simon Giesecke
763760988f Problem: VS2008 has no definition of UINT16_MAX 
Solution: provide definition based on _UI16_MAX
 2018-05-25 15:13:07 +02:00
Simon Giesecke
8b030a9256 Problem: no tests for corner cases of setsockopt ZMQ_HEARTBEAT_TTL 
Solution: added tests
 2018-05-25 15:13:07 +02:00
Simon Giesecke
d90e70c1cf Problem: maximum allowed value for ZMQ_HEARTBEAT_TTL is wrong 
Solution: use UINT16_MAX
 2018-05-25 15:06:11 +02:00
Luca Boccassi
50374bf6f5
Merge pull request #3134 from sigiesec/fix-sonarcloud-component-name 
Fix sonarcloud component name
 2018-05-24 17:05:24 +01:00
Simon Giesecke
b791645a49 Problem: project key is not unique across organizations 
Solution: prefix project key with repo name
 2018-05-24 18:04:43 +02:00
Luca Boccassi
f0f029c549
Merge pull request #3132 from sigiesec/add-vs2008-vs2010-ci 
Add CI for VS2008 and VS2010 and fix their builds
 2018-05-24 17:02:57 +01:00
Simon Giesecke
653c2073de
Merge pull request #3133 from bluca/sonarqube_token 
Problem: missing sonarqube token
 2018-05-24 17:08:34 +02:00
Luca Boccassi
cf41aed29d Problem: missing sonarqube token 
Solution: add it
 2018-05-24 16:06:08 +01:00
Luca Boccassi
1644d162fb
Merge pull request #3115 from sigiesec/analyze 
Add static analysis
 2018-05-24 16:04:31 +01:00
Simon Giesecke
6afa1cee3a Problem: travis-ci analysis build is always run 
Solution: configure to run only on scheduled runs or on specifically named branches
 2018-05-24 16:15:58 +02:00
Simon Giesecke
51fd4b6a9d Problem: analysis build on PR virtual merges 
Solution: skip analysis build in install stage
 2018-05-24 16:15:57 +02:00
Simon Giesecke
100745d312 Problem: appveyor analysis runs on all branches 
Solution: restrict to specific branches
 2018-05-24 16:15:57 +02:00
Simon Giesecke
51d4b00196 Problem: no clang-tidy configuration 
Solution: add initial .clang-tidy config file
 2018-05-24 16:15:30 +02:00
Simon Giesecke
7b686900f9 Problem: VS2008 build fails due to unavailable stdint.h 
Solution: specify not to use stdint.h for VS<=2008, fixes #3025
 2018-05-24 15:56:08 +02:00
Simon Giesecke
1e89a51734 Problem: broken indentation 
Solution: fix indentation
 2018-05-24 15:56:08 +02:00
Simon Giesecke
2ae0c4e2c5 Problem: unnecessarily complex inheritance hierarchy in decoders, warning C4355 with VS2010 
Solution: make allocator a member of decoder_base_t
 2018-05-24 15:17:08 +02:00
Simon Giesecke
d96a030125 Problem: no CI builds for VS2008/VS2010 
Solution: add to appveyor jobs
 2018-05-24 15:17:04 +02:00
Simon Giesecke
4d3516f634 Problem: no static analysis under Linux 
Solution: activate clang-tidy, scan-build and sonar-scanner
 2018-05-24 13:44:46 +02:00
Simon Giesecke
2b31e50b01 Problem: No static analysis under Windows 
Solution: Enable VS static analyzer and core guideline checks
 2018-05-24 13:44:45 +02:00