generic-library/libzmq
1
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-01-19 16:56:11 +01:00
Code Issues Projects Releases Wiki Activity
5,908 Commits 4 Branches 39 Tags
Commit Graph

5908 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
sigiesec
9a336622fb Problem: no tests for socket-related functions passing NULL as socket 
Soluton: added tests
 2017-08-22 16:22:38 +02:00
Luca Boccassi
1881735f7d Merge pull request #2710 from sigiesec/remove-select-rm_fd-code-duplication 
Problem: code duplication within zmq::select_t::rm_fd
 2017-08-21 17:05:39 +01:00
sigiesec
c3c2515542 Problem: code duplication within zmq::select_t::rm_fd 
Solution: extract find_fd_entry_by_handle from rm_fd
 2017-08-21 14:36:50 +02:00
Jim Klimov
ee7f5b9b97 Merge pull request #2708 from bluca/obs_flair 
Problem: packages builds not mentioned in README.md
 2017-08-21 14:32:18 +02:00
Luca Boccassi
c2ce55aaa4 Merge pull request #2707 from sigiesec/test-monitor-diagnostics 
Problem: test_monitor fails sometimes due to a wrong event received but unclear which one
 2017-08-21 12:25:10 +01:00
Luca Boccassi
7cd890a8bc Problem: packages builds not mentioned in README.md 
Solution: add brief description and links
 2017-08-21 11:51:16 +01:00
Simon Giesecke
0aef54421d Problem: test_monitor is disabled on Windows 
Solution: enable test
 2017-08-21 12:20:37 +02:00
Simon Giesecke
82227136ea Problem: test_monitor sometimes fails due to a wrong event received, but not known which 
Solution: add diagnostic output
 2017-08-21 12:20:36 +02:00
Luca Boccassi
5e85fa6a39 Merge pull request #2698 from sigiesec/client-side-auth-error-events 
Problem: no tests for client-side events for successful handshake and authentication failure in handshake
 2017-08-20 22:42:51 +01:00
Simon Giesecke
74203729bd Problem: test_zap_unsuccessful_status_500 and test_curve_security_with_bogus_client_credentials sometimes fail, particulary on slow/valgrind runs 
Solutio: relax test assertion
 2017-08-20 22:47:15 +02:00
sigiesec
bd0675b93f Problem: no tests for client-side events for successful handshake and authentication failure in handshake 
Solution: added tests for CURVE, add emitting of client-side event in curve_client_t; add ZAP code 300/500 tests for all mechanisms; suppress sending an error message for ZAP code 300
 2017-08-20 22:45:14 +02:00
Constantin Rack
7481fba561 Merge pull request #2706 from bluca/gssapi_test_monitor 
Problem: test_security_gssapi expects wrong event
 2017-08-20 13:09:50 +02:00
Luca Boccassi
b239d99a2c Problem: test_security_gssapi does not close messages 
Solution: do it to avoid leaks. Even though they are below 33 bytes so
it's all allocated on the stack, the small message size might change in
the future.
 2017-08-20 11:54:49 +01:00
Luca Boccassi
cd09065c8a Problem: test_security_gssapi expects wrong event 
Solution: fix it
 2017-08-20 11:54:13 +01:00
Luca Boccassi
72b517b309 Merge pull request #2704 from sigiesec/fix-test-sockopt-hwm 
Problem: test_sockopt_hwm fails occasionally
 2017-08-20 11:40:05 +01:00
Simon Giesecke
00c6962516 Problem: test failing due to too few messages sent relative to SNDHWM 
Solution: relaxed assertion to accept 10% of the SNDHWM, and updated documentation accordingly
 2017-08-20 11:51:09 +02:00
sigiesec
4c2acdacca Problem: wrong assumption on behavior of ZMQ_SNDHWM in test_sockopt_hwm.cpp 
Solution: align assertions with specification of ZMQ_SNDHWM (actual number of enqueueable messages may be lower)
 2017-08-20 11:43:13 +02:00
Constantin Rack
7283574cee Merge pull request #2703 from bluca/rpm_la 
Problem: RPM -devel still ships libzmq.la
 2017-08-20 07:33:08 +02:00
Luca Boccassi
cfc3c7a66b Problem: spec changelog out of date 
Solution: mention recent changes
 2017-08-19 22:04:31 +01:00
Luca Boccassi
b3acae89e2 Problem: RPM -devel still ships libzmq.la 
Solution: don't. libtool's archive files are already being deprecated
in Debian-based distros. They are no longer necessary, and cause the
reverse dependencies to over-link.
EG: when built with sodium/pgm/krb5, all applications/libraries
linking against libzmq would be forced to link against sodium/pgm/krb5
despite not using any of those libraries symbols.
 2017-08-19 22:04:31 +01:00
Constantin Rack
13f3ab988a Merge pull request #2702 from bluca/test 
Problems: GSSAPI builds broken with picky compilers, Debian/RPM packages do not use GSSAPI, no CI jobs that test GSSAPI
 2017-08-19 19:58:09 +02:00
Luca Boccassi
68ba6d17be Problem: Travis does not test PGM 
Solution: enable option and install build-dependency for the jobs that
already install packages only, to minimise marginal cost in term of
runtime
 2017-08-19 17:54:42 +01:00
Luca Boccassi
f979ed4f35 Problem: Travis does not test GSSAPI 
Solution: enable option and install build-dependency for the jobs that
already install packages only, to minimise marginal cost in term of
runtime
 2017-08-19 17:53:57 +01:00
Luca Boccassi
8896b672c4 Problem: RPM build does not pass correct configure options 
Solution: fix it
 2017-08-19 17:40:15 +01:00
Luca Boccassi
962630fd65 Problem: Debian package not built with GSSAPI 
Solution: add build-dependency and configure option
 2017-08-19 17:40:15 +01:00
Luca Boccassi
f6ce019fff Problem: incompatible parameter passed to send_zap_request 
Solution: cast from void* to uint8_t* to match new definition
 2017-08-19 17:40:15 +01:00
Luca Boccassi
7c85bf2f88 Problem: uninitialised variables in gssapi_server constructor 
Solution: initialise session and peer_address
 2017-08-19 17:40:15 +01:00
Luca Boccassi
2ba0149ee4 Problem: gssapi_mechanism_base_t initialisation misses one param 
Solution: pass the session as well as the options
 2017-08-19 17:40:15 +01:00
Luca Boccassi
83c9c0b55f Problem: gssapi_client does not have a peer_address param 
Solution: remove it from the gssapi_mechanism_base initialiser
 2017-08-19 17:40:15 +01:00
Luca Boccassi
24b2f61b1b Problem: gssapi_server out of date with zap_client 
Solution: remove local unused zap_client variable
 2017-08-19 17:40:15 +01:00
Luca Boccassi
c8097af884 Problem: DRAFT GSSAPI socket options in wrong section cause duplication 
Solution: move them together with the other DRAFT socket options, and
change value of DRAFT ZMQ_BINDTODEVICE from 90 to 92 to avoid clash
 2017-08-19 17:40:15 +01:00
Luca Boccassi
6f49e40e36 Problem: gssapi_mechanism_base does not include mechanism_base 
Solution: include mechanism_base.hpp instead of mechanism.hpp
 2017-08-19 17:40:15 +01:00
Luca Boccassi
e2ffa2a77b Problem: produce_ready in gssapi_mechanism_base not deduped 
Solution: call make_command_with_basic_properties
 2017-08-19 17:40:15 +01:00
Doron Somech
2c8a1315c1 Merge pull request #2700 from bluca/gssapi_uninit_ref 
Problems: free of stack variable, TODO left to evaluate
 2017-08-19 14:49:52 +03:00
Luca Boccassi
7453a02144 Problem: CMake on Linux does not link libzmq with optional libs 
Solution: add missing target_link_libraries
Fixes #2701
 2017-08-19 12:26:36 +01:00
Luca Boccassi
90b6c102bb Problem: various unused variables warnings 
Solution: use LIBZMQ_UNUSED where necessary
 2017-08-19 12:18:51 +01:00
Luca Boccassi
e81a40b8bd Problem: CMake build ignores SO_BINDTODEVICE 
Solution: add it to CMake's platform.hpp.in
 2017-08-19 12:07:25 +01:00
Luca Boccassi
9387897674 Problem: multi-part able sockets deprecated in favour of non-multi-part 
Solution: as discussed, remove the deprecation notices, as many users
expressed the need for multi-part support.
Fixes #2699
 2017-08-19 11:23:18 +01:00
Luca Boccassi
5b1c0cd0ac Problem: test_security_gssapi fails to build 
Solution: monitor new events only if DRAFT APIs are enabled, and
convert to new event types. Same for DRAFT socket options.
 2017-08-18 16:56:36 +01:00
Luca Boccassi
330856daec Problem: double definition in test_security_gssapi 
Solution: remove the second one to fix build failure
 2017-08-18 16:28:03 +01:00
Luca Boccassi
b7346f8e00 Problem: gssapi search in autoconf does not use pkgconfig 
Solution: use it before falling back to headers checks
 2017-08-18 16:24:53 +01:00
Luca Boccassi
7be3efc936 Problem: TODO in gssapi mechanism 
Solution: remove it.
Looking at the code:

https://github.com/krb5/krb5/blob/master/src/lib/gssapi/mechglue/g_unseal.c#L55

gss_unwrap as the very first thing checks that plaintext is not a
null pointer, which in our case it's true given it's on the stack,
and then initialises its members to 0 length and null ptr.

https://github.com/krb5/krb5/blob/master/src/lib/gssapi/mechglue/g_rel_buffer.c#L36

So it should be safe to release it in all cases, and the release API
seems to check again if it's not a null pointer and then if the
members are 0 length and null pointer it's a no-op.
 2017-08-18 15:58:35 +01:00
Luca Boccassi
77444e206c Problem: free on stack variable in GSSAPI mechanism 
Solution: free wrapper.value instead of wrapper.
 2017-08-18 15:57:51 +01:00
Doron Somech
80f4a87fb9 Merge pull request #2697 from bluca/vs2008 
Problem: missing files from VS2008 solution
 2017-08-18 16:49:20 +03:00
Luca Boccassi
f0554e7f16 Merge pull request #2696 from sigiesec/gssapi-dont-abort-on-bad-data 
Problem: gssapi_mechanism_base_t aborts the application when it receives a message it cannot decode
 2017-08-18 12:50:28 +01:00
Luca Boccassi
8ecfee475c Problem: missing files from VS2008 solution 
Solution: generate list of sources and headers with:

 ls -1 src/*cpp | sort | sed 's|src/\(.*\)|      <File RelativePath="..\\..\\..\\..\\src\\\1" />|g'
 ls -1 src/*hpp | sort | sed 's|src/\(.*\)|      <File RelativePath="..\\..\\..\\..\\src\\\1" />|g'

and add them.
 2017-08-18 12:45:12 +01:00
sigiesec
898691e2eb Problem: gssapi_mechanism_base_t aborts the application when it receives a message it cannot decode 
Solution: emit an ZMQ_EVENT_HANDSHAKE_FAILED_PROTOCOL event instead of using zmq_assert
 2017-08-18 12:29:37 +02:00
Luca Boccassi
31c72e22ab Merge pull request #2695 from sigiesec/fine-grained-handshake-error-codes 
Problem: Values in ZMQ_EVENT_HANDSHAKE_FAILED_* are not helpful
 2017-08-18 11:21:48 +01:00
sigiesec
301f3c70c2 Problem: code duplication between curve_client_t and curve_server_t decode and encode 
Solution: extracted common base class curve_mechanism_base_t
 2017-08-18 11:34:22 +02:00
sigiesec
44f6aa3de6 Problem: gssapi_* do not emit ZMQ_EVENT_HANDSHAKE_FAILED_PROTOCOL events 
Solution: emit appropriate events
 2017-08-18 10:30:48 +02:00