Simon Giesecke
|
75e945f162
|
Problem: epoll_t employs an unnecessary mutex
Solution: remove the mutex
|
2018-06-06 21:41:16 +02:00 |
|
Simon Giesecke
|
4a18ed6778
|
Problem: build fails due to broken cygwin64 tests
Solution: allow failure of cygwin64 build
|
2018-06-04 15:19:13 +02:00 |
|
Simon Giesecke
|
eccf2e53bc
|
Problem: cygwin build defines ZMQ_HAVE_WINDOWS
Solution: do not check for windows.h on cygwin
|
2018-06-04 15:19:13 +02:00 |
|
Simon Giesecke
|
c5d422c02b
|
Problem: no CI for cygwin
Solution: add cygwin build
|
2018-06-04 15:19:13 +02:00 |
|
Simon Giesecke
|
d07ddb1bce
|
Merge pull request #3153 from pijyoi/autoconf_wepoll
Problem: not able to use wepoll in configure script
|
2018-06-03 11:45:44 +02:00 |
|
KIU Shueng Chuan
|
2336e1f170
|
Problem: not able to use wepoll in configure script
Solution: add wepoll as a polling system
|
2018-06-03 11:55:26 +08:00 |
|
pijyoi
|
c76ac5474b
|
fix computation of winsock fd_set size (#3151)
* fix computation of winsock fd_set size
|
2018-06-02 13:16:33 +01:00 |
|
Luca Boccassi
|
e2a4d770d8
|
Merge pull request #3150 from sigiesec/reduce-duplication
Resolve huge stack size requirements problem with select on Windows
|
2018-06-01 19:48:17 +01:00 |
|
Simon Giesecke
|
17df28d2b6
|
Problem: outdated information in INSTALL regarding stack size
Solution: removed obsolete information
|
2018-06-01 18:43:59 +02:00 |
|
Simon Giesecke
|
5ac900a984
|
Problem: huge size of socket_poller_t object on Windows with select polling
Solution: use resizable_optimized_fd_set_t
|
2018-06-01 18:43:58 +02:00 |
|
Simon Giesecke
|
4a651251a7
|
Problem: code duplication within socket_poller_t
Solution: remove duplicated code
|
2018-06-01 18:24:42 +02:00 |
|
Simon Giesecke
|
74d3d8421f
|
Problem: huge stack allocation with select on Windows in socket_poller_t::wait
Solution: use optimized_fd_set_t
|
2018-06-01 18:22:49 +02:00 |
|
Simon Giesecke
|
3d39bb9ca9
|
Problem: valid_pollset_bytes not reused in socket_poller
Solution: use it
|
2018-06-01 18:22:49 +02:00 |
|
Simon Giesecke
|
a8d62d14c1
|
Problem: polling utilities not at a reusable location
Solution: move to separate header
|
2018-06-01 18:22:48 +02:00 |
|
Simon Giesecke
|
fa8bc17ef3
|
Problem: CMake error on Win32 with DRAFTS disabled
Solution: guard CMake statement properly
|
2018-06-01 18:20:11 +02:00 |
|
Simon Giesecke
|
fc92fa897a
|
Problem: no non-DRAFT Windows build
Solution: switch one build to non-draft
|
2018-06-01 18:20:11 +02:00 |
|
Simon Giesecke
|
7c0efcb588
|
Problem: huge stack allocation in Windows select code
Solution: use fast_vector_t as in poll implementation
|
2018-06-01 18:20:10 +02:00 |
|
Simon Giesecke
|
2533ffed86
|
Problem: memcpy code fragment is duplicated
Solution: unify between Windows and non-Windows code
|
2018-06-01 18:19:46 +02:00 |
|
Simon Giesecke
|
04dedfbc2a
|
Problem: duplicated calculation of valid bytes in select pollset
Solution: extract to function
|
2018-06-01 18:16:46 +02:00 |
|
Simon Giesecke
|
e4c3297ed8
|
Problem: fragile handling of possibly dynamically allocated pollfds
Solution: extract class template fast_vector_t
|
2018-06-01 17:08:39 +02:00 |
|
Simon Giesecke
|
c6e4b0abb1
|
Problem: zmq_poll implementation is complex
Solution: extract compute_timeout method
|
2018-06-01 17:08:38 +02:00 |
|
Simon Giesecke
|
3db3bbfbbb
|
Problem: duplication in implementation zmq_poller_poll
Solution: remove duplication
|
2018-06-01 17:08:38 +02:00 |
|
Luca Boccassi
|
89e5f15ac4
|
Merge pull request #3149 from sigiesec/analyze
Few more code style fixes
|
2018-05-31 17:57:16 +01:00 |
|
Simon Giesecke
|
67b602fe76
|
Problem: unused variable warnings for values only used in asserts
Solution: use a Debug build for analysis
|
2018-05-31 11:25:35 +02:00 |
|
Simon Giesecke
|
3cb4754602
|
Problem: analysis job prolongs overall build
Solution: start analysis job first, if enabled, since it takes the longest time
|
2018-05-31 11:23:04 +02:00 |
|
Simon Giesecke
|
4604014c12
|
Problem: unused result of call to pull_msg
Solution: add TODO comment regarding handling of the result
|
2018-05-31 11:21:33 +02:00 |
|
Simon Giesecke
|
c2ba553d87
|
Problem: unused values stored to variable, duplicated code
Solution: remove duplicated and redundant code
|
2018-05-31 11:02:26 +02:00 |
|
Simon Giesecke
|
ee4cdf8bf0
|
Problem: suspicious use of memcmp result
Solution: explicitly compare result against 0
|
2018-05-31 11:02:26 +02:00 |
|
Luca Boccassi
|
6bfa91f13f
|
Merge pull request #3145 from sigiesec/analyze
More code style fixes and improvements to static analysis configuration
|
2018-05-31 07:59:43 +01:00 |
|
Simon Giesecke
|
0b8f586d8f
|
Merge pull request #3144 from bluca/autoconf_taut
Problem: autoconf checks tautological compiler flag only for C++
|
2018-05-30 23:25:03 +02:00 |
|
Simon Giesecke
|
a2f91c5509
|
Problem: unnecessary passing of non-const data
Solution: make const
|
2018-05-30 23:21:53 +02:00 |
|
Simon Giesecke
|
c641644bb2
|
Problem: inconsistent parameter names
Solution: harmonize
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
ce4b71c3fa
|
Problem: cppcoreguidelines-pro-type-static-cast-downcast warnings that are not meant to be resolved
Solution: disable cppcoreguidelines-pro-type-static-cast-downcast warning
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
9e6f1c9a3c
|
Problem: redundant else after return
Solution: remove redundant else
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
6fa12bd692
|
Problem: unused stored value warning
Solution: add LIBZMQ_UNUSED
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
0f2979a38e
|
Problem: assignment used as condition warning
Solution: changed condition
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
24edc828ab
|
Problem: redundant else after return
Solution: remove redundant else
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
88646438d2
|
Problem: differing parameter names between declaration and definition
Solution: harmonize
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
6c67fca7e0
|
Problem: numerous hicpp-signed-bitwise warnings that cannot easily be solved because of externally defined types
Solution: disable this warning for now
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
da4309da13
|
Problem: violation of parameter naming conventions
Solution: change to comply with naming conventions
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
29f1f39df3
|
Problem: unused parameter warning
Solution: mark parameter as unused depending on platform definitions
|
2018-05-30 23:21:52 +02:00 |
|
Simon Giesecke
|
b59d7d574d
|
Problem: typo in parameter name
Solution: correct spelling
|
2018-05-30 22:52:19 +02:00 |
|
Simon Giesecke
|
a91c7e718c
|
Problem: warnings on violations of CERT ERR-58
Solution: declare functions noexcept
|
2018-05-30 22:52:19 +02:00 |
|
Simon Giesecke
|
0dce223341
|
Problem: no check if noexcept is supported by compiler
Solution: add compile check
|
2018-05-30 22:50:30 +02:00 |
|
Simon Giesecke
|
93194e7c53
|
Problem: non-portable memset
Solution: add dummy pointer meber to union instead
|
2018-05-30 22:50:30 +02:00 |
|
Simon Giesecke
|
9c8fde09ca
|
Problem: inconsistent control structures in address.cpp, redundant check for NULLness before delete
Solution: harmonize, remove redundant checks
|
2018-05-30 22:50:30 +02:00 |
|
Simon Giesecke
|
0179b7577a
|
Problem: literals protocol names used at various places
Solution: introduced named constants
|
2018-05-30 22:50:29 +02:00 |
|
Luca Boccassi
|
06eaf20571
|
Problem: autoconf checks tautological compiler flag only for C++
Solution: check for C as well and set the flags separately
|
2018-05-30 21:21:59 +01:00 |
|
Simon Giesecke
|
bd76926f5b
|
Problem: code style issues in options_t (C-style cast, suboptimal std::string::find call, redundant method is_valid)
Solution: resolved these issues
|
2018-05-30 13:13:31 +02:00 |
|
Simon Giesecke
|
a96a87f343
|
Problem: problematic atoi function is used (CERT ERR-34C)
Solution: use strtol instead
|
2018-05-30 10:35:01 +02:00 |
|