Luca Boccassi
28c7abf821
Problem: zmq_proxy* may return EINTR other than ETERM
...
Solution: mention this in the documentation
2017-01-03 15:34:08 +01:00
Luca Boccassi
ec2ba8a997
Merge pull request #2283 from vtellier/master
...
Fixed issue #2227 second part
2017-01-01 19:29:09 +01:00
Vincent Tellier
ea7e03a7ff
Fixed issue #2286 by documentation
...
tests/README.md explicitly indicates to check the libzmq.lib path in
CMakeLists.txt.
2017-01-01 19:08:28 +01:00
Vincent Tellier
7e36db07b1
Handshake events null pointer fix
...
The mechanism is instanciated during the handshake itself, when and
error happen before this, the error method shall work anyway.
An error handling with a NULL mechanism means the handshake fail, so the
handshake failure event is also raised in this case.
2017-01-01 19:08:28 +01:00
Vincent Tellier
ffb31dcadd
Fixed issue #2227 second part
...
- removed the previously added encryption_error, less changes less bug
- handshake fail is now signaled when an error happen while the
mechanism is still hanshaking
2017-01-01 19:08:28 +01:00
Constantin Rack
ee98e7dca0
Merge pull request #2287 from bluca/hurd_ipv6_tos
...
Problem: build fails on GNU/Hurd as it does not support IPV6_TCLASS
2017-01-01 17:06:31 +01:00
Luca Boccassi
efc0e94291
Problem: build fails on GNU/Hurd as it does not support IPV6_TCLASS
...
Solution: check if IPV6_TCLASS is defined so that when Hurd adds
support it will just work. Also it will avoid tripping over this on
other similar legacy systems.
2017-01-01 16:23:27 +01:00
Constantin Rack
c38fde00a0
Merge pull request #2285 from bluca/bump_versions
...
Problem: 4.2.1 is out, time to bump versions
2016-12-31 18:25:36 +01:00
Luca Boccassi
7c0ded93af
Problem: 4.2.1 is out, time to bump versions
...
Solution: add new changelog entry, bump library version in zmq.h and
bump ABI version in configure.ac and CMakeLists.txt
2016-12-31 16:26:41 +01:00
Luca Boccassi
7005f22726
Bugfix release 4.2.1
...
Finalize changelog and bump ABI revision
2016-12-31 15:55:48 +01:00
Kevin Sapper
086bb890c5
Merge pull request #2282 from bluca/event_test
...
Problems: test_monitor failing, DRAFT events leaking when draft APIs are disabled
2016-12-31 14:13:45 +01:00
Luca Boccassi
3f3601e855
Problem: handshake events not tested with curve
...
Solution: check that the expected handshake success or failure events
are triggered in the curve security unit test
2016-12-31 01:31:37 +01:00
Luca Boccassi
d50b5b80fd
Problem: NEWS entry for ctx option does not point to docs
...
Solution: fix it
2016-12-30 23:53:20 +01:00
Luca Boccassi
fc748ec799
Problem: new monitor events not mentioned in NEWS
...
Solution: add an entry
2016-12-30 23:52:27 +01:00
Luca Boccassi
200649fd57
Problem: new handshake event monitoring undocumented
...
Solution: add them to the event monitor manpage
2016-12-30 23:40:22 +01:00
Luca Boccassi
2afba0085f
Problem: documentation does not warn about ZMQ_EVENT_ALL and new events
...
Solution: add a note pointing out that when new events are added the
ZMQ_EVENT_ALL mask will start returning them, so applications that
can't handle that transparently should not use it and instead pick
only the event types they want.
Creating a new event type and having monitors with ZMQ_EVENT_ALL
return them will not be considered a backward incompatible change
even though the flow of events will change.
2016-12-30 23:27:56 +01:00
Luca Boccassi
c0e2bc4ef9
Problem: new DRAFT monitor events returned even without --enable-draft
...
Solution: wrap the event triggering in the DRAFT ifdef as well as the
defines. This ensures that the event are returned only if the
library was built with DRAFTs enabled.
Also update the test case to expect the new events since it uses
the catch-all mask. Although the sequence of event is different and
this might be considered as an API breakage, using the catch-all
ZMQ_EVENT_ALL mask implies that, well, all events are monitored so
it's normal that new ones will be added.
Users that don't want this kind of behaviour to change can simply
monitor only the event that they care about.
2016-12-30 23:21:14 +01:00
Luca Boccassi
0ebed80dc1
Merge pull request #2281 from vtellier/master
...
Code formatting + reverted hard error handshake fail
2016-12-30 21:00:17 +01:00
Vincent Tellier
48bc75e8a1
Code formatting + reverted hard error handshake fail
...
- Moved new events in draft section + added to zmq_draft.h
- Removed the remainning tabs
- Reverted the hard error (back to soft error) in curve_server.cpp
=> The feature doesn't works anymore
2016-12-30 18:34:33 +01:00
Luca Boccassi
0ad600c7de
Merge pull request #2280 from vtellier/master
...
Fixed issue #2227
2016-12-30 17:15:18 +01:00
Vincent Tellier
b6e9e0c2d3
Fixed issue #2227
...
Added two new monitoring events:
- ZMQ_EVENT_HANDSHAKE_SUCCEED is raised once the encryption handshake succeed
- ZMQ_EVENT_HANDSHAKE_FAILED is raised when it failed
Both events are raised on server and client side.
2016-12-30 16:26:42 +01:00
Constantin Rack
64b07d8132
Merge pull request #2278 from bluca/msg_t_size_draft
2016-12-29 21:48:39 +01:00
Luca Boccassi
8c22ba246c
Problem: bug fixes not mentioned in NEWS file
...
Solution: add most relevant bug fixes since 4.2.0
2016-12-29 21:07:39 +01:00
Luca Boccassi
113feb60a2
Problem: ZMQ_MSG_T_SIZE draft but not in DRAFT section
...
Solution: move it there, add it to src/zmq_draft.h and clarify in the
documentation and in the NEWS file that this option is not yet stable
2016-12-29 21:07:39 +01:00
Luca Boccassi
715f87fec7
Merge pull request #2277 from bluca/automake_1.14
...
Problem: debian build fails with automake < 1.14
2016-12-28 16:36:58 +01:00
Luca Boccassi
47c7d8ee50
Problem: debian build fails with automake < 1.14
...
Solution: create config subdir as a workaround if building the
packages with automake < 1.14
2016-12-28 00:55:17 +01:00
Constantin Rack
ef88b8c760
Merge pull request #2276 from bluca/sodium_pkg
2016-12-27 16:28:08 +01:00
Luca Boccassi
bbae5d0f9a
Problem: dpkg-query might fail in CI build and fail the build
...
Solution: rework the bash test to avoid build failures as intended
and make it an easier one-liner
2016-12-27 14:45:45 +01:00
Constantin Rack
b2a2bb8609
Merge pull request #2275 from bluca/travis_pkg
2016-12-27 12:51:19 +01:00
Luca Boccassi
b1137b7672
Problem: documentation build not tested on Travis
...
Solution: install asciidoc and xmlto in the libsodium build run, since
it already refreshes APT to download other packages, so the delay is
smaller
2016-12-27 12:20:18 +01:00
Luca Boccassi
822def9b2b
Problem: Travis rebuilds libsodium every time
...
Solution: use packages on Ubuntu and brews on OSX. The packages and
the brews are always kept up to date, so it's no use to rebuild the
libsodium stable branch manually everytime.
2016-12-27 11:48:38 +01:00
Luca Boccassi
a1220b7fd4
Problem: Travis OSX workaround for libtool no longer needed
...
Solution: Revert "Problem: Travis CI OSX builds are broken"
This reverts commit 531b3bf7c3
.
2016-12-27 11:28:09 +01:00
Luca Boccassi
1f86019e3f
Problem: Travis installs packages when not needed
...
Solution: narrow down the matrix to install valgrind and lcov only
for the test runs that use them.
CMake is part of the default image so no need to install it at all.
2016-12-27 11:27:33 +01:00
Constantin Rack
5871ea5df8
Merge pull request #2274 from bluca/cloexec
2016-12-26 20:18:12 +01:00
Luca Boccassi
06055a7b74
Problem: cmake does not run test_zmq_poll_fd
...
Solution: add it to the list
2016-12-26 19:20:09 +01:00
Luca Boccassi
6e708ce144
Problem: socketpair leaks file on fork+exec
...
Solution: if available, call socketpair with SOCK_CLOEXEC flag to
make the process close the socket on fork+exec
2016-12-26 19:13:02 +01:00
Luca Boccassi
f287c7a2aa
Problem: eventfd leaks socket on fork+exec
...
Solution: if available, use eventfd with EFD_CLOEXEC flag to make
the process close the socket on fork+exec
2016-12-26 19:08:27 +01:00
Luca Boccassi
211898d243
Problem: epoll leaks socket on fork+exec
...
Solution: if available, use epoll_create1 with EPOLL_CLOEXEC flag to
make the process close the socket on fork+exec
2016-12-26 19:08:27 +01:00
Constantin Rack
16439e42d2
Merge pull request #2272 from bluca/document_read_after_free
2016-12-26 15:24:44 +01:00
Constantin Rack
d68e2e018e
Merge pull request #2273 from bluca/docs
2016-12-26 15:12:40 +01:00
Luca Boccassi
3dc016cab3
Problem: no documentation for ZMQ_SOCKS_PROXY
...
Solution: add paragraphs to zmq_get/setsockopt man pages
2016-12-26 14:54:58 +01:00
Luca Boccassi
baf32a1985
Problem: no documentation for zmq_curve_public
...
Solution: add manpage
2016-12-26 14:54:58 +01:00
Luca Boccassi
a06f97d73a
Problem: fix for read-after-free not documented
...
Solution: add a comment as it's easy to miss and very tempting to
"optimize"
2016-12-25 18:01:55 +01:00
Luca Boccassi
dc39ceb347
Merge pull request #2268 from imkos/master
...
Mingw32 Compile
2016-12-22 13:55:03 +01:00
Kos
43941052a9
add link libsodium.a
2016-12-22 14:25:00 +08:00
Kos
edad90f770
mingw32 fix
2016-12-22 09:35:49 +08:00
Luca Boccassi
fe3756defa
Merge pull request #2266 from Cziken/master
...
Problem: Duplicated code
2016-12-19 18:07:37 +01:00
Wojciech Kula
ee72493e14
Problem: Duplicated code
...
Solution: set_curve_key method in options_t struct with little
improvement in switch-case block
2016-12-19 12:13:14 +01:00
Constantin Rack
7a8180ece7
Merge pull request #2265 from bluca/contribution_notice_github
...
Problem: contributing guidelines unclear for new devs
2016-12-18 16:52:15 +01:00
Luca Boccassi
e6b1f56131
Problem: contributing guidelines unclear for new devs
...
Solution: port Github PR template from CZMQ
2016-12-18 11:46:08 +00:00