generic-library/libupnp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

SF ticket #53 Action Error Response not returned

Browse Source 
In soap_ctrlpt.c, in function get_response_value:

upnp_error_code is checked to see if it is less than 400 because that
would indicate a SOAP error code.

However it should be checked to see if it is greater than 400.
(cherry picked from commit 7b1aa4c9e3)
This commit is contained in:
Robert Buckley 2013-07-30 17:07:30 -03:00 committed by Marcelo Roberto Jimenez
parent a641a27cb6
commit 396b7ae639
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ChangeLog
View File

@ -349,6 +349,17 @@ Version 1.8.0
Version 1.6.19
*******************************************************************************
2013-07-30 Robert Buckley <rbuckley(at)users.sf.net>
SF ticket #53 Action Error Response not returned
In soap_ctrlpt.c, in function get_response_value:
upnp_error_code is checked to see if it is less than 400 because that
would indicate a SOAP error code.
However it should be checked to see if it is greater than 400.
2013-07-30 Zheng Peng <darkelf2010(at)users.sf.net>
SF ticket #116 UpnpRemoveVirtualDir wrong linked list operation

1
THANKS
View File

@ -56,6 +56,7 @@ exempt of errors.
- Paul Vixie
- Peter Hartley
- Rene Hexel
- Robert Buckley (rbuckley)
- Robert Gingher (robsbox)
- Ronan Menard
- Sebastian Brandt

2
upnp/src/soap/soap_ctrlpt.c
View File

@ -455,7 +455,7 @@ get_response_value( IN http_message_t * hmsg,
if (!temp_str)
goto error_handler;
*upnp_error_code = atoi(temp_str);
if (*upnp_error_code < 400) {
if (*upnp_error_code > 400) {
err_code = *upnp_error_code;
goto error_handler; /* bad SOAP error code */
}