From 396b7ae639be20b76d4cc4f837cc4bc5e3db5265 Mon Sep 17 00:00:00 2001 From: Robert Buckley Date: Tue, 30 Jul 2013 17:07:30 -0300 Subject: [PATCH] SF ticket #53 Action Error Response not returned In soap_ctrlpt.c, in function get_response_value: upnp_error_code is checked to see if it is less than 400 because that would indicate a SOAP error code. However it should be checked to see if it is greater than 400. (cherry picked from commit 7b1aa4c9e30e95461dfc16fa8c30775fc2bba7cf) --- ChangeLog | 11 +++++++++++ THANKS | 1 + upnp/src/soap/soap_ctrlpt.c | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 8e6dd9e..ce939c2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -349,6 +349,17 @@ Version 1.8.0 Version 1.6.19 ******************************************************************************* +2013-07-30 Robert Buckley + + SF ticket #53 Action Error Response not returned + + In soap_ctrlpt.c, in function get_response_value: + + upnp_error_code is checked to see if it is less than 400 because that + would indicate a SOAP error code. + + However it should be checked to see if it is greater than 400. + 2013-07-30 Zheng Peng SF ticket #116 UpnpRemoveVirtualDir wrong linked list operation diff --git a/THANKS b/THANKS index d73ff23..6bd334d 100644 --- a/THANKS +++ b/THANKS @@ -56,6 +56,7 @@ exempt of errors. - Paul Vixie - Peter Hartley - Rene Hexel +- Robert Buckley (rbuckley) - Robert Gingher (robsbox) - Ronan Menard - Sebastian Brandt diff --git a/upnp/src/soap/soap_ctrlpt.c b/upnp/src/soap/soap_ctrlpt.c index da4aa7b..ed98682 100644 --- a/upnp/src/soap/soap_ctrlpt.c +++ b/upnp/src/soap/soap_ctrlpt.c @@ -455,7 +455,7 @@ get_response_value( IN http_message_t * hmsg, if (!temp_str) goto error_handler; *upnp_error_code = atoi(temp_str); - if (*upnp_error_code < 400) { + if (*upnp_error_code > 400) { err_code = *upnp_error_code; goto error_handler; /* bad SOAP error code */ }