generic-library/isa-l
1
0
Fork 0
mirror of https://github.com/intel/isa-l.git synced 2025-10-29 12:18:00 +01:00
Code Issues Projects Releases Wiki Activity

igzip: Fix aarch64 registry width for bfinal

Browse Source 
We only ever load 32 bits into it, and we only ever want to compare against
32 bits. There was no need to declare it as 64 bits.

Furthermore, there were cases where a 64 bit comparison around
isal_out_overflow_1 led us to erroneously set the block state to
ISAL_BLOCK_INPUT_DONE when it should have been left at ISAL_BLOCK_NEW_HDR.

Fixes #316

Signed-off-by: Tim Burke <tim.burke@gmail.com>
This commit is contained in:
Tim Burke
2025-08-18 14:35:11 -07:00
committed by Tomasz Kantecki
parent 73c50447fc
commit a46e3f1588
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
igzip/aarch64/igzip_decode_huffman_code_block_aarch64.S
View File

@@ -292,7 +292,7 @@ declare Macros
declare_generic_reg block_state, 8,w
declare_generic_reg block_state_adr,9,x
declare_generic_reg look_back_dist, 10,w
declare_generic_reg bfinal, 22,x
declare_generic_reg bfinal, 22,w
declare_generic_reg next_out, 12,x
declare_generic_reg avail_out, 13,w
@@ -607,8 +607,8 @@ next_lit_eq_256:
ISAL_BLOCK_INPUT_DONE : ISAL_BLOCK_NEW_HDR;
*/
mov block_state, ISAL_BLOCK_INPUT_DONE
cmp w_bfinal,0
csel block_state, block_state, w_bfinal, ne
cmp bfinal,0
csel block_state, block_state, bfinal, ne
str block_state, [block_state_adr]
b block_state_loop