generic-library/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

lavfi/delogo: don't recompute the same difference again and again

Browse Source 
The top left hand corner pixel coordinates are already stored in
logo_x1 and logo_y1 so don't recompute each of them 6 times for every
iteration.

This is a simple code optimization, result is obviously the same. The
performance gain is small (about 2% in my tests) but still good to
have, and the new code is clearer.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Reviewed-by; Stefano Sabatini <stefasab@gmail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Jean Delvare
2013-07-05 10:23:18 +02:00
committed by Michael Niedermayer
parent c6c2231227
commit 6fc8c4cc0e
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
libavfilter/vf_delogo.c
View File

@@ -100,21 +100,21 @@ static void apply_delogo(uint8_t *dst, int dst_linesize,
weightb = (uint64_t)(x-logo_x1) * (logo_x2-1-x) * (y-logo_y1) * sar.num; weightb = (uint64_t)(x-logo_x1) * (logo_x2-1-x) * (y-logo_y1) * sar.num;
interp = interp =
(topleft[src_linesize*(y-logo_y -yclipt)] + (topleft[src_linesize*(y-logo_y1)] +
topleft[src_linesize*(y-logo_y-1-yclipt)] + topleft[src_linesize*(y-logo_y1-1)] +
topleft[src_linesize*(y-logo_y+1-yclipt)]) * weightl topleft[src_linesize*(y-logo_y1+1)]) * weightl
+ +
(topright[src_linesize*(y-logo_y-yclipt)] + (topright[src_linesize*(y-logo_y1)] +
topright[src_linesize*(y-logo_y-1-yclipt)] + topright[src_linesize*(y-logo_y1-1)] +
topright[src_linesize*(y-logo_y+1-yclipt)]) * weightr topright[src_linesize*(y-logo_y1+1)]) * weightr
+ +
(topleft[x-logo_x-xclipl] + (topleft[x-logo_x1] +
topleft[x-logo_x-1-xclipl] + topleft[x-logo_x1-1] +
topleft[x-logo_x+1-xclipl]) * weightt topleft[x-logo_x1+1]) * weightt
+ +
(botleft[x-logo_x-xclipl] + (botleft[x-logo_x1] +
botleft[x-logo_x-1-xclipl] + botleft[x-logo_x1-1] +
botleft[x-logo_x+1-xclipl]) * weightb; botleft[x-logo_x1+1]) * weightb;
interp /= (weightl + weightr + weightt + weightb) * 3U; interp /= (weightl + weightr + weightt + weightb) * 3U;
if (y >= logo_y+band && y < logo_y+logo_h-band && if (y >= logo_y+band && y < logo_y+logo_h-band &&