286e0a491b
Summary: This patch attempts to fix the last 3 TSAN failures on the libc++ bot (http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-tsan/builds/143). This patch also adds a `Atomic` test type that can be used where `<atomic>` cannot. `wait.exception.pass.cpp` and `wait_for.exception.pass.cpp` were failing because the test replaced `std::terminate` with `std::exit`. `std::exit` would asynchronously run the TLS and static destructors and this would cause a race condition. See PR22606 and D8802 for more details. This is fixed by using `_Exit` to prevent cleanup. `notify_all_at_thread_exit.pass.cpp` exercises the same race condition but for different reasons. I fixed this test by manually joining the thread before beginning program termination. Reviewers: EricWF, mclow.lists Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D11046 git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@245389 91177308-0d34-0410-b5e6-96231b3b80d8
46 lines
1.1 KiB
C++
46 lines
1.1 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is dual licensed under the MIT and the University of Illinois Open
|
|
// Source Licenses. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// UNSUPPORTED: libcpp-has-no-threads
|
|
|
|
// <condition_variable>
|
|
|
|
// void
|
|
// notify_all_at_thread_exit(condition_variable& cond, unique_lock<mutex> lk);
|
|
|
|
#include <condition_variable>
|
|
#include <mutex>
|
|
#include <thread>
|
|
#include <chrono>
|
|
#include <cassert>
|
|
|
|
std::condition_variable cv;
|
|
std::mutex mut;
|
|
|
|
typedef std::chrono::milliseconds ms;
|
|
typedef std::chrono::high_resolution_clock Clock;
|
|
|
|
void func()
|
|
{
|
|
std::unique_lock<std::mutex> lk(mut);
|
|
std::notify_all_at_thread_exit(cv, std::move(lk));
|
|
std::this_thread::sleep_for(ms(300));
|
|
}
|
|
|
|
int main()
|
|
{
|
|
std::unique_lock<std::mutex> lk(mut);
|
|
std::thread t(func);
|
|
Clock::time_point t0 = Clock::now();
|
|
cv.wait(lk);
|
|
Clock::time_point t1 = Clock::now();
|
|
assert(t1-t0 > ms(250));
|
|
t.join();
|
|
}
|