
Summary: This patch attempts to fix the last 3 TSAN failures on the libc++ bot (http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-tsan/builds/143). This patch also adds a `Atomic` test type that can be used where `<atomic>` cannot. `wait.exception.pass.cpp` and `wait_for.exception.pass.cpp` were failing because the test replaced `std::terminate` with `std::exit`. `std::exit` would asynchronously run the TLS and static destructors and this would cause a race condition. See PR22606 and D8802 for more details. This is fixed by using `_Exit` to prevent cleanup. `notify_all_at_thread_exit.pass.cpp` exercises the same race condition but for different reasons. I fixed this test by manually joining the thread before beginning program termination. Reviewers: EricWF, mclow.lists Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D11046 git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@245389 91177308-0d34-0410-b5e6-96231b3b80d8
65 lines
1.2 KiB
C++
65 lines
1.2 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is dual licensed under the MIT and the University of Illinois Open
|
|
// Source Licenses. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// UNSUPPORTED: libcpp-has-no-threads
|
|
|
|
|
|
// <thread>
|
|
|
|
// class thread
|
|
|
|
// ~thread();
|
|
|
|
#include <thread>
|
|
#include <new>
|
|
#include <cstdlib>
|
|
#include <cassert>
|
|
|
|
class G
|
|
{
|
|
int alive_;
|
|
public:
|
|
static int n_alive;
|
|
static bool op_run;
|
|
|
|
G() : alive_(1) {++n_alive;}
|
|
G(const G& g) : alive_(g.alive_) {++n_alive;}
|
|
~G() {alive_ = 0; --n_alive;}
|
|
|
|
void operator()()
|
|
{
|
|
assert(alive_ == 1);
|
|
assert(n_alive >= 1);
|
|
op_run = true;
|
|
}
|
|
};
|
|
|
|
int G::n_alive = 0;
|
|
bool G::op_run = false;
|
|
|
|
void f1()
|
|
{
|
|
std::_Exit(0);
|
|
}
|
|
|
|
int main()
|
|
{
|
|
std::set_terminate(f1);
|
|
{
|
|
assert(G::n_alive == 0);
|
|
assert(!G::op_run);
|
|
G g;
|
|
{
|
|
std::thread t(g);
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(250));
|
|
}
|
|
}
|
|
assert(false);
|
|
}
|