generic-library/cxx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Andrew Morrow: There are two tests under test/utilities/memory that heap allocate two

Browse Source 
integers which remain unused and are subsequently leaked, so the test
fail when run under valgrind. Unless I'm overlooking a subtle reason
why they are needed I think they can be removed, allowing these tests
to pass under valgrind. The attached patch removes the variables. If
there is a reason for them to exist, I can change this to just delete
them at the end of the test.

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@161195 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Howard Hinnant 2012-08-02 18:39:48 +00:00
parent 63b2f4f2dc
commit 069bdd52c1
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/utilities/memory/unique.ptr/unique.ptr.special/cmp_nullptr.pass.cpp
View File

@ -43,8 +43,6 @@ void do_nothing(int*) {}
int main()
{
int* ptr1(new int);
int* ptr2(new int);
const std::unique_ptr<int> p1(new int(1));
assert(!(p1 == nullptr));
assert(!(nullptr == p1));

2
test/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.cmp/cmp_nullptr.pass.cpp
View File

@ -43,8 +43,6 @@ void do_nothing(int*) {}
int main()
{
int* ptr1(new int);
int* ptr2(new int);
const std::shared_ptr<int> p1(new int(1));
assert(!(p1 == nullptr));
assert(!(nullptr == p1));