getparam: fix the GetStr() macro

It should return PARAM_NO_MEM if the strdup fails. Spotted by clang-analyzer
2012-07-13 23:39:25 +02:00 · 2012-07-13 23:39:25 +02:00 · ff318a6302
commit ff318a6302
parent 0e24c1e921
1 changed files with 4 additions and 3 deletions
--- a/src/tool_getparam.c
+++ b/src/tool_getparam.c
@ -56,10 +56,11 @@
    free(*(str)); \
    *(str) = NULL; \
  } \
-  if((val)) \
+  if((val)) {              \
    *(str) = strdup((val)); \
-  if(!(val)) \
-    return PARAM_NO_MEM; \
+    if(!(*(str)))          \
+      return PARAM_NO_MEM; \
+  } \
 } WHILE_FALSE

 struct LongShort {