generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

netrc: Tightened up the type checks.

Browse Source 
The state should not be anonymous so that we can check if the values
are fine. Added 2 unreachables states to the switch as a result of this
change.
This commit is contained in:
Julien Chaffraix 2011-01-28 08:20:37 -08:00
parent 4e2ac742c9
commit fe165c69de
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/netrc.c
View File

@ -58,7 +58,7 @@
/* Get user and password from .netrc when given a machine name */
enum {
enum host_lookup_state {
NOTHING,
HOSTFOUND, /* the 'machine' keyword was found */
HOSTCOMPLETE, /* the machine name following the keyword was found too */
@ -83,7 +83,7 @@ int Curl_parsenetrc(const char *host,
char *home = NULL;
bool home_alloc = FALSE;
bool netrc_alloc = FALSE;
int state=NOTHING;
enum host_lookup_state state=NOTHING;
char state_login=0; /* Found a login keyword */
char state_password=0; /* Found a password keyword */
@ -210,6 +210,10 @@ int Curl_parsenetrc(const char *host,
state_our_login = FALSE;
}
break;
case HOSTCOMPLETE:
case HOSTEND:
/* Should not be reached. */
DEBUGASSERT(0);
} /* switch (state) */
tok = strtok_r(NULL, " \t\n", &tok_buf);