generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

smb: use memcpy() instead of strncpy()

Browse Source 
... as it never copies the trailing zero anyway and always just the four
bytes so let's not mislead anyone into thinking it is actually treated
as a string.

Coverity CID: 1260214
This commit is contained in:
Daniel Stenberg 2014-12-21 23:21:16 +01:00
parent f9cf3de70b
commit 2c5f346d3a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/smb.c
View File

@ -345,7 +345,7 @@ static void smb_format_message(struct connectdata *conn, struct smb_header *h,
memset(h, 0, sizeof(*h));
h->nbt_length = htons((unsigned short) (sizeof(*h) - sizeof(unsigned int) +
len));
strncpy((char *)h->magic, "\xffSMB", 4);
memcpy((char *)h->magic, "\xffSMB", 4);
h->command = cmd;
h->flags = SMB_FLAGS_CANONICAL_PATHNAMES | SMB_FLAGS_CASELESS_PATHNAMES;
h->flags2 = smb_swap16(SMB_FLAGS2_IS_LONG_NAME | SMB_FLAGS2_KNOWS_LONG_NAME);