generic-library/cppzmq
1
0
Fork 0
mirror of https://github.com/zeromq/cppzmq.git synced 2025-04-28 02:33:32 +02:00
Code Issues Projects Releases Wiki Activity

Problem: deprecated poller's method in draft API

Browse Source 
We have a deprecated method `add` in poller that contradicts purpose of a draft
API where it can change without deprecation period.

Solution: remove the method so we do not to maintain it anymore.
This commit is contained in:
Pawel Kurdybacha 2018-04-26 19:50:14 +01:00
parent 17e1d97044
commit 94e0fb0bc3
2 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/poller.cpp
View File

@ -265,11 +265,11 @@ TEST(poller, poller_remove_invalid_socket_throws)
TEST(poller, wait_on_added_empty_handler)
{
server_client_setup s;
ASSERT_NO_THROW(s.client.send("Hi"));
ASSERT_NO_THROW (s.client.send ("Hi"));
zmq::poller_t poller;
std::function<void(void)> handler;
ASSERT_NO_THROW(poller.add(s.server, ZMQ_POLLIN, handler));
ASSERT_NO_THROW(poller.wait(std::chrono::milliseconds{-1}));
zmq::poller_t::handler_t handler;
ASSERT_NO_THROW (poller.add (s.server, ZMQ_POLLIN, handler));
ASSERT_NO_THROW (poller.wait (std::chrono::milliseconds {-1}));
}
TEST(poller, modify_empty_throws)

7
zmq.hpp
View File

@ -1050,13 +1050,6 @@ namespace zmq
using handler_t = std::function<void(short)>;
ZMQ_DEPRECATED("from 4.3.0, use overload accepting handler_t instead")
void add (zmq::socket_t &socket, short events, std::function<void(void)> &handler)
{
add (socket, events, handler ? [&handler](short) { handler(); }
: handler_t{});
}
void add (zmq::socket_t &socket, short events, handler_t handler)
{
auto it = std::end (handlers);