generic-library/breakpad
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add virtual dtor to LibcurlWrapper.

Browse Source 
LibcurlWrapper is deleted but contains no virtual destructor, triggering
warnings with -Wdelete-non-virtual-dtor in clang++.

R=ivanpe@chromium.org

Review URL: https://breakpad.appspot.com/7664002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1337 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
pbos@chromium.org 2014-06-04 08:54:07 +00:00
parent 91f746ec81
commit 20583f0560
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/linux/libcurl_wrapper.cc
View File

@ -57,6 +57,8 @@ LibcurlWrapper::LibcurlWrapper()
return;
}
LibcurlWrapper::~LibcurlWrapper() {}
bool LibcurlWrapper::SetProxy(const string& proxy_host,
const string& proxy_userpwd) {
if (!init_ok_) {

1
src/common/linux/libcurl_wrapper.h
View File

@ -40,6 +40,7 @@ namespace google_breakpad {
class LibcurlWrapper {
public:
LibcurlWrapper();
~LibcurlWrapper();
virtual bool Init();
virtual bool SetProxy(const string& proxy_host,
const string& proxy_userpwd);