generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

set errno to ENOENT in getauxval per glibc 2.19

Browse Source 
Bionic's getauxval(...) implementation returns zero when entries are
missing. Zero can be a valid value, so there is no unambiguous way of
detecting an error. Since glibc 2.19, errno is set to ENOENT when an
entry is missing to make it possible to detect this. Bionic should match
this behavior as code in the Linux ecosystem will start relying on it to
check for the presence of newly added entries.

Change-Id: Ic1efe29bc45fc87489274c96c4d2193f3a7b8854
Signed-off-by: Daniel Micay <danielmicay@gmail.com>
This commit is contained in:
Daniel Micay 2015-03-15 21:39:25 -04:00
parent d917b20b61
commit ee7649c5ac
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libc/bionic/getauxval.cpp
View File

@ -31,6 +31,7 @@
#include <sys/auxv.h>
#include <private/bionic_auxv.h>
#include <elf.h>
#include <errno.h>
__LIBC_HIDDEN__ ElfW(auxv_t)* __libc_auxv = NULL;
@ -40,5 +41,6 @@ extern "C" unsigned long int getauxval(unsigned long int type) {
return v->a_un.a_val;
}
}
errno = ENOENT;
return 0;
}

3
tests/getauxval_test.cpp
View File

@ -14,6 +14,7 @@
* limitations under the License.
*/
#include <errno.h>
#include <sys/cdefs.h>
#include <gtest/gtest.h>
@ -53,7 +54,9 @@ TEST(getauxval, expected_values) {
TEST(getauxval, unexpected_values) {
#if defined(GETAUXVAL_CAN_COMPILE)
errno = 0;
ASSERT_EQ((unsigned long int) 0, getauxval(0xdeadbeef));
ASSERT_EQ(ENOENT, errno);
#else
GTEST_LOG_(INFO) << "This test does nothing.\n";
#endif