generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

glibc 2.15 treats errno as signed in strerror(3).

Browse Source 
And the only reason I hadn't done that in bionic is because I wanted to behave
the same as glibc.

Change-Id: I2cf1bf0aac82a748cd6305a2cabbac0790058570
This commit is contained in:
Elliott Hughes 2013-01-10 16:01:59 -08:00
parent 0d3700d957
commit e6e60065ff
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libc/bionic/strerror_r.cpp
View File

@ -49,7 +49,7 @@ int strerror_r(int error_number, char* buf, size_t buf_len) {
if (error_name != NULL) {
length = snprintf(buf, buf_len, "%s", error_name);
} else {
length = snprintf(buf, buf_len, "Unknown error %u", error_number);
length = snprintf(buf, buf_len, "Unknown error %d", error_number);
}
if (length >= buf_len) {
errno = ERANGE;

2
tests/string_test.cpp
View File

@ -39,7 +39,7 @@ TEST(string, strerror) {
ASSERT_STREQ("Operation not permitted", strerror(1));
// Invalid.
ASSERT_STREQ("Unknown error 4294967295", strerror(-1));
ASSERT_STREQ("Unknown error -1", strerror(-1));
ASSERT_STREQ("Unknown error 1234", strerror(1234));
}