b6e4cc776e
Skeleton suppression files for future WebRTC suppressions are added and are included in addition to the ones Chrome are using and maintaining when our wrapper script executes. Also added tweaked PRESUBMIT checks based on the Chrome code, that verifies that suppressions are added correctly. I tested that they work by adding an invalid suppression. BUG=544 TEST=Tested running tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t out/Debug/system_wrappers_unittests and it reports far less errors. Tested adding bad suppression and it was caught by the PRESUBMIT check. Review URL: https://webrtc-codereview.appspot.com/601004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@2304 4adac7df-926f-26a2-2b94-8c16560cd09d
42 lines
1.4 KiB
Python
42 lines
1.4 KiB
Python
#!/usr/bin/env python
|
|
# Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
import os
|
|
import re
|
|
import sys
|
|
|
|
"""
|
|
Copied from Chrome's src/tools/valgrind/tsan/PRESUBMIT.py
|
|
|
|
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
|
|
for more details on the presubmit API built into gcl.
|
|
"""
|
|
|
|
def CheckChange(input_api, output_api):
|
|
"""Checks the TSan suppressions files for bad suppressions."""
|
|
|
|
# Add the path to the Chrome valgrind dir to the import path:
|
|
tools_vg_path = os.path.join(input_api.PresubmitLocalPath(), '..', '..',
|
|
'valgrind')
|
|
sys.path.append(tools_vg_path)
|
|
import suppressions
|
|
|
|
return suppressions.PresubmitCheck(input_api, output_api)
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return CheckChange(input_api, output_api)
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return CheckChange(input_api, output_api)
|
|
|
|
def GetPreferredTrySlaves():
|
|
# We don't have any tsan slaves yet, so there's no use for this method.
|
|
# When we have, the slave name(s) should be put into this list.
|
|
return []
|