Files
webrtc/webrtc/base/taskparent.cc
kwiberg@webrtc.org 67186fe00c Fix clang style warnings in webrtc/base
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.

Not inlining virtual functions with simple bodies such as

  { return false; }

strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.

BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47429004

Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 22:24:25 +00:00

99 lines
2.2 KiB
C++

/*
* Copyright 2004 The WebRTC Project Authors. All rights reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include <algorithm>
#include "webrtc/base/taskparent.h"
#include "webrtc/base/common.h"
#include "webrtc/base/task.h"
#include "webrtc/base/taskrunner.h"
namespace rtc {
TaskParent::TaskParent(Task* derived_instance, TaskParent *parent)
: parent_(parent) {
ASSERT(derived_instance != NULL);
ASSERT(parent != NULL);
runner_ = parent->GetRunner();
parent_->AddChild(derived_instance);
Initialize();
}
TaskParent::TaskParent(TaskRunner *derived_instance)
: parent_(NULL),
runner_(derived_instance) {
ASSERT(derived_instance != NULL);
Initialize();
}
TaskParent::~TaskParent() = default;
// Does common initialization of member variables
void TaskParent::Initialize() {
children_.reset(new ChildSet());
child_error_ = false;
}
void TaskParent::AddChild(Task *child) {
children_->insert(child);
}
#ifdef _DEBUG
bool TaskParent::IsChildTask(Task *task) {
ASSERT(task != NULL);
return task->parent_ == this && children_->find(task) != children_->end();
}
#endif
bool TaskParent::AllChildrenDone() {
for (ChildSet::iterator it = children_->begin();
it != children_->end();
++it) {
if (!(*it)->IsDone())
return false;
}
return true;
}
bool TaskParent::AnyChildError() {
return child_error_;
}
void TaskParent::AbortAllChildren() {
if (children_->size() > 0) {
#ifdef _DEBUG
runner_->IncrementAbortCount();
#endif
ChildSet copy = *children_;
for (ChildSet::iterator it = copy.begin(); it != copy.end(); ++it) {
(*it)->Abort(true); // Note we do not wake
}
#ifdef _DEBUG
runner_->DecrementAbortCount();
#endif
}
}
void TaskParent::OnStopped(Task *task) {
AbortAllChildren();
parent_->OnChildStopped(task);
}
void TaskParent::OnChildStopped(Task *child) {
if (child->HasError())
child_error_ = true;
children_->erase(child);
}
} // namespace rtc