67186fe00c
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
56 lines
1.5 KiB
C++
56 lines
1.5 KiB
C++
/*
|
|
* Copyright 2004 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <assert.h>
|
|
|
|
#include "webrtc/base/nattypes.h"
|
|
|
|
namespace rtc {
|
|
|
|
class SymmetricNAT : public NAT {
|
|
public:
|
|
bool IsSymmetric() override { return true; }
|
|
bool FiltersIP() override { return true; }
|
|
bool FiltersPort() override { return true; }
|
|
};
|
|
|
|
class OpenConeNAT : public NAT {
|
|
public:
|
|
bool IsSymmetric() override { return false; }
|
|
bool FiltersIP() override { return false; }
|
|
bool FiltersPort() override { return false; }
|
|
};
|
|
|
|
class AddressRestrictedNAT : public NAT {
|
|
public:
|
|
bool IsSymmetric() override { return false; }
|
|
bool FiltersIP() override { return true; }
|
|
bool FiltersPort() override { return false; }
|
|
};
|
|
|
|
class PortRestrictedNAT : public NAT {
|
|
public:
|
|
bool IsSymmetric() override { return false; }
|
|
bool FiltersIP() override { return true; }
|
|
bool FiltersPort() override { return true; }
|
|
};
|
|
|
|
NAT* NAT::Create(NATType type) {
|
|
switch (type) {
|
|
case NAT_OPEN_CONE: return new OpenConeNAT();
|
|
case NAT_ADDR_RESTRICTED: return new AddressRestrictedNAT();
|
|
case NAT_PORT_RESTRICTED: return new PortRestrictedNAT();
|
|
case NAT_SYMMETRIC: return new SymmetricNAT();
|
|
default: assert(0); return 0;
|
|
}
|
|
}
|
|
|
|
} // namespace rtc
|