generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
e5063b1733
webrtc/talk/session/media
History
fischman@webrtc.org e5063b1733 Thread: delete racy API (Release()) and fix racy code (started()). 
- Thread::Release() wrote a local variable on the calling thread but read it on
  another thread, with no synchronization.  Happily it has no non-test callers
  so deleting it instead of trying to fix it (see bug for details).
- Thread::started_ similarly was racily being written to; replaced with a
  running_ Event, and hid the accessor except for tests & legacy callers,
  with a note about why it's a bad idea.

webrtc/base patched with:
git diff origin --relative=talk/base | patch -p1 -dwebrtc/base
followed by manual merge of 3 thunks that ran afoul of naming differences
between talk/base and webrtc/base.

BUG=3388
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14589005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6236 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 17:28:50 +00:00
..
audiomonitor.cc Remove std:: prefixes from C functions in talk/. 2014-03-07 15:22:04 +00:00
audiomonitor.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
bundlefilter_unittest.cc (Auto)update libjingle 66138442-> 66236292 2014-05-05 20:18:08 +00:00
bundlefilter.cc (Auto)update libjingle 66138442-> 66236292 2014-05-05 20:18:08 +00:00
bundlefilter.h (Auto)update libjingle 66138442-> 66236292 2014-05-05 20:18:08 +00:00
call.cc (Auto)update libjingle 66541346-> 66556498 2014-05-08 23:10:23 +00:00
call.h (Auto)update libjingle 66541346-> 66556498 2014-05-08 23:10:23 +00:00
channel_unittest.cc (Auto)update libjingle 67052073-> 67134648 2014-05-15 16:15:59 +00:00
channel.cc (Auto)update libjingle 67052073-> 67134648 2014-05-15 16:15:59 +00:00
channel.h (Auto)update libjingle 67052073-> 67134648 2014-05-15 16:15:59 +00:00
channelmanager_unittest.cc Update talk to 54898858. 2013-10-16 18:12:02 +00:00
channelmanager.cc Thread: delete racy API (Release()) and fix racy code (started()). 2014-05-23 17:28:50 +00:00
channelmanager.h (Auto)update libjingle 65729829-> 65752960 2014-04-28 21:31:51 +00:00
currentspeakermonitor_unittest.cc (Auto)update libjingle 66541346-> 66556498 2014-05-08 23:10:23 +00:00
currentspeakermonitor.cc (Auto)update libjingle 67555838-> 67643194 2014-05-21 00:24:54 +00:00
currentspeakermonitor.h (Auto)update libjingle 67555838-> 67643194 2014-05-21 00:24:54 +00:00
externalhmac.cc (Auto)update libjingle 63293120-> 63352036 2014-03-18 21:39:10 +00:00
externalhmac.h (Auto)update libjingle 63293120-> 63352036 2014-03-18 21:39:10 +00:00
mediamessages_unittest.cc Update talk folder to revision=49952949 2013-07-26 19:17:59 +00:00
mediamessages.cc Cleanups in libjingle to make it compile with chromium_code=1 2014-03-25 00:31:35 +00:00
mediamessages.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mediamonitor.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mediamonitor.h Revert 5516 "Thread annotation of talk_base::CriticalSection." 2014-02-10 23:20:15 +00:00
mediarecorder_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mediarecorder.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mediarecorder.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mediasession_unittest.cc (Auto)update libjingle 62691533-> 62713454 2014-03-06 23:46:59 +00:00
mediasession.cc Sets the SCTP port codec in the native SessionDescription. 2014-05-01 18:30:30 +00:00
mediasession.h Sets the SCTP port codec in the native SessionDescription. 2014-05-01 18:30:30 +00:00
mediasessionclient_unittest.cc (Auto)update libjingle 64247466-> 64326665 2014-04-04 18:39:07 +00:00
mediasessionclient.cc Update libjingle 62472237->62550414 2014-03-04 19:54:57 +00:00
mediasessionclient.h Update libjingle to CL 53398036. 2013-09-27 23:04:10 +00:00
mediasink.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
planarfunctions_unittest.cc (Auto)update libjingle 62063505-> 62278774 2014-02-27 17:52:04 +00:00
rtcpmuxfilter_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
rtcpmuxfilter.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
rtcpmuxfilter.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
soundclip.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
soundclip.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
srtpfilter_unittest.cc (Auto)update libjingle 62713454-> 62865357 2014-03-10 15:53:12 +00:00
srtpfilter.cc (Auto)update libjingle 62713454-> 62865357 2014-03-10 15:53:12 +00:00
srtpfilter.h Unrevert 5590 "description"(=(Auto)update libjingle 61834300->61901702). 2014-02-21 15:51:43 +00:00
typewrapping.h.pump Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
typingmonitor_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
typingmonitor.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
typingmonitor.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
voicechannel.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
yuvscaler_unittest.cc (Auto)update libjingle 62063505-> 62278774 2014-02-27 17:52:04 +00:00