df596ae444
The CL is organized w.r.t. patch sets as follows: 1) Comments on functionality added. 2) Renamed local variable n to channel for clarity. 3) Dropped the extension _vector of variable |feature_vector| since it doesn't add anything new. 4) Minor comment update w.r.t. |feature| 5) Replaced an else if scheme with two if statements. This way we can use the same calculation for all sub cases which could be a source of error. 6) Moved two code lines to where they are used and rearranged such that avoiding tmp variable. 7) Instead of performing a bit-wise OR operation within an if statement we could perform the bit-wise OR at once. 8) Name change of |shifts0| to |shifts_h0| for clearer reading. Likewise for H1. 9) Renamed |nr| to |gaussian| for clearer reading. 10) Removed multiplication macro. 11) Re-organized local arrays to have the same structure as constants and member arrays used elsewhere in the code. 12) Changed locally declared variable to function declared. 13) Added array initialization at declaration. Tested with trybots, vad_unittests, audioproc_unittest BUG=None TEST=None Review URL: https://webrtc-codereview.appspot.com/595006 git-svn-id: http://webrtc.googlecode.com/svn/trunk@2417 4adac7df-926f-26a2-2b94-8c16560cd09d |
||
---|---|---|
data | ||
peerconnection | ||
src | ||
test | ||
third_party | ||
third_party_mods | ||
tools | ||
.gitignore | ||
android-webrtc.mk | ||
Android.mk | ||
AUTHORS | ||
codereview.settings | ||
DEPS | ||
libvpx.mk | ||
LICENSE | ||
license_template.txt | ||
LICENSE_THIRD_PARTY | ||
OWNERS | ||
PATENTS | ||
PRESUBMIT.py | ||
WATCHLISTS | ||
webrtc.gyp |