53df136240
Add HasDescription and HasNoStrayWhitespace checks. BUG=none TEST=uploaded a dummy CL with violations. Review URL: https://webrtc-codereview.appspot.com/372004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@1556 4adac7df-926f-26a2-2b94-8c16560cd09d
55 lines
2.2 KiB
Python
55 lines
2.2 KiB
Python
# Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
def _LicenseHeader(input_api):
|
|
"""Returns the license header regexp."""
|
|
license_header = (
|
|
r'.*? Copyright \(c\) %(year)s The WebRTC project authors\. '
|
|
r'All Rights Reserved\.\n'
|
|
r'.*?\n'
|
|
r'.*? Use of this source code is governed by a BSD-style license\n'
|
|
r'.*? that can be found in the LICENSE file in the root of the source\n'
|
|
r'.*? tree\. An additional intellectual property rights grant can be '
|
|
r'found\n'
|
|
r'.*? in the file PATENTS\. All contributing project authors may\n'
|
|
r'.*? be found in the AUTHORS file in the root of the source tree\.\n'
|
|
) % {
|
|
'year': input_api.time.strftime('%Y'),
|
|
}
|
|
return license_header
|
|
|
|
def _CommonChecks(input_api, output_api):
|
|
"""Checks common to both upload and commit."""
|
|
results = []
|
|
results.extend(input_api.canned_checks.CheckLongLines(
|
|
input_api, output_api))
|
|
results.extend(input_api.canned_checks.CheckChangeHasNoTabs(
|
|
input_api, output_api))
|
|
results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
|
|
input_api, output_api))
|
|
results.extend(input_api.canned_checks.CheckChangeTodoHasOwner(
|
|
input_api, output_api))
|
|
results.extend(input_api.canned_checks.CheckLicense(
|
|
input_api, output_api, _LicenseHeader(input_api)))
|
|
return results
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
results = []
|
|
results.extend(_CommonChecks(input_api, output_api))
|
|
return results
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
results = []
|
|
results.extend(_CommonChecks(input_api, output_api))
|
|
results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
|
|
results.extend(input_api.canned_checks.CheckChangeWasUploaded(
|
|
input_api, output_api))
|
|
results.extend(input_api.canned_checks.CheckChangeHasDescription(
|
|
input_api, output_api))
|
|
return results
|