67186fe00c
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
53 lines
1.6 KiB
C++
53 lines
1.6 KiB
C++
/*
|
|
* Copyright 2010 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_BASE_LINUXWINDOWPICKER_H_
|
|
#define WEBRTC_BASE_LINUXWINDOWPICKER_H_
|
|
|
|
#include "webrtc/base/basictypes.h"
|
|
#include "webrtc/base/scoped_ptr.h"
|
|
#include "webrtc/base/windowpicker.h"
|
|
|
|
// Avoid include <X11/Xlib.h>.
|
|
struct _XDisplay;
|
|
typedef unsigned long Window;
|
|
|
|
namespace rtc {
|
|
|
|
class XWindowEnumerator;
|
|
|
|
class X11WindowPicker : public WindowPicker {
|
|
public:
|
|
X11WindowPicker();
|
|
~X11WindowPicker() override;
|
|
|
|
static bool IsDesktopElement(_XDisplay* display, Window window);
|
|
|
|
bool Init() override;
|
|
bool IsVisible(const WindowId& id) override;
|
|
bool MoveToFront(const WindowId& id) override;
|
|
bool GetWindowList(WindowDescriptionList* descriptions) override;
|
|
bool GetDesktopList(DesktopDescriptionList* descriptions) override;
|
|
bool GetDesktopDimensions(const DesktopId& id,
|
|
int* width,
|
|
int* height) override;
|
|
uint8* GetWindowIcon(const WindowId& id, int* width, int* height);
|
|
uint8* GetWindowThumbnail(const WindowId& id, int width, int height);
|
|
int GetNumDesktops();
|
|
uint8* GetDesktopThumbnail(const DesktopId& id, int width, int height);
|
|
|
|
private:
|
|
scoped_ptr<XWindowEnumerator> enumerator_;
|
|
};
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_LINUXWINDOWPICKER_H_
|