bc6961fe32
The Codec class is a big class and objects of the Codec class are passed around by value. That means that inlined operations would be duplicated at many places, in particular inside STL. By not inlining Codec methods, webrtc shrinks by 50 KB in a Linux x64 clang build. Total change: -54147 bytes ========================== +2810 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.cc - (gained 2920, lost 110) -1003 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/codec.h - (gained 0, lost 1003) -1129 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/sctp/sctpdataengine.cc - (gained 1660, lost 2789) -1190 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/base/rtpdataengine.cc - (gained 1408, lost 2598) -1747 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/session/media/mediasession.cc - (gained 803, lost 2550) -2141 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine.cc - (gained 1679, lost 3820) -2250 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/app/webrtc/webrtcsdp.cc - (gained 1224, lost 3474) -2927 - Source: /usr/include/c++/4.8/bits/stl_vector.h - (gained 0, lost 2927) -3729 - Source: /home/bratell/src/chromium/src/third_party/libjingle/source/talk/media/webrtc/webrtcvideoengine2.cc - (gained 10925, lost 14654) -6369 - Source: /usr/include/c++/4.8/bits/vector.tcc - (gained 0, lost 6369) -10582 - Source: /usr/include/c++/4.8/bits/stl_heap.h - (gained 0, lost 10582) -19324 - Source: /usr/include/c++/4.8/bits/stl_algo.h - (gained 743, lost 20067) BUG= R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40729005 Cr-Commit-Position: refs/heads/master@{#8436} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8436 4adac7df-926f-26a2-2b94-8c16560cd09d |
||
---|---|---|
.. | ||
app/webrtc | ||
build | ||
examples | ||
media | ||
session/media | ||
codereview.settings | ||
COPYING | ||
libjingle_examples.gyp | ||
libjingle_media_unittest.isolate | ||
libjingle_p2p_unittest.isolate | ||
libjingle_peerconnection_unittest.isolate | ||
libjingle_sound_unittest.isolate | ||
libjingle_tests.gyp | ||
libjingle_unittest.isolate | ||
libjingle.gyp | ||
LICENSE_THIRD_PARTY | ||
OWNERS | ||
PRESUBMIT.py |