b0ed8f8a08
I don't believe I've witnessed this "feature" ever provide a benefit, and have now collected some evidence of its harm when using the extended filter mode. It can cause erroneous resets in two cases: 1. Some preprocessing noise suppression is enabled in the system (i.e. "audio enhancements") that push the noise floor very low, possibly to zero. If the filter is non-zero this condition can be triggered very easily, and erroneously. 2. Non-zero energy in the filter before the peak impulse response can cause a slight (and harmless) "pre-echo" in the error signal. This becomes more significant as the peak is set further back in the filter. This effect can cause needless resets during echo onsets. In short, this isn't a great criterion for filter reset and has the potential to cause serious harm. Ideally we would remove it entirely, but in the interests of safety, can start with the extended mode. BUG=1261 R=aluebs@webrtc.org, bjornv@webrtc.org Review URL: https://webrtc-codereview.appspot.com/3959004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5159 4adac7df-926f-26a2-2b94-8c16560cd09d