generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
9e1a6d7c23
webrtc/talk
History
Karl Wiberg 9e1a6d7c23 rtc::Buffer: Remove backwards compatibility band-aids 
This CL makes two changes to rtc::Buffer that have had to wait for
Chromium's use of it to be modernized:

  1. Change default return type of rtc::Buffer::data() from char* to
     uint8_t*. uint8_t is a more natural type for bytes, and won't
     accidentally convert to a string. (Chromium previously expected
     the default return type to be char, which is why
     rtc::Buffer::data() initially got char as default return type in
     9478437f, but that's been fixed now.)

  2. Stop accepting void* inputs in constructors and methods. While
     this is convenient, it's also dangerous since any pointer type
     will implicitly convert to void*.

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44269004

Cr-Commit-Position: refs/heads/master@{#9121}
2015-04-30 12:25:06 +00:00
..
app/webrtc Adds a MediaConstraint for the AudioOption aec_dump 2015-04-29 05:28:22 +00:00
build GYP variables for building expat, icu, libsrtp, usrsctp 2015-04-27 12:38:37 +00:00
examples Do not define POSIX. 2015-04-20 11:14:22 +00:00
media Remove ViECapture usage in VideoSendStream. 2015-04-30 10:16:11 +00:00
session/media rtc::Buffer: Remove backwards compatibility band-aids 2015-04-30 12:25:06 +00:00
codereview.settings Add codereview.settings to the /talk subdirectory 2014-12-05 13:47:37 +00:00
COPYING Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
libjingle_examples.gyp GYP variables for building expat, icu, libsrtp, usrsctp 2015-04-27 12:38:37 +00:00
libjingle_media_unittest.isolate Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
libjingle_p2p_unittest.isolate Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
libjingle_peerconnection_unittest.isolate Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
libjingle_tests.gyp Roll chromium_revision a12e1e1..0cb2549 (326495:327252) 2015-04-29 12:48:00 +00:00
libjingle.gyp GYP variables for building expat, icu, libsrtp, usrsctp 2015-04-27 12:38:37 +00:00
LICENSE_THIRD_PARTY Fix clang style warnings in webrtc/base 2015-03-09 22:24:25 +00:00
OWNERS Remove henrike@ from OWNERS 2015-04-01 15:08:49 +00:00
PRESUBMIT.py Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00