generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
9478437fde
webrtc/talk/media/base
History
Karl Wiberg 9478437fde rtc::Buffer improvements 
1. Constructors, SetData(), and AppendData() now accept uint8_t*,
     int8_t*, and char*. Previously, they accepted void*, meaning that
     any kind of pointer was accepted. I think requiring an explicit
     cast in cases where the input array isn't already of a byte-sized
     type is a better compromise between convenience and safety.

  2. data() can now return a uint8_t* instead of a char*, which seems
     more appropriate for a byte array, and is harder to mix up with
     zero-terminated C strings. data<int8_t>() is also available so
     that callers that want that type instead won't have to cast, as
     is data<char>() (which remains the default until all existing
     callers have been fixed).

  3. Constructors, SetData(), and AppendData() now accept arrays
     natively, not just decayed to pointers. The advantage of this is
     that callers don't have to pass the size separately.

  4. There are new constructors that allow setting size and capacity
     without initializing the array. Previously, this had to be done
     separately after construction.

  5. Instead of TransferTo(), Buffer now supports swap(), and move
     construction and assignment, and has a Pass() method that works
     just like std::move(). (The Pass method is modeled after
     scoped_ptr::Pass().)

R=jmarusic@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42989004

Cr-Commit-Position: refs/heads/master@{#9033}
2015-04-20 12:03:00 +00:00
..
audioframe.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
audiorenderer.h Unrevert 5590 "description"(=(Auto)update libjingle 61834300->61901702). 2014-02-21 15:51:43 +00:00
capturemanager_unittest.cc Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
capturemanager.cc ~CaptureManager: DCHECK(capture_states_.empty()) instead of CHECK until we fix not empty bug. 2015-04-02 10:10:18 +00:00
capturemanager.h Add thread checks to the CaptureManager. 2015-02-25 10:09:45 +00:00
capturerenderadapter.cc Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
capturerenderadapter.h Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
codec_unittest.cc (Auto)update libjingle 73222930-> 73226398 2014-08-13 17:26:08 +00:00
codec.cc Misc. cleanup split out of https://webrtc-codereview.appspot.com/37699004/ : 2015-02-23 21:29:45 +00:00
codec.h Check associated payload type when negotiate RTX codecs. 2015-03-16 04:15:23 +00:00
constants.cc Adding "usedtx" as Opus codec parameter. 2015-03-27 04:06:35 +00:00
constants.h Adding "usedtx" as Opus codec parameter. 2015-03-27 04:06:35 +00:00
cpuid_unittest.cc (Auto)update libjingle 72097588-> 72159069 2014-07-29 17:36:52 +00:00
cpuid.cc Remove DISABLE_YUV flag 2015-02-18 08:47:43 +00:00
cpuid.h (Auto)update libjingle 72097588-> 72159069 2014-07-29 17:36:52 +00:00
cryptoparams.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
device.h Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
executablehelpers.h Fix webrtcvideoframe tests. 2014-09-05 16:34:13 +00:00
fakecapturemanager.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
fakemediaengine.h rtc::Buffer improvements 2015-04-20 12:03:00 +00:00
fakemediaprocessor.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
fakenetworkinterface.h rtc::Buffer: Rename length to size, for conformance with the STL 2015-03-24 09:20:19 +00:00
fakertp.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
fakescreencapturerfactory.h (Auto)update libjingle 72839629-> 72847605 2014-08-07 22:09:08 +00:00
fakevideocapturer.h CVO capturer feature: allow unrotated frame flows through the capture pipeline. 2015-02-11 18:38:53 +00:00
fakevideorenderer.h Reland of: "Implement elapsed time and capture start NTP time estimation." revision @8139 2015-01-27 09:57:01 +00:00
filemediaengine_unittest.cc rtc::Buffer: Rename length to size, for conformance with the STL 2015-03-24 09:20:19 +00:00
filemediaengine.cc rtc::Buffer improvements 2015-04-20 12:03:00 +00:00
filemediaengine.h Remove GetStartCaptureFormat and some related code. 2015-04-13 17:44:56 +00:00
hybriddataengine.h Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
mediachannel.h Remove unused non-standard capture stats. 2015-03-27 09:01:11 +00:00
mediacommon.h (Auto)update libjingle 72097588-> 72159069 2014-07-29 17:36:52 +00:00
mediaengine.cc Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
mediaengine.h Remove SignalCaptureStateChange from MediaEngine. 2015-04-14 00:17:36 +00:00
mutedvideocapturer.cc (Auto)update libjingle 72682155-> 72785180 2014-08-07 04:47:36 +00:00
nullvideoframe.h Remove unused implementations in cricket::VideoFrame 2015-03-27 08:48:45 +00:00
rtpdataengine_unittest.cc rtc::Buffer improvements 2015-04-20 12:03:00 +00:00
rtpdataengine.cc rtc::Buffer improvements 2015-04-20 12:03:00 +00:00
rtpdataengine.h (Auto)update libjingle 77263371-> 77296420 2014-10-08 22:24:30 +00:00
rtpdump_unittest.cc Misc. cleanup split out of https://webrtc-codereview.appspot.com/37699004/ : 2015-02-23 21:29:45 +00:00
rtpdump.cc (Auto)update libjingle 73222930-> 73226398 2014-08-13 17:26:08 +00:00
rtpdump.h (Auto)update libjingle 72097588-> 72159069 2014-07-29 17:36:52 +00:00
rtputils_unittest.cc Avoid implicit type truncations by inserting explicit casts or modifying prototypes to avoid needless up- and then down-casting. 2015-02-02 23:54:40 +00:00
rtputils.cc Add range checks in a variety of places where the values will subsequently be 2015-02-17 20:37:35 +00:00
rtputils.h Add range checks in a variety of places where the values will subsequently be 2015-02-17 20:37:35 +00:00
screencastid.h Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
streamparams_unittest.cc (Auto)update libjingle 73222930-> 73226398 2014-08-13 17:26:08 +00:00
streamparams.cc Change GetStreamBySsrc to not copy StreamParams. 2015-01-22 23:00:41 +00:00
streamparams.h Change GetStreamBySsrc to not copy StreamParams. 2015-01-22 23:00:41 +00:00
testutils.cc Use std::min and std::max instead of self-defined functions such as rtc::_min/_max. 2015-02-12 11:55:32 +00:00
testutils.h Remove DISABLE_YUV flag 2015-02-18 08:47:43 +00:00
videoadapter_unittest.cc VideoAdapterTest: Replace FileVideoCapturer with FakeVideoCapturer 2015-04-10 09:18:39 +00:00
videoadapter.cc Delete VideoAdapter::AdaptFrame 2015-03-24 14:18:52 +00:00
videoadapter.h Delete VideoAdapter::AdaptFrame 2015-03-24 14:18:52 +00:00
videocapturer_unittest.cc WebRtcVideoFrame: Support odd resolutions 2015-03-18 09:22:19 +00:00
videocapturer.cc Enable CVO by default through webrtc pipeline. 2015-04-01 22:33:15 +00:00
videocapturer.h Use std::min and std::max instead of self-defined functions such as rtc::_min/_max. 2015-02-12 11:55:32 +00:00
videocapturerfactory.h Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
videocommon_unittest.cc (Auto)update libjingle 73222930-> 73226398 2014-08-13 17:26:08 +00:00
videocommon.cc Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
videocommon.h Roll chromium_revision 8af41b3..dcb0929 (324854:325030) 2015-04-15 15:22:19 +00:00
videoengine_unittest.h rtc::Buffer improvements 2015-04-20 12:03:00 +00:00
videoframe_unittest.h Roll chromium_revision 8af41b3..dcb0929 (324854:325030) 2015-04-15 15:22:19 +00:00
videoframe.cc Roll chromium_revision 8af41b3..dcb0929 (324854:325030) 2015-04-15 15:22:19 +00:00
videoframe.h Enable CVO by default through webrtc pipeline. 2015-04-01 22:33:15 +00:00
videoframefactory.cc cricket::VideoFrameFactory: Handle if created frame is null 2015-04-10 10:44:51 +00:00
videoframefactory.h Revert 8599 "Revert 8580 "Unify underlying frame buffer in I420VideoFrame and..."" 2015-03-05 14:03:51 +00:00
videoprocessor.h (Auto)update libjingle 73222930-> 73226398 2014-08-13 17:26:08 +00:00
videorenderer.h Add concept of whether video renderer supports rotation. 2015-03-12 21:38:19 +00:00
voiceprocessor.h Cleanup: Forward declare AudioFrame type in voiceprocess.h 2015-04-06 10:36:41 +00:00
yuvframegenerator.cc Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00
yuvframegenerator.h Update libjingle license statements at top of talk files for consistency 2015-01-20 21:36:13 +00:00