generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
8804a29951
webrtc/talk/xmpp
History
wu@webrtc.org 3c5d2b43ec Thread::Stop() must be called before any subclass's destructor completes. 
Update Thread documentation, fix all subclasses that had a problem.

This is to avoid a data racing between the destructor modifying the vtable, and
Thread::PreRun calling virtual method Run at the same time.

For example:
[ RUN      ] FileMediaEngineTest.TestGetCapabilities
==================
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=2967)
  Read of size 8 at 0x7d480000bd00 by thread T1:
    #0 talk_base::Thread::PreRun(void*) /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:353 (libjingle_media_unittest+0x000000234da8)

  Previous write of size 8 at 0x7d480000bd00 by main thread:
    #0 talk_base::Thread::~Thread() /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:158 (libjingle_media_unittest+0x00000023478c)
    #1 ~RtpSenderReceiver /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/media/base/filemediaengine.cc:122 (libjingle_media_unittest+0x0000001b551f)
    ...

RISK=P2
TESTED=try bots and tsan
BUG=2078,2080
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4999 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-18 16:27:26 +00:00
..
asyncsocket.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
chatroommodule_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
chatroommodule.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
chatroommoduleimpl.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
constants.cc Update talk to 52534915. 2013-09-19 05:49:50 +00:00
constants.h Update talk to 52534915. 2013-09-19 05:49:50 +00:00
discoitemsquerytask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
discoitemsquerytask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
fakexmppclient.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
hangoutpubsubclient_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
hangoutpubsubclient.cc Update talk to 52534915. 2013-09-19 05:49:50 +00:00
hangoutpubsubclient.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
iqtask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
iqtask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
jid_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
jid.cc Update talk folder to revision=49713299. 2013-07-22 21:07:49 +00:00
jid.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
jingleinfotask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
jingleinfotask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
module.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
moduleimpl.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
moduleimpl.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mucroomconfigtask_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mucroomconfigtask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mucroomconfigtask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mucroomdiscoverytask_unittest.cc * Update libjingle to 50389769. 2013-08-05 20:36:57 +00:00
mucroomdiscoverytask.cc Update libjingle to CL 53398036. 2013-09-27 23:04:10 +00:00
mucroomdiscoverytask.h * Update libjingle to 50389769. 2013-08-05 20:36:57 +00:00
mucroomlookuptask_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mucroomlookuptask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mucroomlookuptask.h * Update libjingle to 50389769. 2013-08-05 20:36:57 +00:00
mucroomuniquehangoutidtask_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mucroomuniquehangoutidtask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
mucroomuniquehangoutidtask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pingtask_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pingtask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pingtask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
plainsaslhandler.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
presenceouttask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
presenceouttask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
presencereceivetask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
presencereceivetask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
presencestatus.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
presencestatus.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
prexmppauth.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pubsub_task.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pubsub_task.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pubsubclient_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pubsubclient.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pubsubclient.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pubsubtasks_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pubsubtasks.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
pubsubtasks.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
receivetask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
receivetask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
rostermodule_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
rostermodule.h Update talk to 52534915. 2013-09-19 05:49:50 +00:00
rostermoduleimpl.cc Update talk to 52534915. 2013-09-19 05:49:50 +00:00
rostermoduleimpl.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
saslcookiemechanism.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
saslhandler.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
saslmechanism.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
saslmechanism.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
saslplainmechanism.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
util_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
util_unittest.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppauth.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppauth.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppclient.cc Update talk folder to revision=49713299. 2013-07-22 21:07:49 +00:00
xmppclient.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppclientsettings.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppengine_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppengine.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppengineimpl_iq.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppengineimpl.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppengineimpl.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmpplogintask_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmpplogintask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmpplogintask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmpppump.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmpppump.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppsocket.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppsocket.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppstanzaparser_unittest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppstanzaparser.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppstanzaparser.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmpptask.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmpptask.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
xmppthread.cc Thread::Stop() must be called before any subclass's destructor completes. 2013-10-18 16:27:26 +00:00
xmppthread.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00