It breaks integration with upstream re2 library on Chromium.
Without patching re2 library, with this define, it produces the
following error:
../../third_party/re2/re2/re2.h:254:5: error: expected identifier
    POSIX, // POSIX syntax, leftmost-longest match
As we define POSIX on the command line, the C preprocessor changes
RE2::POSIX to nothing and thus break the compilation. :(
See chromium-dev mailing list for this discussion in
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/UXCHnX7pV44/discussion
BUG=None
TEST=ninja -C out/Debug, everything compiles as before
R=sergeyu@chromium.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46049004
Patch from Thiago Farina <tfarina@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#9032}
		
	
		
			
				
	
	
		
			69 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			69 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
/*
 | 
						|
 * libjingle
 | 
						|
 * Copyright 2004--2005 Google Inc.
 | 
						|
 *
 | 
						|
 * Redistribution and use in source and binary forms, with or without
 | 
						|
 * modification, are permitted provided that the following conditions are met:
 | 
						|
 *
 | 
						|
 *  1. Redistributions of source code must retain the above copyright notice,
 | 
						|
 *     this list of conditions and the following disclaimer.
 | 
						|
 *  2. Redistributions in binary form must reproduce the above copyright notice,
 | 
						|
 *     this list of conditions and the following disclaimer in the documentation
 | 
						|
 *     and/or other materials provided with the distribution.
 | 
						|
 *  3. The name of the author may not be used to endorse or promote products
 | 
						|
 *     derived from this software without specific prior written permission.
 | 
						|
 *
 | 
						|
 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
 | 
						|
 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
 | 
						|
 * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
 | 
						|
 * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 | 
						|
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
 | 
						|
 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
 | 
						|
 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
 | 
						|
 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
 | 
						|
 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
 | 
						|
 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 | 
						|
 */
 | 
						|
 | 
						|
#if defined(WEBRTC_POSIX)
 | 
						|
#include <errno.h>
 | 
						|
#endif  // WEBRTC_POSIX
 | 
						|
 | 
						|
#include <iostream>
 | 
						|
 | 
						|
#include "webrtc/p2p/base/stunserver.h"
 | 
						|
#include "webrtc/base/thread.h"
 | 
						|
 | 
						|
using namespace cricket;
 | 
						|
 | 
						|
int main(int argc, char* argv[]) {
 | 
						|
  if (argc != 2) {
 | 
						|
    std::cerr << "usage: stunserver address" << std::endl;
 | 
						|
    return 1;
 | 
						|
  }
 | 
						|
 | 
						|
  rtc::SocketAddress server_addr;
 | 
						|
  if (!server_addr.FromString(argv[1])) {
 | 
						|
    std::cerr << "Unable to parse IP address: " << argv[1];
 | 
						|
    return 1;
 | 
						|
  }
 | 
						|
 | 
						|
  rtc::Thread *pthMain = rtc::Thread::Current();
 | 
						|
 | 
						|
  rtc::AsyncUDPSocket* server_socket =
 | 
						|
      rtc::AsyncUDPSocket::Create(pthMain->socketserver(), server_addr);
 | 
						|
  if (!server_socket) {
 | 
						|
    std::cerr << "Failed to create a UDP socket" << std::endl;
 | 
						|
    return 1;
 | 
						|
  }
 | 
						|
 | 
						|
  StunServer* server = new StunServer(server_socket);
 | 
						|
 | 
						|
  std::cout << "Listening at " << server_addr.ToString() << std::endl;
 | 
						|
 | 
						|
  pthMain->Run();
 | 
						|
 | 
						|
  delete server;
 | 
						|
  return 0;
 | 
						|
}
 |