4723dc88b3
So, the test apparently failed right away at http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/1224/steps/libjingle_p2p_unittest/logs/stdio > Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux" > > According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2 > r5505 was committed to resolve exactly these flakes. > Let's revert the disabling and see. > > BUG=2907 > TBR=mallinath@webrtc.org > > > Disable failing libjingle_p2p_unittest test on Linux > > > > I realize this diables 84 test cases and for all platforms, which > > I'm not really comfortable with. I tried finding a better way but > > couldn't without doing significant changes to the file. > > I think the tests either needs to be fixed or otherwise refactored > > in order to make more fine-grained disabling possible. > > > > Another (too) large disabling was done by holmer@ in > > https://webrtc-codereview.appspot.com/2227004 where he should only have > > disabled them on Windows, if the failures in webrtc:2383 was all that > > caused those flakes. > > > > BUG=2907 > > TEST=Verified this ran 0 tests: > > out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay > > TBR=wu@webrtc.org > > > > Review URL: https://webrtc-codereview.appspot.com/8309004 > > TBR=kjellander@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/8329004 TBR=kjellander@webrtc.org Review URL: https://webrtc-codereview.appspot.com/8339004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5513 4adac7df-926f-26a2-2b94-8c16560cd09d |
||
|---|---|---|
| .. | ||
| base | ||
| client | ||