Go to file
andrew@webrtc.org 6cd201cf31 Revert 5775 "Modify bitrate controller to update bitrate based o..."
This triggered an occasional TSAN failure in
CallTest.ReceivesPliAndRecoversWithNack e.g.:
http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan/builds/1444/steps/memory%20test%3A%20video_engine_tests/logs/stdio

I managed to reproduce this locally and verified that reverting this CL
corrected it.

> Modify bitrate controller to update bitrate based on process call and not
> only whenever a RTCP receiver block is received.
> 
> Additionally:
>  Add condition to only start rampup after a receiver block is received. This was same as old behaviour but now an explicit check is needed to verify process does not ramps up before the first block.
> 
>  Fix logic around capping max bitrate increase at 8% per second. Before it was only increasing once every 1 second and each increase would be as high as 8%. If receiver blocks had a different interval before it would lose an update or waste an update slot and not ramp up as much as a 8% (e.g. if RTCP received < 1 second).
> 
>  Did not touch decrease logic, however since it can be triggered more often it
>  may decrease much faster and closer to the original written cap of once every
>  300ms + rtt.
> 
> Note:
>  rampup_tests.cc don't seem to be affected by this since there is no packet loss or REMB that go higher than expected cap.
>  bitrate_controller_unittests.cc are don't really simulate a clock and the process thread, but trigger update by inserting an rtcp block.
> 
> BUG=3065
> R=stefan@webrtc.org, mflodman@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/10529004

TBR=andresp@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10079005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5785 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 19:42:39 +00:00
data Enables robust delay validation in AEC delay logging. 2014-01-13 08:54:34 +00:00
resources Add tests and modify tools for new float deinterleaved interface. 2014-03-10 22:26:12 +00:00
samples/js turn-prober: enable running headlessly and only emit output on error. 2014-03-17 16:27:41 +00:00
talk Fix after auto update: removed files were brought back. 2014-03-25 18:17:02 +00:00
third_party Document updating gflags and remove code duplication. 2013-08-20 16:17:10 +00:00
tools Disable flaky WebRtcVideoMediaChannelTests on memcheck and tsan. 2014-03-24 20:57:42 +00:00
webrtc Revert 5775 "Modify bitrate controller to update bitrate based o..." 2014-03-25 19:42:39 +00:00
.clang-format Style-option file for clang-format. 2013-11-25 15:30:37 +00:00
.gitignore (Git)ignore all of /net. Works around issue: gclient sync, git clean -df, gclient runhooks -> failure (regression in r4466). 2014-03-12 15:50:36 +00:00
all.gyp Reorganize libjingle path variables. 2014-03-05 00:40:33 +00:00
android-webrtc.mk Changed a flag in ARM build for platform build. 2012-09-08 00:32:59 +00:00
Android.mk Added buildbot benchmarking in iSAC and APM into Android platform build. 2012-12-07 15:26:28 +00:00
AUTHORS Add ability to receive calls for iOS 2014-02-10 18:47:11 +00:00
BUILD.gn Fix BUILD.gn to load all Chromium GN configurations. 2014-02-10 21:28:55 +00:00
codereview.settings Add a root codereview.settings file. 2013-04-24 02:08:50 +00:00
COPYING Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
DEPS Roll Opus with ARM optimizations enabled to WebRTC 2014-03-25 16:12:43 +00:00
drover.properties Add a drover.properties file for reference. 2013-05-30 18:15:54 +00:00
libvpx.mk Change android makefile to reflect recent file structure change 2011-07-13 17:49:49 +00:00
LICENSE Updated license path in LICENSE and LICENSE_THIRD_PARTY. 2012-11-22 12:06:21 +00:00
license_template.txt Update template to follow chromium copyright style 2013-04-24 01:01:28 +00:00
LICENSE_THIRD_PARTY Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
OWNERS Android, OpenSlDemo: moved to webrtc/examples/android/opensl_loopback 2014-01-17 23:12:51 +00:00
PATENTS Add references to src/ copies for LICENSE etc. 2011-10-26 01:05:07 +00:00
PRESUBMIT.py Exclude /out* instead of just /out from pylint checks. 2014-03-01 02:09:36 +00:00
WATCHLISTS Add qiang.lu@intel.com to WATCHLISTS. 2013-10-25 19:20:02 +00:00