a73d746562
Rease for revert: failed internal test cases > cricket::VideoAdapter: Drop frames before spending time converting/scaling, not after. > > In VideoCapturer::OnFrameCaptured, we currently convert cricket::CapturedFrame to cricket::VideoFrame and then send that to VideoAdapter::AdaptFrame. AdaptFrame may then decide to drop the frame. It would be faster to drop the frame before converting to cricket::VideoFrame. > > This CL refactors VideoAdapter with a new function AdaptFrameResolution that takes captured resolution as input and output adapted resolution, or 0x0 if the frame should be dropped. Using that function, frames can be dropped before any conversion takes place. > > R=fbarchard@google.com, perkj@webrtc.org, tommi@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/29949004 TBR=magjed@webrtc.org Review URL: https://webrtc-codereview.appspot.com/24279004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7703 4adac7df-926f-26a2-2b94-8c16560cd09d
53 lines
2.2 KiB
C++
Executable File
53 lines
2.2 KiB
C++
Executable File
// libjingle
|
|
// Copyright 2014 Google Inc.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are met:
|
|
//
|
|
// 1. Redistributions of source code must retain the above copyright notice,
|
|
// this list of conditions and the following disclaimer.
|
|
// 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
// this list of conditions and the following disclaimer in the documentation
|
|
// and/or other materials provided with the distribution.
|
|
// 3. The name of the author may not be used to endorse or promote products
|
|
// derived from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
|
|
// WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
|
|
// EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
|
|
// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
|
|
// OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
// WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
|
|
// OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
|
|
// ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
//
|
|
|
|
#ifndef TALK_MEDIA_BASE_VIDEOFRAMEFACTORY_H_
|
|
#define TALK_MEDIA_BASE_VIDEOFRAMEFACTORY_H_
|
|
|
|
namespace cricket {
|
|
|
|
struct CapturedFrame;
|
|
class VideoFrame;
|
|
|
|
// Creates cricket::VideoFrames, or a subclass of cricket::VideoFrame
|
|
// depending on the subclass of VideoFrameFactory.
|
|
class VideoFrameFactory {
|
|
public:
|
|
VideoFrameFactory() {}
|
|
virtual ~VideoFrameFactory() {}
|
|
|
|
// The returned frame aliases the aliased_frame if the input color
|
|
// space allows for aliasing, otherwise a color conversion will
|
|
// occur. For safety, |input_frame| must outlive the returned
|
|
// frame. Returns NULL if conversion fails.
|
|
virtual VideoFrame* CreateAliasedFrame(
|
|
const CapturedFrame* input_frame, int width, int height) const = 0;
|
|
};
|
|
|
|
} // namespace cricket
|
|
|
|
#endif // TALK_MEDIA_BASE_VIDEOFRAMEFACTORY_H_
|