
Mostly this consists of marking functions with override when applicable, and moving function bodies from .h to .cc files. Not inlining virtual functions with simple bodies such as { return false; } strikes me as probably losing more in readability than we gain in binary size and compilation time, but I guess it's just like any other case where enabling a generally good warning forces us to write slightly worse code in a couple of places. BUG=163 R=kjellander@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47429004 Cr-Commit-Position: refs/heads/master@{#8656} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
66 lines
1.9 KiB
C++
66 lines
1.9 KiB
C++
/*
|
|
* Copyright 2008 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_BASE_NETHELPERS_H_
|
|
#define WEBRTC_BASE_NETHELPERS_H_
|
|
|
|
#if defined(WEBRTC_POSIX)
|
|
#include <netdb.h>
|
|
#include <stddef.h>
|
|
#elif WEBRTC_WIN
|
|
#include <winsock2.h> // NOLINT
|
|
#endif
|
|
|
|
#include <list>
|
|
|
|
#include "webrtc/base/asyncresolverinterface.h"
|
|
#include "webrtc/base/signalthread.h"
|
|
#include "webrtc/base/sigslot.h"
|
|
#include "webrtc/base/socketaddress.h"
|
|
|
|
namespace rtc {
|
|
|
|
class AsyncResolverTest;
|
|
|
|
// AsyncResolver will perform async DNS resolution, signaling the result on
|
|
// the SignalDone from AsyncResolverInterface when the operation completes.
|
|
class AsyncResolver : public SignalThread, public AsyncResolverInterface {
|
|
public:
|
|
AsyncResolver();
|
|
~AsyncResolver() override;
|
|
|
|
void Start(const SocketAddress& addr) override;
|
|
bool GetResolvedAddress(int family, SocketAddress* addr) const override;
|
|
int GetError() const override;
|
|
void Destroy(bool wait) override;
|
|
|
|
const std::vector<IPAddress>& addresses() const { return addresses_; }
|
|
void set_error(int error) { error_ = error; }
|
|
|
|
protected:
|
|
void DoWork() override;
|
|
void OnWorkDone() override;
|
|
|
|
private:
|
|
SocketAddress addr_;
|
|
std::vector<IPAddress> addresses_;
|
|
int error_;
|
|
};
|
|
|
|
// rtc namespaced wrappers for inet_ntop and inet_pton so we can avoid
|
|
// the windows-native versions of these.
|
|
const char* inet_ntop(int af, const void *src, char* dst, socklen_t size);
|
|
int inet_pton(int af, const char* src, void *dst);
|
|
|
|
bool HasIPv6Enabled();
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_NETHELPERS_H_
|